Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Fixes: f07e9df45 "sanity: Add various shader_runner tests"
Reported-by: Mark Janes <mark.a.janes@intel.com>
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
|
|
Piglit fails to build with this commit.
This reverts commit f07e9df45113d01058cc1bca794d623605c41881.
|
|
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Acked-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
This is the old interface which is now not depended on by any tests.
v2: - remove shader_test interfaces as well
|
|
v2: - Serialize no-process-isolation shader runner tests
|
|
This converts the two test types that use the fast-skipping mechanism
(glsl parser and shader) to use the new interfaces. This has been
verified by running with PIGLIT_NO_FAST_SKIP=1 and without, and sans 1
test (that is fixed later in the series) the results are the same.
|
|
|
|
Currently fast skipping is implemented such that it assumes there's a
single version of ES, a single version of desktop, and all extensions
are shared between them. This has basically worked because 1) there are
basically no gles1 tests, and 2) piglit didn't have compat profile. But
worked and correct are two different things.
With the addition of compat profiles it's time to re-evaluate how fast
skipping works. Namely we need to have different attributes for ES1,
ES1+, core, compat, and I've added on for "legacy" (pre-profile), since
waffle supports that.
This maintains legacy interfaces so that existing code continues to
work.
v2: - Fix versions < 3.1 on implementations without core profile
|
|
So don't treat it like one. Stops one test from being fast-skipped that
shouldn't be.
|
|
|
|
These tests test the case when initialising with incompatible type
changed a type of the variable being initialized.
While main manifestation of the issue is overly verbose and incorrect
error message it did result in a crash in case of second test.
v2: Splitted the test in several ones (Timothy Arceri)
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547
|
|
These tests caught a bug in an optimized version of nir_op_fsign that I
was working on for i965. I thought of a couple clever ways to optimize
sign(a)*sign(b), but most of those ways would fail one or more of the
tests with ±Inf.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
|
|
y: Fix it
Hard to believe that this was never noticed...
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
|
|
Ensure that the allocated buffer is guaranteed to be big enough.
Acked-by: Timothy Arceri <tarceri@itsqueeze.com>
|
|
The optimizer recently added the ability to replace a compare with a
subtraction under certain circumstances. This can fail for integers.
For inputs a = 0x80000000, b = 4, int(0x80000000) < 4, but
int(0x80000000) - 4 overflows and results in 0x7ffffffc. That's not
less than zero, so the flags get set differently than for (a < b).
This really only affected the signed comparisons because the subtract
would always have a signed source types, so it wouldn't be seen as a
match for the compare with unsigned source types.
v2: Just require GL_EXT_shader_integer_mix. Remove stray change to
tests/spec/CMakeLists.txt. Both suggested by Ilia. Since this is no
longer a "stock" GLSL 1.30 test, move to tests/shaders/.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Cc: Matt Turner <mattst88@gmail.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
|
|
Cc: Mark Janes <mark.a.janes@intel.com>
Cc: Dylan Baker <dylanx.c.baker@intel.com>
Cc: Juan A. Suarez Romero <jasuarez@igalia.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Cc: Mark Janes <mark.a.janes@intel.com>
Cc: Dylan Baker <dylanx.c.baker@intel.com>
Cc: Juan A. Suarez Romero <jasuarez@igalia.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
v2: Use uintptr_t
v3: Formatting
v4: More uintptr_t
Acked-by: Jan Vesely <jan.vesely@rutgers.edu>
|
|
v2: 1) Use correct coding style (Ian Romanick)
2) Refactor code (Ian Romanick)
3) Merge DEPTH_CLAMP_NEAR_AMD and DEPTH_CLAMP_FAR_AMD state check in
single file (Ian Romanick)
4) Add missing piglit_require_extension method (Marek Olask)
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Tested-by: Marek Olšák <marek.olsak@amd.com>
|
|
Without this, validate_current_gl_context never returns true if
spirv_replaces_glsl == true, resulting in repeatedly calling
recreate_gl_context indefinitely after the first subtest.
Fixes: 0baf4e2708c "shader_runner/spirv: support loading SPIR-V shaders"
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
|
|
When EGL_KHR_create_context was originally written,
EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR was an invalid
attribute for OpenGL ES.
After moving the extension to core EGL 1.5, the aforementioned
attribute was made valid for both OpenGL and OpenGL ES.
Check whether the EGL version is lower than 1.5 before checking
EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR is an invalid
attribute.
Signed-off-by: Miguel A Vico Moya <mvicomoya@nvidia.com>
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
[Eric: trivial rename of the function to add `_at_least`]
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
|
|
As of commit 781a78914c7, this test fails with:
arb_vertex_array-delete-object-0: src/mesa/main/hash.c:240: _mesa_HashRemove_unlocked: Assertion `key' failed.
Aborted (core dumped)
Marek already has a patch on the Mesa list for this issue.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
|
|
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Cc: Eero Tamminen <eero.t.tamminen@intel.com>
Cc: Mark Janes <mark.a.janes@intel.com>
|
|
Also fixes apparently missing coverage for special
input arguments not passed in registers.
Reviewed-by: Jan Vesely <jan.vesely@rutgers.edu>
|
|
Reviewed-by: Jan Vesely <jan.vesely@rutgers.edu>
|
|
The negative tests in this group require some inference from various
specs. A spec bug has been submitted against the
GL_ARB_fragment_shader_interlock spec.
Currently none of the negative tests produce the expected result on
Mesa.
v2: Add test for switch-statements. Noticed by Jason.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
|
|
Currently none of the negative tests produce the expected result on
Mesa. There are other cases called out by the spec as things you cannot
do, but it's not clear what the expected result is in those cases
(compile- or link-time error, undefined rendering, GPU hang, house fire,
etc.).
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
|
|
>From Section 3.3. (Preprocessor) of the GLSL 4.60 spec:
"The following operators are also available:
defined
##
...
Any directive not listed above will cause a compile-time error."
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
|
|
Needed by the tessellation evaluation shader.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
|
|
This test exposes a Mesa GLSL linker bug. The test fails with the
following error message:
error: fragment shader input `foo' has no matching output in the previous
stage
Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias@globallogic.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105731
|
|
Otherwise these tests fail in odd ways when running from an installed
instance.
Cc: Alejandro Piñeiro <apinheiro@igalia.com>
Cc: Clayton Craft <clayton.a.craft@intel.com>
Reviewed-by: Mark Janes <mark.a.janes@intel.com>
Tested-by: Mark Janes <mark.a.janes@intel.com>
|
|
Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files"
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
|
|
It doesn't happen anywhere right now, but a caller could say it doesn't
want the source, only its size, and in that case we would just leak that
memory.
Let's only actually allocate it when the caller wants it and will take
ownership of that memory.
Suggested-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
|
|
CovID: 1438468 (UNINIT)
Fixes: e49d4479d6cabce970bb9 egl: Add basic EGL_MESA_device_software test"
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
|
|
CovID: 1438470 (UNINIT)
Fixes: 6c08c9fab326a526b41e1 "egl: Add basic EGL_EXT_device_drm test"
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
|
|
CovID: 1438469 (RESOURCE_LEAK)
Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files"
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
|
|
CovID: 1438471 (RESOURCE_LEAK)
Fixes: 7ec9b1734b66ee41c2700 "arb_gpu_shader5: Add support for testing
spirv with XFB streams"
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
|
|
The first call gives us the number of devices, while the second
populates the user provided array. Check that the second call returns at
least one device.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
Since the functionality is more or less identical to
EGL_MESA_platform_surfaceless, the test with a copy of it.
Changes, as listed in the test itself, include:
- s/MESA_platform_surfaceless/EXT_platform_device/g
- entrypoint handling - eglQueryDeviceStringEXT, eglQueryDevicesEXT
and eglGetPlatformDisplayEXT
- custom GetDisplay, based on eglQueryDevicesEXT
- couple of s/PIGLIT_SKIP/PIGLIT_FAIL/
v2: Use eglQueryDeviceStringEXT to get a DRM backed device (Mathias)
v3: PIGLIT_SKIP when missing a DRM device in get_device_display (Mathias)
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
Plug the memory leaks in the PASS case. It might be worth doing the same
throughout, although that is too invasive for what I have time for.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
Cover the new token and the interactions with EGL_EXT_platform_device.
Pay attention to Issue 1 of the spec, the fd ownership and ensure we
query back the same EGLDevice.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
Call eglTerminate, otherwise we'll end up with massive leaks reported in
Valgrind. Fairly useful when checking if the EGL implementation is
leak-free.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
In the unlikely case that the function fails, we want some feedback
about the issue. It's not a failure per-se, but we don't want to
silently continue.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
The arguments are optional. Since we don't care about the version, use
NULL instead.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
The extension doesn't do anything useful but report a device ext.
string. Ensure that such a device does not attempt to expose DRM
specifics - nearly missed that during development.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
The function returns EGL_BAD_DEVICE_EXT when an invalid device is used.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Mathias Fröhlich <mathias.froehlich@web.de>
|
|
Acked-by: Timothy Arceri <tarceri@itsqueeze.com>
|