summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Romanick <ian.d.romanick@intel.com>2018-09-09 15:32:11 -0700
committerIan Romanick <ian.d.romanick@intel.com>2018-09-19 00:33:06 -0700
commit1a8e582aadd8b93bf167cf13a5779a21db4770a0 (patch)
treeb3825340158465fbb0e061f7af94dd1a1a9d0b40
parent743a65f82e6fe5bb097d0af92e046b4f08821e9e (diff)
glsl-1.10: Verify result of sign(a)*sign(b)
These tests caught a bug in an optimized version of nir_op_fsign that I was working on for i965. I thought of a couple clever ways to optimize sign(a)*sign(b), but most of those ways would fail one or more of the tests with ±Inf. Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
-rw-r--r--tests/spec/glsl-1.10/execution/fs-sign-times-sign.shader_test53
-rw-r--r--tests/spec/glsl-1.10/execution/vs-sign-times-sign.shader_test61
2 files changed, 114 insertions, 0 deletions
diff --git a/tests/spec/glsl-1.10/execution/fs-sign-times-sign.shader_test b/tests/spec/glsl-1.10/execution/fs-sign-times-sign.shader_test
new file mode 100644
index 000000000..c46320b20
--- /dev/null
+++ b/tests/spec/glsl-1.10/execution/fs-sign-times-sign.shader_test
@@ -0,0 +1,53 @@
+[require]
+GLSL >= 1.10
+
+[vertex shader passthrough]
+
+[fragment shader]
+uniform vec4 v[25];
+
+void main()
+{
+ vec4 color = vec4(0.0, 1.0, 0.0, 1.0);
+
+ for (int i = 0; i < 25; i++) {
+ if (sign(v[i].x) * sign(v[i].y) != v[i].z)
+ color = vec4(1.0, 0.0, 0.0, 1.0);
+ }
+
+ gl_FragColor = color;
+}
+
+[test]
+uniform vec4 v[0] 5.0 5.0 1.0 0.0
+uniform vec4 v[1] 5.0 -5.0 -1.0 0.0
+uniform vec4 v[2] 5.0 0.0 0.0 0.0
+uniform vec4 v[3] 5.0 0x7f000000 1.0 0.0
+uniform vec4 v[4] 5.0 0xff000000 -1.0 0.0
+
+uniform vec4 v[5] -5.0 5.0 -1.0 0.0
+uniform vec4 v[6] -5.0 -5.0 1.0 0.0
+uniform vec4 v[7] -5.0 0.0 0.0 0.0
+uniform vec4 v[8] -5.0 0x7f000000 -1.0 0.0
+uniform vec4 v[9] -5.0 0xff000000 1.0 0.0
+
+uniform vec4 v[10] 0.0 5.0 0.0 0.0
+uniform vec4 v[11] 0.0 -5.0 0.0 0.0
+uniform vec4 v[12] 0.0 0.0 0.0 0.0
+uniform vec4 v[13] 0.0 0x7f000000 0.0 0.0
+uniform vec4 v[14] 0.0 0xff000000 0.0 0.0
+
+uniform vec4 v[15] 0x7f000000 5.0 1.0 0.0
+uniform vec4 v[16] 0x7f000000 -5.0 -1.0 0.0
+uniform vec4 v[17] 0x7f000000 0.0 0.0 0.0
+uniform vec4 v[18] 0x7f000000 0x7f000000 1.0 0.0
+uniform vec4 v[19] 0x7f000000 0xff000000 -1.0 0.0
+
+uniform vec4 v[20] 0xff000000 5.0 -1.0 0.0
+uniform vec4 v[21] 0xff000000 -5.0 1.0 0.0
+uniform vec4 v[22] 0xff000000 0.0 0.0 0.0
+uniform vec4 v[23] 0xff000000 0x7f000000 -1.0 0.0
+uniform vec4 v[24] 0xff000000 0xff000000 1.0 0.0
+
+draw rect -1 -1 2 2
+probe rgb 1 1 0.0 1.0 0.0
diff --git a/tests/spec/glsl-1.10/execution/vs-sign-times-sign.shader_test b/tests/spec/glsl-1.10/execution/vs-sign-times-sign.shader_test
new file mode 100644
index 000000000..ab28b650a
--- /dev/null
+++ b/tests/spec/glsl-1.10/execution/vs-sign-times-sign.shader_test
@@ -0,0 +1,61 @@
+[require]
+GLSL >= 1.10
+
+[vertex shader]
+uniform vec4 v[25];
+
+varying vec4 color;
+
+void main()
+{
+ color = vec4(0.0, 1.0, 0.0, 1.0);
+
+ for (int i = 0; i < 25; i++) {
+ if (sign(v[i].x) * sign(v[i].y) != v[i].z)
+ color = vec4(1.0, 0.0, 0.0, 1.0);
+ }
+
+ gl_Position = gl_Vertex;
+}
+
+[fragment shader]
+varying vec4 color;
+
+void main()
+{
+ gl_FragColor = color;
+}
+
+[test]
+uniform vec4 v[0] 5.0 5.0 1.0 0.0
+uniform vec4 v[1] 5.0 -5.0 -1.0 0.0
+uniform vec4 v[2] 5.0 0.0 0.0 0.0
+uniform vec4 v[3] 5.0 0x7f000000 1.0 0.0
+uniform vec4 v[4] 5.0 0xff000000 -1.0 0.0
+
+uniform vec4 v[5] -5.0 5.0 -1.0 0.0
+uniform vec4 v[6] -5.0 -5.0 1.0 0.0
+uniform vec4 v[7] -5.0 0.0 0.0 0.0
+uniform vec4 v[8] -5.0 0x7f000000 -1.0 0.0
+uniform vec4 v[9] -5.0 0xff000000 1.0 0.0
+
+uniform vec4 v[10] 0.0 5.0 0.0 0.0
+uniform vec4 v[11] 0.0 -5.0 0.0 0.0
+uniform vec4 v[12] 0.0 0.0 0.0 0.0
+uniform vec4 v[13] 0.0 0x7f000000 0.0 0.0
+uniform vec4 v[14] 0.0 0xff000000 0.0 0.0
+
+uniform vec4 v[15] 0x7f000000 5.0 1.0 0.0
+uniform vec4 v[16] 0x7f000000 -5.0 -1.0 0.0
+uniform vec4 v[17] 0x7f000000 0.0 0.0 0.0
+uniform vec4 v[18] 0x7f000000 0x7f000000 1.0 0.0
+uniform vec4 v[19] 0x7f000000 0xff000000 -1.0 0.0
+
+uniform vec4 v[20] 0xff000000 5.0 -1.0 0.0
+uniform vec4 v[21] 0xff000000 -5.0 1.0 0.0
+uniform vec4 v[22] 0xff000000 0.0 0.0 0.0
+uniform vec4 v[23] 0xff000000 0x7f000000 -1.0 0.0
+uniform vec4 v[24] 0xff000000 0xff000000 1.0 0.0
+
+draw rect -1 -1 2 2
+probe rgb 1 1 0.0 1.0 0.0