summaryrefslogtreecommitdiff
path: root/sw/inc
AgeCommit message (Collapse)AuthorFilesLines
2 daysmake modcfg ConfigItems listen to the config changes.Caolán McNamara1-1/+1
Change-Id: I9ba49ff8df463519631e698ce5916f0126c5d7b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
4 daysIndex Link is a programmatic nameNoel Grandin1-1/+1
Change-Id: Id909800fdd5db5dd2eadec92774c1dda4a435c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178735 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daystdf#163620 [API CHANGE] Add UI for libreoffice themesSahil Gautam1-0/+2
Instead of Color, we have Light and Dark in the registry. So each theme extension will specify dark and light color values for each "customizable element" like DocColor etc. Under appearance we have three radio buttons - light/dark/system. If system is selected then light/dark colors are switched based on the system's theme. if explicitly light/dark is selected - that color is used from the registry. ColorConfigValue now has three entries nColor, nLightColor, nDarkColor. nColor is used as a cache for the color being used at the moment. This is to avoid otherwise expensive function calls + hundreds of modifications in the codebase just to change nColor. nColor is cached either when the theme is loaded or when changes are committed in `ColorConfig_Impl::ImplCommit()`. Now, if Automatic theme is selected then themes is disabled and the application uses the system colors. If some other scheme is selected like "CustomTheme" etc, then LibreOffice themes/UI color customization is enabled and the theme colors are used. Instead of a scroll window, now we have a combobox for the registry entries and a single color dropdown to select the color value. This color dropdown is for convinience in case the user wants to change some specific color that's bothering him. For themeing, theme extensions should be used. API CHANGE + remove Color in favour of Light and Dark + AppBackground has additional two - BackgroundType and Bitmap + remove officecfg::Office::Common::Misc::Appearnce in favor of officecfg::Office::Common::Appearance::ApplicationAppearance + move LibreofficeTheme under officecfg::Office::Common::Appearance UI + it looks like https://i.imgur.com/UMxjfuC.png which is a little different from how the [mockup] on the ticket describes it, and that's because of lack of time due to upcomming feature freeze. + system/light/dark allow the user to switch between light/dark modes based on either the system theme (system) or by manually specifying light/dark. + ui themeing and color customization is disabled when automatic theme is selected, and enabled otherwise. [mockup]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=197469 Change-Id: I1a7f70dfe44b81f863814f87e8d46e146c0e3d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174835 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
5 daysuse more concrete UNO in swNoel Grandin4-5/+9
Change-Id: Ie83d957349f123bca0fd46ce3144ce778c3ec101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178704 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
6 daysuse more concrete UNO in swNoel Grandin2-1/+2
Change-Id: I664c7eff512625f988a2a278062719d3084845dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 dayssw: pStt -> pStartXisco Fauli1-4/+4
Change-Id: If2d8574e732581b5726734e2ac24196242a52d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178642 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
10 daysGetCountOrName returns a UI nameNoel Grandin1-0/+1
But the caller in SwXStyleFamily::getByIndex was treating the return value like a programmatic name. Change-Id: I6b3779be834f713e09a026fdcbf965753a77cc9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178381 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
12 daystdf#159549 sw: try to fix style mapping for Table StylesMichael Stahl1-1/+3
Fix the SwStyleNameMapper mapping for all families except TabStyle because testTdf129568ui fails; commit 7d08664be4d9a949718ce66e3bc974105a10284c "tdf#129568 Rename the default table style" indicates that earlier LO versions wrote UIName into table:template-name attributes which is quite tragic and prevents fixing this case. Rename SwXTextCellStyle::m_sParentStyle to m_sTableStyleUIName Actual changes to name conversion in SwXStyleFamily::insertByName(), SwXStyleFamily::replaceByName(), SwXStyleFamily::removeByName(), SwXTextTableStyle::setName(), SwXTextCellStyle::isInUse() Change-Id: I886d1196f0a4e93b0770d2859beddd9424a79430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177860 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
13 daystdf#159549 sw: rename SwXStyle variables to make it more obviousMichael Stahl1-5/+14
There are only 2 actual changes in behaviour, in SwXStyle::getName() and SwXStyle::setName(): these now convert the name, but in practice it should not make any difference, because it looks like any attempt to set the name of a built-in style, or set a style's name to the name of a built-in style, will eventually throw an exception without changing the document model. Change-Id: If11fba2797e28b10c98c383c5d130f19ce0c77b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178209 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
13 daystdf#150839 a11y added page layout view under View OptionAdesola Samuel1-0/+4
An option "Layout of pages" is added to the view option which allows user to select any of the three page layout: 1) Single Page per Row 2) Multiple Pages per Row 3) Book View view for ease of accessibility. Change-Id: I8dcab9b78deee15fb68cf313dab6eff40025f5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176367 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
13 daysfix bug in use of SwStyleNameMapper::GetUINameNoel Grandin1-0/+8
introduced in ca435be45f316120b9df6c9d547b781ed975817d "writer: handle styles in multiple languages for online" and sprinkle some [[nodiscard]] around to prevent future such issues Change-Id: Ie12a7966a4de93c9ad05fef01fd2ff606f9dde6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178087 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
14 daystdf#159549 sw: fix style name in SwXStyle::getParentStyle()Michael Stahl1-1/+1
For a style that isn't inserted yet, the m_sParentStyleName is converted to UIName by setParentStyle() but isn't converted back to ProgName in getParentStyle(). This caused all of the writerfilter test failures in commit c166d112381f195a171425d1f9c1d38ce579319a. Change-Id: Ib5495785996807a8f3d9339ed2740f286b04d716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177998 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
14 daysmake conversion operator explicitNoel Grandin1-1/+1
so less invisible behaviour Change-Id: I497763cb4be554ddbd00831458f162d9d975742e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178115 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-06tdf#159549 sw: fix ODF import of newly colliding Body Text stylesMichael Stahl1-1/+1
Commit c83d241effbd09491e9f96d3e435ab91700f58b0 "tdf#154933 Rename "Text Body" para style to "Body Text"" introduced a regression when importing certain ODF documents, but the problem is actually pre-existing. What happens is that first the built-in "Text body" style is created, and then a non-built-in style with the same translated name as "Text body" is imported, and instead of creating a new style, the built-in one is found and used, and so its properties are overwritten. The root cause is that SwStyleNameMapper::FillProgName() and in particular SwStyleNameMapper::FillUIName() are defined poorly, ever since they were introduced in 2001 in commit 4fbc9dd48b7cebb304010e7337b1bbc3936c7923 It becomes obvious relatively quickly that the way style names work is that at the UNO API level, the "ProgName" (internal, non-localised) names are used, and at the core document level, the "UIName" (localised) names are used. This is in itself questionable - why is the translation from ProgName to UIName not done in the UI? - but also very expensive to change now. So then the UNO services are responsible for translating between ProgName and UIName. But the 2 functions don't do that properly; both need to check if the given name is a known ProgName *or* a known UIName, and rename it in case it collides with a known target name; also the 2 functions need to cancel each other out, not add " (user)" at the end in both directions. Fixing this causes numerous tests to fail, due to: 1. the UNO services calling themselves with already converted style names, which are then translated a second time, which fails now. (or calling the wrong function like SwXStyleFamily::getByIndex()) 2. many tests call the UNO API with UINames instead of ProgNames 3. somehow the writerfilter import is also changed, causing failures in e.g. testTdf113182 and testTdf104492 4. buggy code elsewhere (lcl_getUsedPageStyles()), problem similar to 1., for PageDescs 5. potentially more buggy code yet to be discovered (definitely table styles, forgot which test that was) So limit this fix for now to only paragraph styles, and don't do it in writerfilter import, now at least sw.check passes. Change-Id: I5cbdf3e174622e83f9af8787c3671b88c0e37bac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177858 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-12-04split up SwGetRefFieldType::FindAnchor method some moreNoel Grandin1-0/+9
To make it easier to see the modifications I want to do to improve performance here. Change-Id: Icbb663b39905ce0fe82544bac7afd21314d4c7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177801 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04split up SwGetRefFieldType::FindAnchor methodNoel Grandin1-0/+7
to make it easier to read Change-Id: Ifaece90d4fb18be3caae9fd4afbbbdf64ff9d18a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177800 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-12-04tdf#143148: Use pragma once instead of include guardsJohann Lorber1-4/+1
Change-Id: Iac334c822ab0699b5cc5122e5f2b1a2b9662f58e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177784 Reviewed-by: Skyler Grey <skyler.grey@collabora.com> Tested-by: Jenkins
2024-12-03tdf#48459 sw inline heading: don't apply inside frames or over 120 charsLászló Németh1-1/+1
Don't apply inline heading 1) in a text frame 2) or if the selected text is over 120 characters. 1) It would be enough to limit this for inline heading frames, but the recent FN_INSERT_FRAME – which is used for creating the Inline Heading frame, cannot handle the insertion inside a frame: the new frame is anchored outside of the frame, not inside the actual paragraph, resulting bad layout. 2) Increase also the limit of applying the inline heading to 120 characters (very upper limit for a long line) from 75. Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880 "tdf#48459 sw inline heading: apply it on the selected words", Change-Id: I05de4be3a08926fdabad2e601d4bbe57ae25f7c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177739 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2024-12-03tdf#164090: a11y sw: add new warning for non numbered empty paragraphBalazs Varga1-0/+1
Add new warning for empty paragraph between numbering paragraphs. Change-Id: Ib85b376da77a72a87ab05a3e8271be43e223f129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177493 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-11-29tdf#146553 Enable additonal functions in editable section while in r/o modeOliver Specht1-1/+1
Insert/Edit table, insert lists, insert AutoText automatic spell checking Change-Id: Iccef3965316dc6079ea56a0283023c5a658512cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165031 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-28tdf#163913 Implement font-relative marginsJonathan Clark1-0/+2
This change adds loext:margin-left and loext:margin-right, which implement margins that support font-relative units. See tdf#36709 for additional details. Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-28tdf#164074 sw inline heading: add up/down outline movingLászló Németh5-5/+28
Move inline headings with their outline tree in Navigator, clicking on the Move Heading Up/Down icons. Instead of changing CompareSwOutlineNodes, which breaks the code at other places, add a new SwOutlineNodesInline and CompareSwOutlineNodesInline to sort inline headings (put in Inline Heading frames) with normal headings only for MoveOutlinePara and other part of Navigator's outline moving. Reordering chapters and sections using the Navigator was limited for normal (root) headings, but not for headings in text frames and tables. Recent implementation of inline headings use text frames with Inline Heading frame style, anchored as characters to their paragraphs. Now these inline headings are movable with the Navigator, with their outline tree, i.e. the paragraph where the inline heading anchored as character, the following paragraphs without inline heading, or the following subsections. Note: selecting the inline headings is possible by the Navigator content tree or or by clicking inside the text of the inline heading in the document. Note: according to the fix for tdf#143569, multiple headings in the same text frame or table are ordered alphabetically in the Navigator. This doesn't effect the inline headings, where there is only a single heading in an Inline Heading text frame. Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880 "tdf#48459 sw inline heading: apply it on the selected words", commit d87cf67f8f3346a1e380383917a3a4552fd9248e "tdf#131728 sw inline heading: fix missing/broken DOCX export" and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8 "tdf48459 sw inline heading: add Inline Heading frame style". Change-Id: I7618aa1d4e1ddc20512d81c9a2babfa660053cbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177438 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-11-26tdf#86731 bNoDictionaryAvailable should trigger meesageboxSzymon Kłos1-0/+1
Reverts "PVS: V547 Expression 'bNoDictionaryAvailable' is always false" This reverts commit 816b51c7a9cdd72eaa01f3c074ba5a8446917d19. It removed the message completely from the code while, we should fix it rather by using correct condition. It was somehow too aggresively limited in commit f200dd5cb84681558700c49de0969907f78f8db1 tdf#86731 Don't show 'start from beginning' when dictionary is missing Change-Id: I5f4b859047216399a09c7aefb8a47244c4833df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177271 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-11-24Turn SW_MOD macro to a functionMike Kaganski1-3/+4
Change-Id: Ide1f6fd2fc8a80b31353a14e416505a2349cea2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23GetAttrOutlineContentVisible may be constMike Kaganski1-1/+1
Change-Id: If94b948ddcc2fac9bce254947b78afc1c6f0383e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177078 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-22sw: no need to pass a bool as a referenceXisco Fauli1-2/+1
Change-Id: I62aabd66d368856959be032d866888b82b018dd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177018 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-22tdf#163486: PVS V1043 global object variable is declared in header (sw)Julien Nabet2-221/+222
Change-Id: I7d8375e822dabcceeaf25eaf4ba1f29ce7494337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176996 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22PVS: V547 Expression 'bNoDictionaryAvailable' is always falseXisco Fauli1-1/+0
Since commit a50a2bf8e8c6084aeacb8d2db42e21f528410742 Author: Szymon Kłos <szymon.klos@collabora.com> Date: Thu Jan 24 11:22:22 2019 +0100 tdf#86731 Don't show 'start from beginning' when dictionary is missing Change-Id: Ib71051ddbb3318c74fb5020ec27560f1c6f73893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177017 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-20Resolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze2-19/+32
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2024-11-19improve loplugin passparamsbyrefNoel Grandin5-5/+5
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-19tdf#163340 pasting paragraphs with lists changed againOliver Specht1-0/+1
Pasting paragraph with a list into an empty or completely selected paragraph with lists has been changed: If the pasted paragraph(s) are all formatted with a list from the paragraph style then this list will be preferred. If some the pasted paragraphs including the first one are formatted with a hard list then these attributes will be preferred. If all paragraphs have a hard list or no list at all the list at the target position will be preferred. Change-Id: I5aa6834d32f7c69b2eb9f8330b282c0ae6fca559 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176478 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-11-17tdf#143148 Use pragma once instead of include guardsSloane Vaznova21-85/+21
Refactored include guards into pragma once for some files alphabetically c-d in sw/inc. Change-Id: I8cf8059851169472d7953f4e6f5408666d27c2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176688 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-16cid#1606752 silence Overflowed return valueCaolán McNamara1-20/+9
and cid#1607158 Overflowed return value cid#1607271 Overflowed return value cid#1608107 Overflowed return value cid#1606975 Overflowed return value cid#1608009 Overflowed return value cid#1608353 Overflowed return value cid#1608486 Overflowed return value cid#1607009 Overflowed return value cid#1606780 Overflowed return value its totally unclear what the source of these warnings is Change-Id: If46cac6a329dec397bd784f57d9ffe5e53af9a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176683 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-14Improve loplugin:dyncastvisibility to check for non-inline key functionsStephan Bergmann1-0/+2
This would have caught the issue discussed in 709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique RTTI". (The commit message talks about RTTI there, while what Clang actually compared for an optimized implementation of a dynamic_cast to a final class is vtable pointers, but the overall picture remains the same. Both RTTI and vtables are emitted along the key function, and if that is missing or inline, they are emitted for each dynamic library individually, and as internal symbols on macOS.) This commit also addresses all the issues found by the improved loplugin:dyncastvisibility on Linux. See the newly added TODO in compilerplugins/clang/dyncastvisibility.cxx and 86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function" for an issue with key functions for class template instantiations. Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-13tdf#48459 sw inline heading: fix bad NC of the new frame styleLászló Németh1-1/+1
Which affected translation etc. Introduced by commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8 "tdf#48459 sw inline heading: add Inline Heading frame style". Reported by Olivier Hallot with code pointer. Change-Id: I7fc4cfa685be4374993754a303b4d54df7d1ee37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176210 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2024-11-13tdf#36709 sw: Writer layout for font-relative first-line indentJonathan Clark1-3/+9
This change implements layout for font-relative paragraph first-line indentation in Writer. Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-12tdf#89352 Allow user to change all Footnotes to Endnotes and vice versaJim Raykowski2-0/+5
through use of context menu entries in the Writer Navigator Footnotes and Endnotes content types Change-Id: I2c7b6d01013023702f9272e222b76a83710ca6f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176495 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-11-12sw: use SAL_RET_MAYBENULL in GetDocShell()Xisco Fauli1-2/+2
similar to commit c796878e6af0fc7c886e813a0010d9402312eb5c Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Mon Oct 21 15:56:25 2024 +0200 tdf#163543: check GetDocShell() Change-Id: I4b489c59b7596466aea6b5c7b78248d82f193a0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175628 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-11tdf#144717: fix SwInsFootNoteDlg's next/prev button state checkMike Kaganski1-2/+2
Trying to move the current cursor, which may actually be a selection, to find next/prev footnore, may try to expand the selection across a table boundary (from outside to inside), which would fail. This was incorrectly treated as "there's no next/prev footnote, the cursor is unchanged" case, and the cursor wasn't restored. Use a separate local cursor object for testing; and make it at least somewhat useful, to detect the case when there's no more footnotes in the document, so the prev/next buttons would get disabled. Change-Id: I7db100dfdd290fe01b3eebe17f1dec2784315243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-11tdf#143148 use pragma once instead of include guardsHarris Popal1-4/+1
Change-Id: I7b082c51a7092e18bdbf5a1fbab3fa4e5a97a28a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176039 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-08Related tdf#74386 - Improvements for text boundaries optionsHeiko Tietze1-1/+1
* Default is Crop Marks now * Settings are persistent Change-Id: If5304c874706345fa943a106044155152c86bc0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176131 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-07loplugin:passstuffbyref in swNoel Grandin5-8/+8
Change-Id: I22f4f4a0f2729b953669322eda803ce298eea236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-07sw: add .uno:DeleteContentControl commandcodewithvk1-0/+1
This command removes formatting for content controls such as rich text, checkbox, dropdown, picture, and date controls. It deletes only the content control formatting, not the actual content of the section. Here are some todos: - Add test case for delete - undo/redo for this uno command Change-Id: Ib1b3b62ff7d62fd971472eff49a58c5afd786dc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175927 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 5d4ae3db293b0f9c46cbc09d0391806e1ed7b362) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176067 Tested-by: Jenkins Reviewed-by: vivek javiya <vivek.javiya@collabora.com>
2024-11-04tdf#143148 use pragma once instead of include guardsRosh1-4/+1
Change-Id: I44df7baf1d5bfdd45647c5b2ed99958d587ff61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176002 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-02tdf#143148 use pragma once instead of include guardsLeSci-0x11-4/+1
Change-Id: I8ace16d16c900b6cec8fa454250dcdb1698c0677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175890 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-02tdf#36709 Add loext:text-indent supporting font-relative unitsJonathan Clark1-0/+1
This change adds an ODF font-relative first-line indent paragraph style attribute as a LibreOffice extension. The corresponding ODF standard change is tracked by OFFICE-4165. This change only implements what is minimally necessary to serialize, deserialize, and check for ODF files containing this attribute. Further changes are necessary. * Added cssLength to schema, which is equivalent to length but also allows ic and em as units. * Added loext:text-indent to schema as a paragraph style attribute. This attribute is equivalent to fo:text-indent, but accepts cssLength instead of length. * Added XML_TYPE_UNIT_MEASURE to the ODF parser, which currently accepts only the font-relative measures and forces fallback in other cases. * Added loext:text-indent to the ODF parser. This attribute accepts font-relative metrics, and will behave as an import-only alias for fo:text-indent in other cases. * Updated SvxFirstLineIndentItem to handle unit-denominated measures. * Added proof-of-concept indentation handler to Writer. This implementation is incomplete and temporary, and will be revised in future changes. Change-Id: I7eb5c7382093cb18a9b0afbf93dacb34ba1d35ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175941 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-01tdf#48459 sw inline heading: add Inline Heading frame styleLászló Németh2-0/+2
Add the new frame style Inline Heading with default variable width and anchoring as character to support UX better – and later, – interoperability. Note: the previous commit (7a35f3dc7419d833b8f47069c4df63e900ccb880) used the Formula style for inline headings. Note: adjust check_styles.py unit test according to the extended frame style list. Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880 "tdf#48459 sw inline heading: apply it on the selected words". Change-Id: I615a53803d755acfbabb77fe53b0e5b60fa9fcc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175834 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2024-10-31tdf#153138 Add IgnoreTabsAndBlanksForLineCalculation compat opt to dialogAdesola Samuel2-0/+3
IgnoreTabsAndBlanksForLineCalculation was added to the option-> writer->compatibility options with the label "Make whitespace character height not affect line height" Change-Id: I8b99409b01ba2af635018d15cde2e549dff92732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-30Resolves tdf#74386 - Make Text Boundaries independent from non-printable charsHeiko Tietze1-1/+7
New option introduced under Formatting Aids to switch between full and crop marks, which was done before via NPC Change-Id: I920f68b571da740e47ae367ba1e8d28e03a131e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175828 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-26tdf#48459 sw inline heading: apply it on the selected wordsLászló Németh2-0/+6
Selected text at the beginning of a paragraph (<= 75 characters) become text frame based inline heading at applying a paragraph style (using Formatting toolbar, context menu, Ctrl-1...Ctrl-5 or Styles sidebar panel). If the whole paragraph is selected, or if no or multiple paragraphs are selected, formatting is still applied on the whole paragraphs. Using text frames for inline heading is ODF 1.0 compliant and fully back-compatible with the older Writer versions. The new inline heading frame contains direct formatting to zero the upper and bottom paragraph margin to solve interoperability issues: in MSO, margins of heading styles are zeroed by using the style separators. Note: lack of inline heading was a showstopper for creating APA-, IEEE-, MIL-STD-961E-format, legal etc. documents. Note: recent Formula frame style will be replaced by the planned Inline Heading, which will be used by the DOCX filter to export OOXML style separators instead of text frames. Change-Id: I6722dcaef046bdbca2fe044d175806fa8c65278c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175580 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-23 05:16:38 +0000