summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
66 min.CppunitTest_sc_tiledrendering: factor out common codeHEADmasterXisco Fauli3-594/+469
Change-Id: If9f3ff5d9699876290fb643ed14ba64108cd191c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176877 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
66 min.CppunitTest_sc_tiledrendering2: move to tiledrendering folderXisco Fauli4-2/+2
In preparation for a follow-up commit Change-Id: I8e7852b1861d6879e0dcda8c6fddd947bec3c959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176876 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
102 min.tdf#163486: PVS: variable is assigned values twice successivelyXisco Fauli2-5/+4
Since commit d0cacf09a1105d89bf3df84b18623d790e3aeb82 Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Date: Wed Apr 27 11:45:04 2022 +0200 tdf#99708 Save formula bar height to document V519 The 'pSettings[14].Name' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 3806, 3816. Change-Id: I7afcee42d10d692c2c9a84b6a6f0a97ceb913081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176761 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2 hoursremove OutDevSupportType::TransparentRectNoel Grandin10-82/+7
all our backends support transparency, and have some time, XRender support became mandatory a couple of years ago. Change-Id: Ie2db7e4665068fe88a926e9791d74a82c2e75834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2 hoursMissing test dependenciesStephan Bergmann1-0/+9
Change-Id: I554ca1edd014f91433a948302762bcd7a3ed64bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176870 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
3 hoursUpdate git submodulesMartin Srebotnjak1-0/+0
* Update translations from branch 'master' to 8f5f1e8348d605be128fcfa742e6fb92d52e758f - Updated Slovenian translation Change-Id: I5502cef3a456758e12170ad6d95a39b152cf63f1
7 hoursUpdate git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 4eb5edf36d5bfa7f1dc90c09623086ade07b97b5 - ghost ref to OO.o Change-Id: I92d95d09dea69f9482a9a49ed6a380da017ce749 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176820 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
8 hourstdf#163872 ScTable::SetOptimalHeight: optimize if all rows ManualSizeJustin Luth1-0/+18
SetOptimalHeightsToRows does nothing if all the rows are manualsize. GetOptimalHeightsInColumn can be extremely expensive to run, so exit early if all the processing will have been for nothing. This doesn't solve bug 163872, but it does help with some of the sheets. Change-Id: I425bbd4f181058aa637c92f2abccf7c27dcf607d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Justin Luth <jluth@mail.com>
12 hoursFix typoAndrea Gelmini1-1/+1
Change-Id: I8c8e5c3e6c4e0a8a7f41943ac8c014e1175e093a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176871 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
12 hoursFix typoAndrea Gelmini1-1/+1
Change-Id: I4520061338adfcb13d2eece2f59fb8331c7dbf8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176874 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
12 hoursFix typoAndrea Gelmini1-1/+1
Change-Id: If765fa2c6e7df36dd5d62b351898b61ac263a6e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176872 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
13 hourstdf#163967 RTF: Pasting/loading hyperlink imports font color and underlineOliver Specht1-1/+33
Hyperlinks are typically colored and underlined. The RTF import - also used when pasting from clipbard - now evaluates font color and underline in the field result. Change-Id: I725fc3e94746c96d68379c021fb0c12cd3750096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176714 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
14 hoursgtk3 a11y: Use OString literalsMichael Weghorn1-15/+15
Change-Id: I23365943e79847e3c7162808de3dc176f7db2b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176804 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
14 hoursCppunitTest_sw_tiledrendering: factor out common codeXisco Fauli3-625/+526
Change-Id: Icc8958f9f86844149bc66d12d60111bdcac0f8ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176867 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
14 hoursCppunitTest_sw_tiledrendering2: move to tiledrendering folderXisco Fauli5-2/+2
In preparation for a follow-up commit Change-Id: Id790d14ccbbb17f4ca086c67a702e199397d272b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176864 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
14 hoursstarmath: Use field color for SmEditTextWindow backgroundIlmari Lauhakangas1-2/+1
With same reasoning as commit 8bb38e1b3f1ba1d9c563598d161230fdf27e4685 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Oct 14 12:22:32 2024 +0200 tdf#163397 svx: Use field color for WeldEditView bg Change-Id: Iac0c6b934946b6755ce53ac312c1e637678f966d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176856 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
15 hourstdf#91315 Implemented RTL support for SVG exportJonathan Clark3-0/+454
Previously, the direction attribute was not set on text tags when exporting RTL text to SVG. This change adds the missing attribute. Change-Id: I57770c1cc44f10c3c43ccac2f5a17c1422c34d35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176869 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
17 hoursCatch exceptions thrown when notifying individual listenersStephan Bergmann2-2/+99
Any such exceptions were already caught further up the stack (by SfxBaseModel::postEvent_Impl), but prevented later listeners from being notified as soon as one listener threw an exception (which I saw happen with some 3rd-party extension). Change-Id: Ia6bd1c73d29ab6d6e131652df51939ba0c0e988e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176854 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
17 hoursCppunitTest_sw_htmlexport: split in twoXisco Fauli5-1812/+1926
It already had 114 tests Change-Id: I16bddb42364c542fb2b5e115672096984b29e975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176847 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
18 hoursResolves tdf#163856 - Disentangle boundaries optionsHeiko Tietze41-644/+505
* Boundary toggles removed from app colors * Object boundaries completely removed (color replaced with DOCBOUNDARIES; Impress placeholder on/off now an expert option) * Toggle options added under formatting aids * Individual UNO commands marked deprecated * New command added to show all boundaries * Frames follow sections now in state and color * Kind of wrapping doesn't matter anmymore Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
18 hourstdf#163428 CairoSDPR: Fix regression in freeing unified buffersArmin Le Grand (Collabora)1-16/+60
I had added BufferedData_ModifiedBitmapEx for CairoSDPR (but not only) to allow Bitmaps modualted by BColorModifierStack to be buffered in the standard way and at the original Bitmap. This nicely can still hold the system-dependent form of the Bitmap to be used at the Bitmap of that buffered modified Bitmap. This uses something I was not aware of: One Buffer implementation may - as in this case - use another buffer. That may lead to the second buffer being deleted/freed when the first one gets freed - by timer or directly - what is wanted. This *needs* the methods inside SystemDependentDataBuffer to do the actual potential destruction of the Object outside the Mutex-Locked parts of the code, else this might lead to a deadlock. It is good to have found this, there may be other such combinations in the future: That the implementation of a buffer using that standard mechanism uses another class that may also be buffered. I have now made sure that buffered objects get deleted *outside* the Mutex-Locked areas. This is better anyways, the destruction does not need that lock - it is just needed so secure the manipulation of the local unordered_map that organizes the buffered elements globally. Change-Id: Ie2f346a3f1a24105b89310ace3ff7a41472143c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176795 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>
18 hoursWARN about swallowed exceptionsStephan Bergmann1-0/+1
Change-Id: I2d6aef0dfa8bd8c002fd172b13363e629bc9cc3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
18 hoursUse notifyEachStephan Bergmann1-12/+4
...as had already been done prior to 8122c82d90117fc0c4c8ea87aa7f771d5e92bf36 "osl::Mutex->std::mutex in SfxGlobalEvents_Impl" Change-Id: Ia74c07a3458d7a5af428b68d1728cc9e51aa42a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176853 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
20 hourstdf#163486: PVS: Identical branchesBogdan Buzea1-5/+5
V1037 Two or more case-branches perform the same actions. Check lines: 1209, 1218 Change-Id: I9f2fe51a0b7d4514ff6a82d24be940ed50d39e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175221 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
21 hourstdf#163486: PVS: Identical branchesBogdan Buzea1-8/+4
Change-Id: Ibd3f95a7af4df51aee5fd1974914aa808dded229 V1037: Two or more case-branches perform the same actions. Check lines: 666, 688. Similar cases are grouped closer. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175051 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
21 hoursgtk: Switch param from const char* to const OString&Michael Weghorn2-7/+7
Change-Id: Ie92591770a2828a5f828d76d8c1bf7e5a253c3de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176814 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
21 hoursgtk: Let GetCommandForItem return OString instead of char*Michael Weghorn1-27/+19
This simplifies memory management, as it removes the need to manually free the memory using `g_free` again. Change-Id: I71f8e6a8df46c0090f2f003d3f443500028b1f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176813 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
21 hoursuse bNewFontLists of true to refetch new font listsCaolán McNamara1-2/+2
which becomes more obviously required since: commit d85cb3832286ae1fdcf4a8494abb8212f21e4e9a CommitDate: Fri Feb 2 22:47:28 2024 +0100 preload: open and close empty documents of main types in preinit. because since then SdModule has called GetVirtualRefDevice to create the long-life virtual device that is used to set the lists of available fonts before "addfonts" has been called to add extra fonts to the kit so impress/draw remains unaware of any changes there. It was actually "true" here before: commit ab612633003c75dfb30664db8cc8924c086a91ee CommitDate: Wed Apr 13 20:09:54 2022 +0200 Follow-up fix to Collabora Online "addfont" handling: avoid assertion failure but its uncertain what assertion is referred to here, perhaps the same assertion as later fixed by: commit d1ed24ba34d422128fd48184dbc3b344b5922d3a CommitDate: Wed Oct 2 16:19:47 2024 +0200 Get SolarMutex before calling ImplClearAllFontData Change-Id: Ibc81191ba3b88d9b4def90b6d9662a83295ec9cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176032 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176823 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
22 hourssc: autofill: send to-be-deleted cell addressesBayram Çiçek1-3/+22
with LOK_CALLBACK_TOOLTIP also avoid nullptr ViewShells: - if (comphelper::LibreOfficeKit::isActive()) + if (ScTabViewShell* pLOKViewShell + = comphelper::LibreOfficeKit::isActive() ? aViewData.GetViewShell() : nullptr) Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I38578297cc1aadefe8c43033cdb14b9460e22c90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175827 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 459a9401f342210d7f6ab8fe6fa780ae28413ef6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176825 Tested-by: Jenkins
22 hoursswitching PageKind without switching EditMode retains current pageCaolán McNamara3-0/+20
i.e. ChangeEditMode doesn't do anything if the EditMode is unchanged but the PageKind was switched from Notes to Standard. So the same page of the other mode is still selected. An explicit SwitchPage is required to change the page from the other mode. This results in the reported mode of "2", but rendering actually still rendering as if in "mode 0", so a request to render a 'standard' page returns an image of the currently still-selected 'notes' page, which confusingly can be cached and not shown until served as a reply to a later request of the 'standard' page. See DrawViewShell::ReadFrameViewData and other places for more of this pattern. Change-Id: Ie8aa8f93f45189fd6f9c37c4077fa2b547ca4815 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176084 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 95e9c210ef8380b0909c6ba596e3023bafef4083) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176824 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
23 hourscool#7406: Refactor Calc->getPartInfo & use JsonWriter.Gökay Şatır1-10/+19
Indeed this seems unrelated to the task. But grid in Impress requires to add new properties to "getPartInfo (impress)". When i checked the code, i saw that we use getPartInfo's result (on server side) like it's a text instead of JSON. So we'll refactor that part. Touching that part requires also touching some other shared functions on COOL side. And those changes also required adding new props here. We have been fetching this data (without adding new properties) one by one. We now will be able to fetch the whole part's data at once. This commit also uses JsonWriter class. Change-Id: Icc26ae71c668c391218e2d517259e1ef32a0832f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176815 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
23 hoursupdate language-subtag-registry to 2024-11-19Xisco Fauli1-2/+2
How the file was created: mkdir data cd data wget https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry cd .. tar cvjf language-subtag-registry-2024-11-19.tar.bz2 data/language-subtag-registry Change-Id: I1ae31648771642592f8ce5c201ded8fd84eef8c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176821 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
23 hoursUpdate git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to aa2f1c2c7172ad20c607734c8c11057ee717599a - New arguments in ScriptForge.Exception.PythonShell() method Change-Id: Iceb8b2480055e912eb712ff1eb7d842be440f6ba Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176712 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
24 hoursCppunitTest_sw_tiledrendering2: try to make this more stableMiklos Vajna1-0/+5
This fails from time to time, see <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/177770/console> for a case. When it fails, we get no status callback at all, while the interesting failure is when we get a status callback, but it's wrong. Just give up in the rare case when we get no status callback to avoid false alarms for now. Change-Id: I8f971b64db878d207f9fd2e4fffc4d4b9a4a14e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176818 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
24 hoursdesktop: fix crash in forceSetClipboardForCurrentView()Miklos Vajna1-0/+4
Crashreport signature: > Fatal signal received: SIGSEGV code: 1 for address: 0x0 > program/libmergedlo.so > (anonymous namespace)::forceSetClipboardForCurrentView(_LibreOfficeKitDocument*) > desktop/source/lib/init.cxx:1376 (discriminator 6) > program/libmergedlo.so > rtl::Reference<LOKClipboard>::~Reference() > include/rtl/ref.hxx:128 > program/libmergedlo.so > com::sun::star::uno::Reference<com::sun::star::lang::XComponent>::~Reference() > include/com/sun/star/uno/Reference.hxx:113 Sounds like an attempted document load that failed, but we still try to set the clipboard for the first view during shutdown. Change-Id: I21e5742ae4fcd4b24daf2888f3d64aae437d4fda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176812 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
25 hoursuse TOOLS_WARN_EXCEPTION to get exception detailsCaolán McNamara1-2/+2
Change-Id: I68f45585878b323e44ce9ca2d660c72ebb7be174 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
27 hourstdf#155449 gtk3 a11y: Hold reference to the original AtkObjectMichael Weghorn1-0/+5
Let the AtkObjectWrapper hold a reference to the original AtkObject, and release it in `atk_object_wrapper_finalize`. Without this, the original AtkObject might get destroyed too early. Then trying to access it would result in a crash. While occasionally also seen elsewhere, this was somewhat more reliably reproducible when starting the Orca screen reader or a pyatspi event listener script while the spell check dialog in Writer was shown. Backtrace of how the AtkObject got destroyed (reverse-debugged with rr with a data breakpoint on the AtkObject's accessible description): 1 _int_free_create_chunk malloc.c 4738 0x7fe5766a858e 2 _int_free_merge_chunk malloc.c 4700 0x7fe5766a99b8 3 _int_free malloc.c 4646 0x7fe5766a9d31 4 __GI___libc_free malloc.c 3398 0x7fe5766ac4ff 5 atk_object_finalize atkobject.c 1399 0x7fe5626a7785 6 g_object_unref 0x7fe56e9b94ee 7 expiry_func accessible-leasing.c 122 0x7fe5624f32b1 8 ?? 0x7fe568f0f88e 9 ?? 0x7fe568f0c7df 10 ?? 0x7fe568f0ea17 11 g_main_context_iteration 0x7fe568f0f180 12 GtkSalData::Yield gtkdata.cxx 405 0x7fe5634766ec 13 GtkInstance::DoYield gtkinst.cxx 425 0x7fe56347b493 14 ImplYield svapp.cxx 385 0x7fe56db0e106 15 Application::Yield svapp.cxx 473 0x7fe56db0da9f 16 Application::Execute svapp.cxx 360 0x7fe56db0d880 17 desktop::Desktop::Main app.cxx 1679 0x7fe576926d8b 18 ImplSVMain svmain.cxx 228 0x7fe56db2e996 19 SVMain svmain.cxx 246 0x7fe56db30589 20 soffice_main sofficemain.cxx 121 0x7fe5769a08da 21 sal_main main.c 51 0x5644db935a6d 22 main main.c 49 0x5644db935a47 Backtrace of the crash when using the already deleted object later: 1 g_type_check_instance_cast 0x7fe56e9d9337 2 atk_object_get_index_in_parent atkobject.c 1007 0x7fe5626a5ae5 3 wrapper_get_index_in_parent atkwrapper.cxx 545 0x7fe56344a244 4 atk_object_get_index_in_parent atkobject.c 1011 0x7fe5626a5b3c 5 append_cache_item cache-adaptor.c 183 0x7fe562500591 6 append_accessible_hf cache-adaptor.c 246 0x7fe56250029b 7 g_hash_table_foreach 0x7fe568efacd3 8 spi_cache_foreach accessible-cache.c 423 0x7fe5624f33f9 9 impl_GetItems cache-adaptor.c 328 0x7fe562500174 10 handle_other droute.c 558 0x7fe56250f8a4 11 handle_message droute.c 605 0x7fe56250e7d6 12 ?? 0x7fe5764f5e64 13 dbus_connection_dispatch 0x7fe5764e58ab 14 message_queue_dispatch atspi-gmain.c 89 0x7fe5623abc52 15 ?? 0x7fe568f0c7df 16 ?? 0x7fe568f0ea17 17 g_main_context_iteration 0x7fe568f0f180 18 GtkSalData::Yield gtkdata.cxx 405 0x7fe5634766ec 19 GtkInstance::DoYield gtkinst.cxx 425 0x7fe56347b493 20 ImplYield svapp.cxx 385 0x7fe56db0e106 21 Application::Yield svapp.cxx 473 0x7fe56db0da9f 22 Application::Execute svapp.cxx 360 0x7fe56db0d880 23 desktop::Desktop::Main app.cxx 1679 0x7fe576926d8b 24 ImplSVMain svmain.cxx 228 0x7fe56db2e996 25 SVMain svmain.cxx 246 0x7fe56db30589 26 soffice_main sofficemain.cxx 121 0x7fe5769a08da 27 sal_main main.c 51 0x5644db935a6d 28 main main.c 49 0x5644db935a47 The deleted object is the `AtkObject *accessible` param passed to `atk_object_get_index_in_parent`. This is with at-spi2-core git main as of commit 422cac4bd657ce783164324e6ae4b3d54a8aa761. Change-Id: I23d8a3d55bd587aa99316d71524a18afcd6c0479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176787 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
27 hoursgtk3 a11y: Simplify gtk3/gtk4 version checkMichael Weghorn1-3/+1
One gtk3-specific section is sufficient. Change-Id: I42a5cd1b94df7874665743a386af8e2e19590b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176786 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
27 hoursuse default implementation for hasFastDrawTransformedBitmapNoel Grandin12-27/+4
so only the one that implements it needs to override it Change-Id: I1acffb4796d95d75edc4507f533d9b1f8987972b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176790 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
37 hourscatch invalid ranges at exportCaolán McNamara1-1/+15
log failure and continue to export the remainder of the document #0 0x0000733dda8ae4a1 in __cxa_throw () from target:/lib/x86_64-linux-gnu/libstdc++.so.6 #1 0x0000733dc5d0bd43 in ScCellRangeObj::getCellRangeByPosition (this=0x2a753d60, nLeft=43, nTop=-7, nRight=43, nBottom=-7) at sc/source/ui/unoobj/cellsuno.cxx:4638 #2 0x0000733dc66150d5 in ScTableSheetObj::getCellRangeByPosition (this=0x2a753d60, nLeft=43, nTop=-7, nRight=43, nBottom=-7) at sc/source/ui/unoobj/cellsuno.cxx:6711 #3 0x0000733dc62d3e38 in ScXMLExport::GetMerged (this=0x1fc74160, pCellAddress=<optimized out>, xTable=...) at sc/source/filter/xml/xmlexprt.cxx:2750 #4 0x0000733dc62d7104 in ScXMLExport::AddStyleFromCells (this=0x1fc74160, xProperties=..., xTable=..., nTable=0, pOldName=0x0) at sc/source/filter/xml/xmlexprt.cxx:2156 #5 0x0000733dc62dfebb in ScXMLExport::collectAutoStyles (this=<optimized out>) at sc/source/filter/xml/xmlexprt.cxx:2559 #6 0x0000733dc62d0fff in ScXMLExport::ExportAutoStyles_ (this=0x1fc74160) at sc/source/filter/xml/xmlexprt.cxx:2657 #7 0x0000733dd833a7a4 in SvXMLExport::ImplExportAutoStyles (this=0x1fc74160) at xmloff/source/core/xmlexp.cxx:1123 #8 0x0000733dd833d098 in SvXMLExport::exportDoc (this=0x1fc74160, eClass=<optimized out>) at xmloff/source/core/xmlexp.cxx:1389 #9 0x0000733dd83386f6 in SvXMLExport::filter (this=this@entry=0x1fc74160, aDescriptor=...) at xmloff/source/core/xmlexp.cxx:815 #10 0x0000733dc62e6452 in ScXMLExport::filter (this=0x1fc74160, aDescriptor=...) at sc/source/filter/xml/xmlexprt.cxx:5472 #11 0x0000733dc63204a0 in ScXMLImportWrapper::ExportToComponent (this=0x7ffc11959890, xContext=..., xModel=..., xWriter=..., aDescriptor=..., sName=..., sMediaType=..., sComponentName=..., aArgs=..., pSharedData=...) at sc/source/filter/xml/xmlwrap.cxx:707 #12 0x0000733dc632679a in ScXMLImportWrapper::Export (this=this@entry=0x7ffc11959890, bStylesOnly=bStylesOnly@entry=false) at sc/source/filter/xml/xmlwrap.cxx:943 #13 0x0000733dc6465d5e in ScDocShell::SaveXML (this=0x11d1c440, pSaveMedium=0x138252f0, xStor=...) at sc/source/ui/docshell/docsh.cxx:653 #14 0x0000733dc646a519 in ScDocShell::SaveAs (this=0x11d1c440, rMedium=...) at sc/source/ui/docshell/docsh.cxx:1913 #15 0x0000733dd6ae7432 in SfxObjectShell::SaveAsOwnFormat (this=0x11d1c440, rMedium=...) at sfx2/source/doc/objstor.cxx:3378 #16 0x0000733dd6af0ae6 in SfxObjectShell::SaveTo_Impl (this=0x11d1c440, rMedium=..., pSet=0x7ffc11959fe0) at sfx2/source/doc/objstor.cxx:1520 #17 0x0000733dd6af2f08 in SfxObjectShell::DoSave_Impl (this=0x11d1c440, pArgs=0x7ffc11959fe0) at sfx2/source/doc/objstor.cxx:2760 #18 0x0000733dd6b2b3aa in SfxBaseModel::storeSelf (this=0x5348c30, aSeqArgs=...) at /opt/rh/devtoolset-12/root/usr/include/c++/12/optional:306 #19 0x0000733dd6ab2671 in SfxStoringHelper::GUIStoreModel (this=this@entry=0x2ba275b0, xModel=..., aSlotName=..., aArgsSequence=..., bPreselectPassword=bPreselectPassword@entry=false, nDocumentSignatureState=SignatureState::NOSIGNATURES, bIsAsync=false) perhaps some relation to https://gerrit.libreoffice.org/c/core/+/160363 which is a somewhat similar situation Change-Id: I6b28ef0e9df0f44641fa5c582b5827dbcfb4af8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176765 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176792 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
37 hourstdf#163486: PVS: variable is used after it was movedXisco Fauli1-1/+2
Since commit 9fe2ead3d5355224dd94d6462b0ddc6100f6d4e3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Oct 8 06:43:18 2021 +0200 loplugin:moveparam in svx V1030 The 'aSdrObjects' variable is used after it was moved. Change-Id: I9b426204ff2e2e2d0f6b375e201259765aa12736 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
37 hourssfx2: unused returnsXisco Fauli2-10/+5
Change-Id: I0ab14e51d10cf67c956624710d1f82c69662e586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176784 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
38 hoursconsider VndSunStarExpand an exotic protocolCaolán McNamara11-18/+49
and generally don't bother with it when fetching data from urls Change-Id: I51a2601c6fb7d6c32f9e2d1286ee0d3b05b370b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176645 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
39 hoursUpdate git submodulesDione Maddern1-0/+0
* Update helpcontent2 from branch 'master' to e9c7414e4fd17c6f2ffbe6208db2c741fe33e803 - tdf#162504 Create help page for Number Format pane Create new page source/text/scalc/sidebar_number_format.xhp to describe the features of the Number Format pane in the Properties sidebar deck. In AllLangHelp_scalc.mk - Add new file source/text/scalc/sidebar_number_format.xhp to repository. In source/text/scalc/01/default_number_formats.xhp - Add variable and section tags so that content can be easily linked and embedded in other pages. - Remove old comments In source/text/shared/01/05020300.xhp - Add variable and section tags so that content can be easily linked and embedded in other pages. - Remove old comments In /home/dione/libreoffice/helpcontent2/source/text/shared/01/sidebar_properties.xhp THIS PAGE IS A WIP AND WILL NOT BE LINKED IN HELP UNTIL IT IS FINISHED - Embed description of the help page for Number Formats - Added index bookmarks (Currently commented out) - Updated application switches to hide the desription of the Paragraph pane for CALC and BASE. Change-Id: I7e1849ddc41cad7fd5d4b6c57e8a03186eb6575f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176720 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
40 hourstdf#160084 Simplify comparison for basegfx::fToolsBogdan Buzea1-1/+1
Change-Id: I6ae56ad61ceec5bc34898befd636a0ceae8266e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176700 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
40 hourssw: unused returnXisco Fauli1-4/+2
Change-Id: I18a5665609b3e15a98bb88e6d307e9f18be967e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176778 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
40 hourssvx: unused returnXisco Fauli3-6/+2
Change-Id: If747870121e3fc8c2d97b5fc769b2d928a4c3f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176777 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
42 hoursSimplify SalGraphicsImpl::InitNoel Grandin20-37/+7
it is only used for one thing, so rename it, and use a default implementation to avoid having empty implementations everywhere Change-Id: Ib650bb520ccbfcc27537b754db4d3de4ad10e638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
42 hoursloplugin:passparamsbyrefStephan Bergmann2-7/+8
Change-Id: I9ad592670399f25eeaea375bf71e6d30ee20118f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176763 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
42 hourscanvas: simplify calcTransformedRectBoundsXisco Fauli14-62/+27
Change-Id: Ia0314a985ae2183727587ad254faec12ee49b66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176769 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-21 09:30:00 +0000