summaryrefslogtreecommitdiff
path: root/sd/inc
AgeCommit message (Collapse)AuthorFilesLines
6 daysloplugin:constparam in variousNoel Grandin1-1/+1
Change-Id: I874a95777aed3471675bf03acfcf05ecfcb4f830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183531 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
10 daystdf#45617 Refactor the member function SdDrawDocument::InsertBookmarkAsPageMohamed Ali1-51/+433
Break down the monolithic InsertBookmarkAsPage function into smaller, more specialized methods with clearer responsibilities: - Extract separate methods for inserting all/selected pages - Create specialized variants for different insertion scenarios (paste, file insert, drag-drop, page links, internal document operations, document import) - Introduce parameter structures to better organize function arguments - Add dedicated methods for style transfer and master page management - Improve code organization with clearer function boundaries - Enhance maintainability through smaller, focused functions Change-Id: If2b8bda0c2e88f25478d534af3f8fa0394017dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179832 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2025-03-06Revert "tdf#165504 restore SdrPage::GetLayoutName virtual"Xisco Fauli1-1/+1
This reverts commit 5137fcc47f8e40dcba991db1f57dc1b395bbf970. The commit I bisected in https://bugs.documentfoundation.org/show_bug.cgi?id=165504#c3 was actually the same as tdf#164463 which got fixed in 960db01dbfe2f916b91782da03532fae1f836445 "Resolves: tdf#164463 we need to pass a copy of the LayoutName" So this revert is not necessary. I'm really sorry for all the inconveniences caused. Change-Id: Ice96b06220decf8078658b61ca721638cc8d2254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182578 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-03-06use more concrete UNO classes in sdNoel Grandin1-0/+161
Change-Id: I8727b67fbafa2a7baf89589ee2c85ce4637659ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-05tdf#165504 restore SdrPage::GetLayoutName virtualCaolán McNamara1-1/+1
revert commit 235c230cd348600ce7385cc580c45a7be3572704 CommitDate: Tue Oct 22 09:17:02 2024 +0200 We don't need a virtual here and commit 960db01dbfe2f916b91782da03532fae1f836445 CommitDate: Sat Dec 28 22:13:40 2024 +0100 Resolves: tdf#164463 we need to pass a copy of the LayoutName Change-Id: Iecc486eca72e4d752527e77a9817dc4bed663cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182445 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-02-27sd presenter a11y: No longer read a11y names from configMichael Weghorn1-0/+4
Instead of reading strings for the a11y names to use for the Impress Presenter Console objects, use the usual approach for translatable strings. This is simpler and I see no reason to have those accessible names configurable. Maybe the previous approach was somehow related to the fact that Presenter Console used to be an extension before commit ea91c7d90d74e1ca039ba669b5d3e14fa359c0fa Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Nov 21 17:19:28 2012 +0100 Turn presenter screen from bundled extension to plain code Change-Id: I55b5e525913f429ec60a1c21b7bf162870d79af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182325 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Drop always false paramsMichael Weghorn1-11/+1
All callers of PresenterHelper::createWindow pass false for both, the `bEnableChildTransparentMode` and the `bEnableParentClip` params. Drop them altogether, which allows to simplify PresenterHelper::createWindow a bit. Change-Id: Id4dc1ddb81833cdd303ec8314a80eeeee1cd89ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182300 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Drop always false bCreateSystemChildWindow paramMichael Weghorn1-5/+0
PresenterHelper::createWindow always gets called with a `bCreateSystemChildWindow` param of false. Drop the param altogether. Change-Id: Ia82dfa6d4826bf2cbe85a164c7645d3e9a7d1fc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182299 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Don't allow creating PresenterHelper objsMichael Weghorn1-11/+1
By now, the class is only useful for the static helper methods it provides. The last use of an actual PresenterHelper object was dropped in Change-Id: I7b85ae4f720474faf72d2721545158726b1d745d Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Feb 27 11:04:45 2025 +0100 sd presenter: Drop PresenterPaneBorderPainter::Renderer::mxPresenterHelper Make that clear by marking the default ctor as deleted and dropping what has become irrelevant. Change-Id: I411b02b94c8f81bc8cfb19e248e861adfe1a670e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182298 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Drop unused PresenterHelper::createCanvasMichael Weghorn1-18/+0
Change-Id: Ia3231f30ff7ee0223d596d1b15936b5ddd792a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182290 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Make PresenterHelper::getWindowExtentsRelative staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make sd::presenter::PresenterHelper::getWindowExtentsRelative static. Drop rtl::Reference<PresenterHelper> class members in other classes that are now no more needed as they were only used to call the now static method. Change-Id: Ic095cfa900db7211bc3b7e286702807afeba1c20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182289 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Make PresenterHelper::toTop staticMichael Weghorn1-2/+2
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make sd::presenter::PresenterHelper::captureMouse and sd::presenter::PresenterHelper::releaseMouse static. This also makes PresenterScrollBar::mxPresenterHelper unnecessary, so drop it. Change-Id: Id45500f07fd5388abdcc0fc51623287cfc247f51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182288 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Make PresenterHelper::loadBitmap staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make PresenterHelper::loadBitmap static. Change-Id: I7741b966e09850412f60d2a3f44d36b401553729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182287 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Align param names in doc with actual onesMichael Weghorn1-11/+11
This was forgotten when the doc was taken over from the XPresenterHelper IDL file in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper Change-Id: I79d9ff754f175d768b53bfc3a64d77d2cae88faf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182280 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Use u16_string_view, OUString instead of char const*Michael Weghorn1-2/+2
This also prepares for an upcoming commit to make PresenterHelper::loadBitmap static, at which point switching the method param to std::u16string_view would be mandated by a clang-plugin. Change-Id: I6def3aceb1966c5d0d24db5112d64f6e662d55bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182279 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Make PresenterHelper::createSharedCanvas staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make PresenterHelper::createSharedCanvas static. This also makes PresenterButton::mxPresenterHelper unnecessary, so drop it and the ctor param only needed create it. Change-Id: I4af6e537d140a330fc6ffca518ed2809b935dafe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182278 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Use bool instead of sal_BoolMichael Weghorn1-8/+8
sd presenter: Make PresenterHelper::createWindow static Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , there's no more reason to use sal_Bool. Change-Id: I0333f7c1a05fe0bca4ce3920d8142bb89c03418d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182277 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Make PresenterHelper::createWindow staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make PresenterHelper::createWindow static. Change-Id: I8d43904294e130b8f50bc4986c740b92a1a3cf4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182276 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Make PresenterHelper::toTop staticMichael Weghorn1-2/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make PresenterHelper::toTop static and adjust callers. This also makes PresenterParseContainer::mxPresenterHelper unnecessary, so drop it and the PresenterParseContainer ctor param only needed to initialize it. Change-Id: Ifc4e1447e11f4a3b73277f8610875ba8294e0975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182275 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27tdf#90293 switch draw selection to rotate modeOliver Specht1-1/+1
Clicking a draw object(selection) switches to rotate mode and back in Calc/Writer like it is done in Draw/Impress already. By default this function is off an can be activated in via toolbar Drawing Change-Id: I4a11d008e7df97c5278cae987d5c47fa50cddf14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181169 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-02-27[API CHANGE] Drop css::drawing::XPresenterHelperMichael Weghorn2-35/+101
As the interface's documentation says: /** This interface is a collection of functions that were necessary to implement larger parts of the presenter screen as extension. The methods of this interface give access to services that could only be implemented in the Office core, not in an extension. <p>As the presenter screen is no extension any more, this hack can go again; it just needs clean-up.</p> */ interface XPresenterHelper Now that all uses of the interface have been replaced by using the concrete sd::presenter::PresenterHelper class directly in previous commits (see the `git log --grep="sd presenter"` output), drop the interface. Take over method documentation to PresenterHelper. Now that PresenterHelper no subclasses XPresenterHelper, further cleanup/simplification is possible in upcoming commits. Change-Id: Ie7bdad151d28762af1710db896bfaa1026dae65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182259 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Call PresenterHelper ctor directly, drop serviceMichael Weghorn1-6/+3
Instead of creating instances of sd::presenter::PresenterHelper by using a "com.sun.star.drawing.PresenterHelper" service and a factory to create them, call the ctor directly. Drop the now unused service/component. The use of UNO abstraction seems to be historical only, see the /** This interface is a collection of functions that were necessary to implement larger parts of the presenter screen as extension. The methods of this interface give access to services that could only be implemented in the Office core, not in an extension. <p>As the presenter screen is no extension any more, this hack can go again; it just needs clean-up.</p> */ comment in offapi/com/sun/star/drawing/XPresenterHelper.idl, introduced with commit ea91c7d90d74e1ca039ba669b5d3e14fa359c0fa Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Nov 21 17:19:28 2012 +0100 Turn presenter screen from bundled extension to plain code Change-Id: I9e65b907eca64c0abcafee3423fb21d2a657d850 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182239 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Move PresenterHelper.hxx to sd/incMichael Weghorn1-0/+99
This is in preparation of using the PresenterHelper class directly PresenterController instead of the XPresenterHelper UNO interface. Change-Id: If1896a4514b1f5a39091c4a154d8bc53dc752ef0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182238 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-17tdf#161195 Allow right-to-left brochure printing in Draw / ImpressMohamed Ali1-0/+2
introduces support for Right-to-Left (RTL) brochure printing in LibreOffice Draw and Impress. The changes include modifications to the print layout logic to handle RTL text and ensure proper alignment and formatting. - Adjusted the brochure printing logic to correctly handle RTL page order. This ensures that pages are printed in the correct sequence for RTL languages, which is essential for creating readable brochures. - Modified the user interface to allow users to select RTL brochure printing. This includes adding new options in the print dialog. Change-Id: Ie0c5e6abebfdf4805c1b9d9d43bdf91f5d710aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177432 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2025-02-14SD: fillapi: slide, text, uno commandsAttila Szűcs2-0/+5
Implemented extract and transform for slides. It can manipulate slides and some of its text content. usable commands for transform: {"JumpToSlide": 4}, //jump to slide 4 (counted from 0) "last" can be used {"JumpToSlideByName": "Slide 4"},jump to slide named "Slide 4" {"InsertMasterSlide": 10}, //insert the 10. masterSlide after the actual slide, and jump to this new Slide {"InsertMasterSlideByName": "name"}, //same as InsertMasterSlide, but with parameter of masterSlide name. {"DeleteSlide": 2}, // delete the 2. slide. It may or may not change the actual slide can be used without parameter: {"DeleteSlide": ""}, // it delete the actual slide. {"MoveSlide.2": 5}, // move the 2. slide to the 5. position, if it is the actual slide, then jump to the new position of this slide. If it is not the actual slide then it may jump, so the actual Slide eill remain the same. {"MoveSlide": 5}, // move the actual slide to the 5. position {"DuplicateSlide": 5}, //duplicate the 5. slide , it jumps to the duplicated slide {"DuplicateSlide": ""}, // duplicate the actual slide {"ChangeLayout": 18}, // change the actual page layout to the 18. layout. (would be good to have a better ID) {"ChangeLayoutByName": "AUTOLAYOUT_TITLE_2CONTENT"}, //same as ChangeLayout, nbut indxed by the layout name. {"RenameSlide": "NewNameForSlide"}, //rename the actual slide {"SetText.0": "first"}, //set the text of 0. sdrobject on the actual page to "first" {"MarkObject": "1"}, //mark the 1. sdrobject on the actual slide {"UnMarkObject": "1"}, //Unmark the 1. sdrobject on the act slide {"UnoCommand": ".uno:DefaultBullet"}, //run an uno command. This uno command toggle the default bullet type on thext marked. There are many more uno commands. Limited uno commands allowed to be used here, because some would be dangerous. For allowed uno commands, check lokunocmdlist.hxx. Note: Uno commands not worked on a windows system For layout names these can be used: "AUTOLAYOUT_TITLE_CONTENT" "AUTOLAYOUT_TITLE_CONTENT_OVER_CONTENT" "AUTOLAYOUT_TITLE_CONTENT_2CONTENT" "AUTOLAYOUT_TITLE_4CONTENT" "AUTOLAYOUT_ONLY_TEXT" "AUTOLAYOUT_TITLE_ONLY" "AUTOLAYOUT_TITLE_6CONTENT" "AUTOLAYOUT_TITLE" "AUTOLAYOUT_TITLE_2CONTENT_CONTENT" "AUTOLAYOUT_TITLE_2CONTENT_OVER_CONTENT" "AUTOLAYOUT_TITLE_2CONTENT" "AUTOLAYOUT_VTITLE_VCONTENT" "AUTOLAYOUT_VTITLE_VCONTENT_OVER_VCONTENT" "AUTOLAYOUT_TITLE_VCONTENT" "AUTOLAYOUT_TITLE_2VTEXT" Extract will: Extract all masterSlides name Extract the following for all Slides: Name, MatsreSlideName, LayoutId, LayoutName, ObjectCount, Objects. For all objects it will extract: TextCount, Texts For all texts it will extract: ParaCount, Paragraphs where Paragraphs is an array of strings. Change-Id: Icab5afe44acc30f8b75974240d8b39fd040ede2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181671 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-02-04No longer use std::optional for SfxModule::CreateStyleFamiliesMichael Weghorn1-1/+1
Just return an empty std::vector instead of a std::optional that contains no value in the default implementation, and adjust the type of the local variables and class members that contain the result and their use accordingly. Change-Id: I4e25b3cbd96c6eb9f06b0ae44b36675bb11ab38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181024 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-29tdf#164900 table text in different columns no longer lined upNoel Grandin1-1/+1
Revert "tdf#161846 use unordered_map in SfxItemPropertyMap" This reverts commit c39978f41dccbeb2e973c919a67d9b1d974f8f3c. Change-Id: I26cadb32b426fd3b48179b67c677213a78b4999c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-10tdf#146947 - UI: Ability to show/reveal characters being typed intoBalazs Varga1-0/+3
password prompt to decrypt a document. Add toggle buttons for showing and hiding password characters in password textbox entries. Change-Id: Iba69d303431c2f9f2c987c67fcbd3f36b42dc057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179889 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2025-01-03Drop unneeded forward declarations from include/Gabor Kelemen1-0/+1
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-17cool#7406: Refactor Impress->getPartInfo & use JsonWriter.Gökay Şatır1-0/+3
We need to add more information to getPartInfo function for getting grid properties. While doing this, i refactored current function to use JsonWriter. We also need to inform client side when a page border, size or margin change happens. This commit also adds a shared function for these events. Change-Id: I9dad094545c7cf0e072a7831f300dd0401ebf4a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178639 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-11tdf#161541 sd: fix the orientation of handouts on the printed pageTibor Nagy1-1/+1
Change-Id: I1896674ab317fcbcfe2ebbe9ea21dcc36c203328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178274 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-11-26Resolves tdf#126857 - Center object on page/slideHeiko Tietze1-0/+1
* uno:AlignMiddle labeled "Middle" * uno:AlignOnPage added Change-Id: Iafc162bdd80d7c20fabd55234e93212c1fa3435a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177348 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-25move SdViewOptions options down to ViewShellBaseCaolán McNamara1-1/+3
ViewShellBase is the SfxViewShell and is the analogue of the equivalent writer/calc SfxViewShell's, while a DrawViewShell is one of multiple sd::ViewShells that can exist inside that SfxViewShell Issue: * When creating new shell instances, background color is fetched from application configuration. * When multiple users are active on an Impress document, if one switches to notes view, a new shell is created. * Background color for the new shell is fetched from app colors. * If another user has switched to dark mode, the user which just switched to notes view, will see dark mode for their background. Moving the SdViewOptions options down the ViewShellBase means that multiple sd::ViewShells hosted within that ViewShellBase share the same view settings. Change-Id: Id875260dda89311ab8029ead08b47f80fd14604f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177253 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-24Turn SD_MOD macro to a functionMike Kaganski1-2/+2
Change-Id: I1303e9d48e92ac00eee12af9ed299cdaad2ce009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177072 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-23related tdf#157255: add DisableLayerHighlighting expert settingJim Raykowski1-0/+1
This allows the layer objects overlay to not be done when the value set for DisableLayerHighlighting is less than the number of objects in the layer of the tab which the mouse is hovered over in the layer bar. Change-Id: Ie49ecb11bfb029ada57824c0acbbd133e1fe83b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176809 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-11-22loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I24666a7746f8920ddf84731f204f3e1a5b9b0c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177024 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-28don't use iterateItemSurrogates for EE_FEATURE_FIELDNoel Grandin1-0/+4
Change-Id: I96cd1728e2358d4ea49275952726aae85e6f52a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175726 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-25Related: tdf#159860 inform if there is > 100 master slidesCaolán McNamara1-0/+4
which is atypical and easy to not notice when it happens Change-Id: I16546b0e841771c746cd33fefd7ec15e2877b08d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-22We don't need a virtual hereCaolán McNamara1-1/+1
Only known SdPages need this Change-Id: Id504cd1ec318fa8cce43d11f03c628e7457f7634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175369 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-22set stylesheet parent at creation timeNoel Grandin2-2/+4
avoids a bunch of broadcasting. a similar mega-master-page scenario as reported in tdf#158773 9.1 - 7.0s Some re-ordering of SVG output occurs, which means tweaking some unit tests. Change-Id: I447a4639a96c12c627a074f7e0f1ede8b3cbaf72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-21set master slide name at creation timeNoel Grandin1-1/+1
which avoids some expensive broadcasting when the name is changed a similar mega-master-page scenario as reported in tdf#158773 48s -> 20s Change-Id: Ifcfd96077a9e83868ac96671ce9f208ae3ca418f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175126 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-10cid#1607338 Data race conditionNoel Grandin1-3/+0
move this logic to the destructor, like we do elsewhere Change-Id: Ie41c78b0a01d79020cb77fd5be70116f473e910f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-01loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I3897ccb3349874672b778835b9c15642cb1a14f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-17use more concrete UNO types in sdNoel Grandin1-0/+4
Change-Id: I04578521e86759af7fdd6d2d19d8313ed8bc1bf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173457 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-19pAttr is always dereferenced, use a reference hereCaolán McNamara1-1/+1
Change-Id: I183a522704d0fbe2ba2907e75e8794621e94c178 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172022 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-06cid#555593 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1555849 COPY_INSTEAD_OF_MOVE cid#1555936 COPY_INSTEAD_OF_MOVE cid#1555951 COPY_INSTEAD_OF_MOVE cid#1555955 COPY_INSTEAD_OF_MOVE cid#1555960 COPY_INSTEAD_OF_MOVE cid#1555964 COPY_INSTEAD_OF_MOVE cid#1555965 COPY_INSTEAD_OF_MOVE cid#1555975 COPY_INSTEAD_OF_MOVE cid#1555979 COPY_INSTEAD_OF_MOVE cid#1555987 COPY_INSTEAD_OF_MOVE cid#1555990 COPY_INSTEAD_OF_MOVE cid#1555991 COPY_INSTEAD_OF_MOVE cid#1556002 COPY_INSTEAD_OF_MOVE cid#1556008 COPY_INSTEAD_OF_MOVE cid#1556011 COPY_INSTEAD_OF_MOVE cid#1556015 COPY_INSTEAD_OF_MOVE cid#1556017 COPY_INSTEAD_OF_MOVE cid#1556023 COPY_INSTEAD_OF_MOVE Change-Id: I8ab99d8e52a1780173a4272c59d408432c29de9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29tdf#161846 use unordered_map in SfxItemPropertyMapNoel Grandin1-1/+1
with large property maps, even a binary search starts showing up, but we can do a O(1) search here by using a map Change-Id: Ie7916076073e6dd393f0a1fb5a0db1b973999408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171173 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-20annot: clone annotations in SdrObjects when the page is duplicatedTomaž Vajngerl1-1/+2
When the page is duplicated we need to clone all SdrObjects and with that also all the annotations contained in the SdrObjects. The annotations must also be added to the page, so that we can find them quickly. Previously we only cloned the annotations and relied that the SdrObjects would be automagically be created, but as the SdrObject are also cloned this creates a mess with duplicated objects with annotatins for the wrong page or annotation objects with missing annotation. Change-Id: I4bf53e4bd387fad9b0a8e4f43edd57c3d0fd34cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169256 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit c3281e071526f7efa9b7646a993476fc3f6ff8db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169260 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-11annot: Add tests for annotations - insert, delete, undo/redoTomaž Vajngerl1-3/+3
Change-Id: Ie9d88c15af13fb481bb48c838b3b0ef2f41f11e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168512 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-06-11annot: new Annotation sdr object, replacing annotation tagsTomaž Vajngerl1-25/+1
Previously the annotations are shown as annotation (smart) tags, which just mark in the document the existence of an annotation at a certain position. For PDF support the annotations can be more complex, so they can show many forms of vector graphic, ink, bitmaps, text boxes,... and for this a normal tag is not enough. This change moves the annotations from simple tag to use the sdr objects, so any SdrObject can be created as an annotation. The previous tag annotations are using SdrObject (actually SdrRect) subclass AnnotationObject and the code that previouslly worked with the tag annotations has been adapted. The (PDFium based) PDF import has been changed to use subclasses of the SdrObjects for the PDF annotations. Change-Id: I4746b85b5b679499e470987e61ed356397e56bf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168485 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-06 07:24:20 +0000