summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
16 hoursa11y: Drop unnecessary XAccessibleExtendedComponent overridesMichael Weghorn2-14/+0
Drop overrides of the XAccessibleExtendedComponent which just return an empty string. That is now already implemented in the base class implementations in OAccessibleComponentHelper, see Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Mar 31 13:49:20 2025 +0200 a11y: Merge OAccessible{,Extended}ComponentHelper, add default impl Change-Id: Ibc3fe295eaa2dc5443ba4f8fa25a81451b7b3765 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183553 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
16 hoursa11y: Merge OAccessibleComponentHelper and OCommonAccessibleComponentMichael Weghorn3-3/+3
Merge the two classes, now that OAccessibleComponentHelper is the only OCommonAccessibleComponent subclass after Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Mar 31 13:49:20 2025 +0200 a11y: Merge OAccessible{,Extended}ComponentHelper, add default impl Change-Id: Ic7a36c40066f307f8df29dc4dd45ed3ee966bcb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183552 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
16 hoursa11y: Merge OAccessible{,Extended}ComponentHelper, add default implMichael Weghorn2-2/+2
Merge OAccessibleExtendedComponentHelper and OAccessibleComponentHelper by letting OAccessibleComponentHelper already implement the XAccessibleExtendedComponent interface. Add default implementations for the two XAccessibleExtendedComponent methods (XAccessibleExtendedComponent::getToolTipText and XAccessibleExtendedComponent::getTitledBorderText) that simply return an empty string. Replace all uses of XAccessibleExtendedComponent by OAccessibleComponentHelper. This simplifies the class hierarchy and prepares for further simplification in upcoming commits. Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183551 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
16 hourschart a11y: Reuse base class logic to check disposed stateMichael Weghorn4-40/+15
Change-Id: I79c95519ee5ba76f68bff6984e3659abdea9ce60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183537 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
16 hourschart a11y: Drop AccessibleBase::BroadcastAccEventMichael Weghorn2-20/+8
Use the base class's OCommonAccessibleComponent::NotifyAccessibleEvent directly instead. The old/new params are in reverse order for that one, so adjust callers accordingly. Change-Id: I8d4ef730a139366c5762836819e20d35cb2ff5a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183536 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
16 hourschart a11y: Use OAccessibleExtendedComponentHelperMichael Weghorn6-194/+20
Let chart's AccessibleBase derive from OAccessibleExtendedComponentHelper to make use of the logic already implemented there instead of having to implement all the XAccessible(Extended)Component and XAccessibleEventBroadcaster methods manually. AccessibleBase::getBounds implements what is needed to implement OAccessibleExtendedComponentHelper::implGetBounds, so rename the method. Drop all of the other overrides that are no longer needed as the implementation is now provided by the base class. Adjust subclasses as well to deduplicate logic there, too. No change in behavior intended or observed initially when testing this with Accerciser and Orca and the gtk3 and qt6 VCL plugins for a chart inserted in Writer ("Insert" -> "Chart"). Change-Id: I5d29c099dc31d70711f4017e52a0859f22c5aa23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183524 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
16 hourschart a11y: Simplify XAccessible{,Extended}Component implementationsMichael Weghorn6-98/+20
Let the base class AccessibleBase implement XAccessibleExtendedComponent with default implementations for the methods that simply return empty strings. This simplifies the implementation in subclasses, that now only need to override XAccessibleComponent and XAccessibleExtendedComponent methods when they actually want to have a different behavior, not to avoid ambiguity due to XAccessibleComponent being a base class of both of their base classes (XAccessibleExtendedComponent, AccessibleBase). Change-Id: I2a6a39a721de19178954db898d52a2d7bc01fcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183523 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
16 hourschart a11y: use vcl::Window instead of XWindowMichael Weghorn9-46/+51
Switch AccessibleChartView::m_xWindow, AccessibleElementInfo::m_xWindow and related code from using the UNO interface css::uno::WeakReference<css::awt::XWindow> to using the concrete implementation class vcl::Window/ChartWindow directly instead of assuming it's a vcl::Window and then using VCLUnoHelper::GetWindow to get the vcl::Window from the XWindow in multiple places. Rename the members accordingly. Use a VclPtr and clear it in AccessibleBase::disposing and AccessibleChartView::disposing. No change in behavior intended or seen in a quick test using Accerciser with the qt6 VCL plugin with a chart inserted in Writer using "Insert" -> "Chart". Change-Id: If98ef041fdd1a8bf68620e0c8b1e81973e7b01f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183522 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
16 hourschart a11y: Use nullptr directlyMichael Weghorn1-3/+2
This makes more obvious that this is null. In particular calling VCLUnoHelper::GetWindow with a Reference that is known to be empty/null doesn't make much sense. This has become more obvious with previous commit Change-Id: I91d4e9cc40473aa204ec7bcada954cf0f765e6ea Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Mar 31 06:14:27 2025 +0200 chart a11y: Make clearing weak refs more obvious Change-Id: Ia544001d609ede8f44003ffd4befc3cddccf045f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183519 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
16 hourschart a11y: Make clearing weak refs more obviousMichael Weghorn1-9/+2
Drop the local vars that are first assigned the current value of the members, but then cleared, and then assigned to the members. Instead, clear the members directly to make more obvious what's happening. Change-Id: I91d4e9cc40473aa204ec7bcada954cf0f765e6ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183518 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
16 hourschart a11y: Use Reference to XAccessibleMichael Weghorn1-3/+3
Before commit bdf2d664784b3ebe3e7078b9ec82a02d09d9ded8 Date: Sat Sep 2 10:44:51 2023 +0200 use more concrete type in AccessibleChartView , that was a `Reference<lang::XInitialization>`, but now, there's no more reason to use something else than an XAccessible. Change-Id: I054fad40e1b62f3b4ec688ab09673d4c86f7f1ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183517 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
16 hourschart: Use ChartController::m_xViewWindow directlyMichael Weghorn1-81/+33
... instead of assigning it to an additional local variable and using that one. Also drop the (maybe related?) //@todo comments that unfortunately don't say what should be done... Change-Id: I08ba33facba385b4f1b43f176125710dd8f031d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183516 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
16 hourschart a11y: Drop XEventListener inheritanceMichael Weghorn2-12/+1
Don't let AccessibleBase subclass XEventListener as there's no need to, and AccessibleBase::disposing wasn't doing anything anyways. Change-Id: I6fa5e7cb65853e775792c35ce6571104c8c7edcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183515 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
32 hoursmerge ExplicitValueProvider interface into ChartViewNoel Grandin19-336/+221
Change-Id: I4e5ef8c00b8e1b001d0f711c0c15814d316e2905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183479 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
43 hourssimplify the DLL annotations in chart2Noel Grandin71-382/+221
now that the libraries are merged, nothing needs to be visible Change-Id: I009f062301ccec9cf9c57b3280a3cd7452adcf38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daysmerge chartcore and chartcontroller librariesNoel Grandin15-665/+365
there is no good reason to keep these separate Change-Id: Ib484dbd5d331b0d1a117f5fc2e331123c4e70d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 dayssimplify Chart2ModelContact a littleNoel Grandin2-39/+30
Change-Id: I26ac8717e70a737c0c15441603cbf48db4913233 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183465 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daysremove volatile from m_bStateSetInitializedNoel Grandin1-3/+1
because volatile does not mean thread-safe in C++ And update comment, because there is no double-checked locking going on here. Change-Id: I7fe8622d4e193387664edf659a408575f2f8d0f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183397 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daysremove volatile modifiers in CloseableLifeTimeManagerNoel Grandin1-3/+3
(a) these fields are only accessed when the mutex is held (b) volatile does not mean thread-safe in C++ Change-Id: I0cc1abb2fba5596d73e3a688e4df228d853bf1d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183396 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
5 dayssimplify CloseableLifeTimeManager a littleNoel Grandin2-12/+5
Change-Id: Iad50da94acc1ad476b98762ff3ab3f0f677d5f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183395 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
8 daysloplugin:constparam in chart2Noel Grandin4-12/+12
Change-Id: I3d538fe3e97569e9c67c7924ffa585c93d131dc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183286 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 daysRename con-const vcl::Font property getters for clarityMike Kaganski2-7/+7
There are two sets of getters there; and the non-const ones may copy the COW mpImplFont, and may call its AskConfig. The name overload is unfortunate. It is not obvious at the call site, which of the two will be called; and what is different. IMO, the way to fix it would be to keep only one set of getters (the const one), and make the call to AskConfig explicit (in the places that set font name, and know that resolution of other properties will be needed). But in this change, I only rename the non-const getters, making sure to keep the behavior unchanged (at least the intention is to have a non-functional change, meaning that the places that called non-const overload, now use the renamed functions), to make it clear where we actually may copy and initialize it. Change-Id: I9a5cd91d5c1c0de7ff8577b9b982d165e4cdd2c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183116 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-03-10tdf#165491 ITEM regression: Chart needs order of eventsArmin Le Grand (Collabora)1-0/+23
The Item with WhichID SCHATTR_STAT_KIND_ERROR *has* to be handled 1st since it sets additional information about the ErrorBarStyle at beans::XPropertySet xErrorBarProp that the processing of the *other* Items already need access to, see 'case SCHATTR_STAT_KIND_ERROR' in StatisticsItemConverter::ApplySpecialItem. This worked before the change of SfxItemSet to use a std::unordered_set since the order of Items was fix and - since SCHATTR_STAT_KIND_ERROR had the lowest WhichID - was handled 1st. Not sure if that was by purpose and it was known that this was necessary - there are no comments hinting to that, so it might have worked by coincidence before. In general it is bad style to rely on the 'order' of Items in an ItemSet - there is no order defined in general. Change-Id: I93e2c8e30f762e1bb83adb2b43459bbfb263a151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182742 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2025-03-08use more concrete UNO in chart2Noel Grandin6-16/+16
Change-Id: I0f91e4ed7a2ddc656d0edb3c8a54960a3b1b70b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182666 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-04tdf#163989 a11y: Introduce Window::GetAccessibleParentMichael Weghorn1-5/+1
Add new method Window::GetAccessibleParent that for now uses the existing logic duplicated in multiple places to get the accessible for the window returned by `Window::GetAccessibleParentWindow()`. Deduplicate code by using the newly introduced method instead. No change in behavior intended by this change, but this also prepares for an upcoming commit that will allow explicitly setting a parent. Change-Id: I0ac5e370d34994c1ede864204d4d41019f7b9336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182441 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-25chart a11y: Avoid const_castMichael Weghorn2-9/+3
AccessibleBase::BroadcastAccEvent is only called from non-const methods, so there is no need for it to be const itself. Drop the const qualifier and the now no longer needed const_cast of `this` inside the method. Change-Id: I9e8bb74d761135b1f22525fa79912f4694ca7654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182121 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-25chart a11y: Use rtl::Reference<AccessibleBase>Michael Weghorn2-32/+21
Use an rtl::Reference of the specific AccessibleBase instead of a generic uno::Reference<XAccessible> and then still making assumptions that it's actually an Accessible object in various places. Change-Id: Iaccccc3e928d4f47b16b4681404b6c6169ac67c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182120 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-24Simplify a bitMike Kaganski1-9/+10
No need to calculate these square roots at runtime Change-Id: I29689f4bd9bf3f5e00eccadae067973343b237b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175990 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-02-20use more concrete UNO types in some local varsNoel Grandin17-49/+36
found by a clang plugin I created. Change-Id: I72ebc2b6fadb854a12d69a543facf2fd7e4f1e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-14tdf#158068 Use OUString literals in DataInterpreter.cxxSimon Chenery1-2/+2
Change-Id: I53c620921a93265513dcb4460d73902eff97ed5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181647 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-02-09tdf#163486: PVS: Constant expression in switch statementBogdan Buzea1-0/+2
V785 Constant expression in switch statement Added a default value for the case of uninitialized nStyle. Change-Id: I3c73a9b293958d72a7897b5923afdd9291030db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175901 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2025-02-07browsebox: Convert dispatch ID defines to enum classMichael Weghorn1-4/+4
Convert the `BROWSER_*` defines in include/svtools/brwbox.hxx to a new enum class BrowserDispatchId. The specific integer values that were used don't seem to have any particular meaning, so just drop them. Add default case that does nothing in BrowseBox::Dispatch to address /home/michi/development/git/libreoffice/svtools/source/brwbox/brwbox2.cxx:1779:13: error: 5 enumeration values not handled in switch: 'NONE', 'CURSORENDOFSCREEN', 'CURSORTOPOFSCREEN'... [-Werror,-Wswitch] 1779 | switch (eId) | ^~~ 1 error generated. Change-Id: Ibb023ec13ee2c10a0fc0ef7abe1371dbd856e735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181167 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-30tdf#151278 tdf#164724 tdf#164728 tdf#164729 switch off charts number format ↵Oliver Specht3-15/+46
from source Labels get their number format usually from source. When copy/pasted the chart has no connection to a source format anymore. The related LinkNumberFormatToSource flag is therefore reset. The label (data series) number format used is now also saved. Change-Id: I640083ec0036f116dec94cc982317e1e7992328b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180600 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
2025-01-16loplugin:unusedmethodsNoel Grandin2-42/+0
Change-Id: I8041b975ee8e1cb0a75c43c6332f315627847033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180343 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-01-03Drop unneeded forward declarations from include/Gabor Kelemen3-0/+6
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-02Drop unneeded forward declarations from chart2 moduleGabor Kelemen93-264/+0
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I9fd1148e8cff3ebda4595820af5fc824f530245c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178967 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-07weld: Rename weld::Treeview selection signal/connectMichael Weghorn3-4/+5
Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04[API CHANGE] a11y: Drop XAccessibleExtendedComponent::getFontMichael Weghorn4-30/+0
This method from the unpublished XAccessibleExtendedComponent interface is not used by any of the a11y platform bridges, and I don't know of any platform a11y API that would need it. In order to report character/font attributes, there is the XAccessibleText interface and its XAccessiText::getCharacterAttributes method instead, which actually gets used by the platform a11y bridges. Therefore, drop this method to simplify code, and also decouple the accessibility module a bit further from the toolkit module without having to reorganize code further. (VCLXFont from the toolkit module currently gets used in various implementations.) Change-Id: I06ea3cc5998a13927b3f869877b28f03ac07c89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177809 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-02tdf#120658 - Reworking of dialogues Organize macrosJim Raykowski1-0/+2
(make from 5 existing only one) Much of what makes up this patch is adapted from existing code that is used to organize and select macros and to assign macros to shortcut keys. Comments in the patch say where code is borrowed from. Known issues: + Scripting framework library rename for BeanShell, Java, and JavaScript always returns fail when there are no macro entries in the library even though it actually succeeds. The same thing happens using SvxScriptOrgDialog::renameEntry. + Deleting Basic macros from the Macro Manager dialog is not implemented yet. Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29tdf#158237 chart2: use c++20 contains() instead of find() and end()Bogdan Buzea1-1/+1
Change-Id: I4b02c5b4dca22bce5653dad1d179ea2a1b249a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176798 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
2024-11-29PVS: the 'bDummy' variable was not initialized.Xisco Fauli1-5/+13
This variable is passed by a reference to the 'readArguments' function in which its value will be utilized. Inspect the fifth argument. Change-Id: I39d71ac5e76d3d9a808fa08a430af9aa0686684d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177494 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-27PVS: V560 A part of conditional expression is always trueXisco Fauli1-3/+3
Since commit 9b538afc2995f7d703a77bb4e6d0e1bc97e3ca20 Author: Vladimir Glazounov <vg@openoffice.org> Date: Tue May 22 17:46:33 2007 +0000 INTEGRATION: CWS chart2mst3 (1.10.4); FILE MERGED Change-Id: I1ed040165018d38770f7438a7f64436c7aa4873f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177412 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-26tdf#161800 - I/O of '# of values in second plot' parameter not supportedKurt Nordback19-45/+145
Add support for input and output of 'split position' parameter (number of entries in second plot) for of-pie charts. In OOXML this uses the supported split-pos tag. For ODF I added an extension in loext namespace for this parameter. This commit also includes simple tests for the I/O functionality in OOXML and ODF. Change-Id: I00ff59db721867fa836eb99b6677350040d005dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170666 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-24Let ESelection use EPaM for simplificationMike Kaganski1-2/+1
And drop EPosition, which duplicates EPaM, except for its default ctor (used in a single place). Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-23tdf#152299 - Remove unused define(s) from C/C++ filesBogdan Buzea1-5/+0
Change-Id: I93494b4dec546d48b7dced2f1a6c774177c99c86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176782 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-22PVS: V560 A part of conditional expression is always true:Xisco Fauli1-1/+1
!rPolyPolygon.empty(). Change-Id: I61b79d0995cc08b70c2a39bdeb043a22722313e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177000 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-21tdf#163486: PVS V1043 global object variable is declared in header (chart2)Julien Nabet1-135/+135
Change-Id: I553e7ed4782341fa0a2e8e7d444f158bc18d770e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176943 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-19improve loplugin passparamsbyrefNoel Grandin5-10/+10
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-16tdf#163486: PVS: Identical branchesBogdan Buzea1-3/+1
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar. Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-02 01:17:50 +0000