summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-01-06Merge comphelper::OAccessibleContextHelper into ↵Stephan Bergmann45-393/+366
comphelper::OCommonAccessibleComponent Change-Id: I586ae8fe2842fd879ae2ae506c659d06dda16843 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145160 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-06Fix copy/paste typosStephan Bergmann2-2/+2
...apparently introduced in 4883fd31141c3598b25a123033297f847cd18552 "weld ScTabBgColorDlg" and 3e078e17ee2144fb976a7e6b9227152113cea0d4 "weld SfxTemplateManagerDlg", resp. Change-Id: I08dd6df262d12bc844a992d6e13b9732860e74bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145159 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-06tdf#152896 do not apply color shading twiceRegina Henschel3-48/+79
If a character theme color is shaded, Word writes this as w:themeShade attribute of the w:color element. If the character also has transparency, Word writes an additional w14:textFill element with a w14:lumMod child element. In such cases the w14:textFill element supersedes the w:color element. The initial implementation of Fontwork import in commit cbf30153a5c776e6d1ee26f2f83c8f77503eceb9 does it wrong. It replaces the color itself but not the color transformation, so that the shading was applied twice, once from w:themeShade attribute and the other time from w14:lumMod. The solution here is to reverse the order so that w:color is only evaluated if w14:textFill is not present. Another solution would have been to clear the color transformation vector before adding the values from w14:textFill. I use reverse order here because it more clearly reflects that w14:textFill supersedes w:color. Change-Id: I3e700795167a34238ea619b9c4a691c10da357f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145150 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-01-06Fix typosAndrea Gelmini1-7/+7
Change-Id: Ia565446bab6436940954bc1af10f612cb9a9ad9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145152 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-06Fix typoAndrea Gelmini1-1/+1
Change-Id: I403ff69c912abb2d62290b4b2067655763e0823c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145153 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-06tdf#152900: "Create new field as primary key" disabled...Julien Nabet1-2/+2
when pasting data as new table Regression from 3f8e50f9b2fb35db190ce0204981f3f02d1d5ae6 (05/2021) "merge handlers into single toggle handler" Change-Id: I05376f288c1687978225bd98da21a5e21810292a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145151 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-06move drawPolygon into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara7-80/+38
Change-Id: Ifb7514a72f7bc3a65f7f1ad51707405b1a2bd127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06SDPR: Overhauled D2DRenderer to use sal::systools::COMReferenceArmin Le Grand (Allotropia)2-297/+320
All stuff used from MS with names starting with ID2D1* is COM API stuff, so referenced and interface-based. I thought about making this more safe since a while (shared/unique_ptr, ...) but found no good way to do it. Also did not want to use CComPtr from MS and expand the devenv we need on win, so was short before doing an own small smartptr class. Luckily I asked sberg and he pointed me to the already existing sal::systools::COMReference which exactly does what I need here - thanks! Unluckily I now had to change a lot of code - sigh. I wish I had known earlier :-/ This change contains the renderer completely adapted to using that much safer and better ressource control. Plus I added (even more) comments to try to make more clear in many plasces what's going on, what is done and why. Change-Id: Ia2aa3223d0e5f7ec6569cde176cec1fadcd921dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145142 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-01-06tdf#56258 i18npool: add "adjust" to locale.dtd for outline numberingJustin Luth1-0/+1
Although Adjust was already defined in all of the code structures, it was not defined in the dtd file. Thanks to Eike for pointing out this requirement. Change-Id: I43ed0c26ed5bccb2309a255db79f5afa32f78c38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145146 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-06move drawPolyLine into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara7-382/+36
Change-Id: I141b12c99825c67e4698d53633a1fa720cc487be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06tdf#152784: RTF import: more default paragraph paramsVasily Melenchuk3-2/+31
If numbering is not explicitly mentioned in para properties it should not be used from referred paragraph style. So default value of 0 (no numbering) is used by default. Change-Id: If8e8f2aaf19190f64a557444188f67b24a699b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144839 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-06sw lok: get all refmarks: sort the refmarks arrayMiklos Vajna2-9/+53
This was using the order used by GetItemSurrogates(), which is mostly by pointer address. We know that these pool items have a text attribute, which have a node and a content index, sort by that. In theory two refmark may start at the same doc model position, but that's never the case when using Zotero, so don't worry about that for now. For a document with 5 refmarks, the original order I got was 2-3-5-4-1, now it's property 1-2-3-4-5. Change-Id: I2768845414bd36afca91ec02a0f3364c246ddfd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145145 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-06Resolves tdf#101731 - Rename Border/MidpointHeiko Tietze2-317/+315
Follow up to Icda875d3c6f03ffd29395ac5ce932475cc629361 changing "Midpoint" (formerly "Border") to "Transition start". Using the same name for transparency. Change-Id: I1f1c53ee357a9ead94100156598f43a0ac021d74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145141 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-06use std::optional for SALCOLOR_NONENoel Grandin16-194/+205
instead of re-using an actual real color value, because it will totally not work when I convert vcl to use alpha instead of transparency Change-Id: I01f043e0b65ffd852989dfe28f2b9d5a43c9c3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-06sw: add a new .uno:UpdateTextFormField UNO commandMiklos Vajna5-0/+149
It is possible to update all fieldsmarks (of a certion type, of a certain field command prefix), but one can't update the fieldmark under the cursor, which is needed for Zotero citation clusters. To make this more complex, insertion inside an existing fieldmark is explicitly not wanted, see commit a178a2ac6df8dc63a7ab8d4a19b90ae8a17baca4 (sw UI: fix crash on inserting a fieldmark inside a fieldmark, 2023-01-02). Fix the problem by adding a new .uno:UpdateTextFormField UNO command that can update the (innermost) fieldmark under the current cursor. The uno command is intentionally hidden from the customize dialog since it only makes sense to invoke it from a macro / API with parameters, not interactively. Change-Id: I46fc4f701a20839945d765eb13aec7362ab83788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145135 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-06tdf#65535 sw spellDialog.py: fix lo-upsan buildLászló Németh1-9/+6
Lo-upsan build didn't replace the bad word in the test, maybe because of dictionary or timer problems. Skip testing the (here: sometimes missing) text changes, keep only testing of the remaining comment, which was the target of the original fix. This reverts commit d2614337e8291b9b6d114fda5ae914f6940c353a "tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build" and commit 81163c384364e4b5c99392b76f027f8c2b87c259 "tdf#65535 sw spellDialog.py: fix lo-upsan build better". Change-Id: Ib5faa4e02bf6dd085d6666748ae76f67b4e07497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145138 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-01-06android: Enable checksum verification for gradle downloadMichael Weghorn1-0/+1
Follow the F-Droid Bot suggestion in [1] and set the checksum from [2] in gradle-wrapper.properties, so a downloaded gradle distribution will be verified against that, s. doc at [3]. Command used from within the `android/source` directory: ./gradlew wrapper --distribution-type all --gradle-distribution-sha256-sum cd5c2958a107ee7f0722004a12d0f8559b4564c34daad7df06cffd4d12a426d0 Note that this is the checksum for the gradle distribution, not the gradle wrapper (which is mentioned in Change-Id I3f466061aba55c5704fe251eee7e8c73f7d316aa instead.) Also note that Android Studio does not fully support the "distributionSha256Sum" attribute and requires confirming in a message saying so that the checksum is correct before syncing the project, s. [4]. [1] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12380#note_1229239229 [2] https://downloads.gradle-dn.com/distributions/gradle-7.4-all.zip.sha256 [3] https://docs.gradle.org/current/userguide/gradle_wrapper.html#configuring_checksum_verification [4] https://issuetracker.google.com/issues/129261435#comment11 Change-Id: I39902be79e7dad2ad006262efe3b6c6ab3b5de5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145105 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-01-06android: Update gradle wrapper to 7.4Michael Weghorn4-141/+209
Commit the result of running ./gradlew wrapper --distribution-type all --gradle-version 7.4 from within the `android/source` directory as described at [1]. Double-check that the sha256sum of the jar file matches what is listed on the website [2] for v7.4: $ sha256sum gradle/wrapper/gradle-wrapper.jar 575098db54a998ff1c6770b352c3b16766c09848bee7555dab09afc34e8cf590 gradle/wrapper/gradle-wrapper.jar (Interestingly, the sha256sum of the gradle-wrapper.jar used so far, e2b82129ab64751fd40437007bd2f7f2afb3c6e41a9198e628650b22d5824a14, is not the one of any listed versions there, which is what the F-Droid bot marked as error in a MR to update LibreOffice Viewer [3]). [1] https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper [2] https://gradle.org/release-checksums/ [3] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12380#note_1229239229 Change-Id: I3f466061aba55c5704fe251eee7e8c73f7d316aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145098 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-01-06move drawPolyPolygon into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara7-342/+141
Change-Id: I8eee16f10f4241ced467e2bf73e518d066f9508d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06adjust bodge to be only for CAIRO_CONTENT_ALPHACaolán McNamara1-1/+1
rather than specifically !CAIRO_CONTENT_COLOR_ALPHA Change-Id: I2b86feb8499b98e750e954c4b246d4c8bc3ef7cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145110 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06move getPixel into CairoCommon and reuse from X11CairoSalGraphicsImplCaolán McNamara7-65/+48
2nd attempt. This reverts commit 8d0b7bdb8c9ae8254e5b77b533a158734affc4f5. Change-Id: I8901a1258e0b0d89170f4e056516c5211801456a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145109 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06use current known geometry for surface size instead of SAL_MAX_INT16Caolán McNamara5-15/+19
which appears to be why getPixel failed Change-Id: I088ed0c01bdd0e9971ff52a1f70a030f0921e497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145108 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06Revert "move getPixel into CairoCommon and reuse from X11CairoSalGraphicsImpl"Caolán McNamara7-48/+65
This reverts commit 00b62877fa2f900d1c2dcf7b721f7a956408f8a0. XIOError seen with vcldemo Change-Id: Id75497f8148964372beaed9432ee6097ec8afc47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145076 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-06tdf#86630 sw: Add one-step page number insertion wizardofftkp23-4/+558
Add a one-step wizard for easy insertion of the page number to the header/footer. Change-Id: Idb33c92d594e04d9256460fe414e4b10e5166af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144683 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-06Revert "Relates tdf#139141 - Make variable date/time field the default"Heiko Tietze2-3/+3
This reverts commit b2c81dad3a0b72d305f1c6967ee4a8069ae11b45. Reason for revert: tdf#152871 Change-Id: I56f42b4ce104dbb96d8fda1bc71af727fa46d536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145007 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-06writerfilter: removed remains of GAP_HALF define and its usageVasily Melenchuk3-10/+2
Change-Id: I8dee16f923686f557c8213d9a7870392bd5fe9bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145090 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2023-01-06sw doc model xml dump: show name of refmarksMiklos Vajna4-0/+29
Unlike bookmarks, these are not tracked in the mark manager. Change-Id: I17b10dac6b74a738fd47cf25b84a7156031f01da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145103 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-06Removed executable permission on source fileAndrea Gelmini1-0/+0
Change-Id: Ida56746e5f2442ceff86e19cf52467dc766a95ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145113 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-06Fix typoAndrea Gelmini1-1/+1
Change-Id: Ie90862c12a441ddf0b325baee920b91704b05e77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145112 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-06tdf#56258: allow i18npool to define SvxAdjust for outlineJustin Luth5-11/+27
Deciding whether the numbering should be Left, Right, or Center is a rather important setting. Specifically for Roman numerals (which grow very wide as they increment to 7 and 8) the numbering styles set these to right aligned. This really helps for keeping the text nicely aligned. The numbering styles are built-in LO defaults, but locale files can define numbering and outline choices. This patch add the setting for "adjust" on the outline levels. For en_US, it makes sense to right-align roman numeral levels. [The only other highly likely candidate for this that I could find was old Hungarian (SZEKELY_ROVAS), but it doesn't seem to be used in any locale definitions.] I only changed en_US for now, but of course many other locales are also using NumType="3" and NumType="4". This only applies to the toolbar/sidebar SVX code path. The Bullets and Numbering dialog does not currently modify any spacing, so I didn't apply the adjustment either. It also doesn't make sense to do this on single numbering changes (aka ContinuousNumberingLevels or LC_NumberingLevel) because we don't know or control the first line indent there either. But at least for toolbar Outlines, we do change every level, and so can set a (somewhat) appropriate spacing. [Setting SvxAdjust without adjusting the spacing is pointless. Don't make any changes at all if the spacing ends up causing problems.] The Numbering IVX/ivx styles set the firstLineIndent to -174, so I did the same here. This is the scariest part of this change. AFAICS SvxAdjust::Left is a non-locale aDefNumStyle default, so hardcoding that for undefined LC_OutlineNumberingLevel shouldn't be too scary. Change-Id: I52deefe88aa55c55c9531b651411f64accb86f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144978 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-06tdf#152884 import alpha too for schemeClrRegina Henschel3-1/+21
Without fix the alpha child element was only read for w14:srgbClr but no for w14:schemeClr. Thus character colored by theme color had no transparency. Change-Id: I73c01b7142d3eab83400d2e5eb9dce01ff8d4a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145099 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-01-06tdf#56258 sw toolbar: show SetOutline by defaultJustin Luth7-6/+17
Because I am making improvements to SetOutline, it should be in good enough shape to display it to the general public. If the improvements don't land, or are not considered good enough, then this patch can simply be reverted. I have no intention of backporting this. Change-Id: If2a4926d136086b3ae2d17d157b5a4642d88561e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145097 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-06tdf#56258 svx SetOutline: convert to toggleJustin Luth4-4/+47
The "Outline Format" toolbar button is normally hidden. It didn't check state like the bullet and toggle numbering do. This patch adds that - so it lights up when the text contains a numbering list that matches a valid outline choice. I also added a toggle aspect to the button. Toggling ON is not great. It works fine if there is no numbering yet, but if you are in an outline and toggle off, it won't toggle back on to the same list - it starts a new one. I don't think there is much that can be done about that, since the removal delete the level information too, and outlines are all about multiple levels of numbering. The proper response to an errant toggle off is (multiple) undo(s), not toggle back on. (In the ideal world, it would popup the dropdown choices). Toggling ON does nothing when there are already bullets or numbering. The proper response is to use the dropdown if the desire is to change to an outline format. Toggling OFF is only possible when we are on a valid outline. This is extremely important because otherwise it isn't clear how to remove Outline Numbering's mix of bullets and numbers. (When the selection contains one list with both bullet and number levels, the number and bullet buttons do nothing.) Although not perfect, this is not a bad user experience, so I'm going to push the full patch to gerrit. There is one known obscure case that troubles all methods. If the selection spans multiple list definitions and ends on an un-numbered paragraph, then the toggle-on will happen. It is possible to just not do any toggling and ALWAYS show the dropdown action, but that isn't very consistent with the other related buttons. Change-Id: I6d927604e49711f1da8549be9f3dbf8b8133a06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145061 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-06tdf#115965 tdf#148790 sw toolbar: no need for RemoveBulletJustin Luth1-1/+0
The existing buttons for bullets and number lists are already toggles. Having a separate button to remove them is almost completely pointless. Change-Id: I11314a152848a9ff32eb01e2eb36bd145f890622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145096 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-06tdf#115965 sw RemoveBullet: do not light-up button when NumRuleJustin Luth1-2/+2
Sure, most of the time it was "off" when there was either a bullet or a number list. However, when the selection had both a bullet and a number list/level, then it would light up. So just make it simple. If there is a numrule in the selection, then it shouldn't be "on". There is still one obscure case it lights up funny. If more than one list is selected, and the selection ends on a non-numbered paragraph, then RemoveBullet will still light up - as if there is no numbering in the selection. Change-Id: I5c37d53206918068b2994fde9774541ea988a623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145095 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05tdf#56258 en_US: increase outline levels definitions to 6Justin Luth3-6/+17
There are 10 levels in numbering, so it only makes sense to allow outline definitions for all 10 levels. Note that DOC/X formats only allow 9 levels, There are two code paths that read these definitions. The SVX toolbar code to allow 10 levels (SVX_MAX_NUM) was already completed in the previous patch. This commit allows 10 levels for the Bullets and Numbering menu dialog. Since all choices MUST define the same number of levels, I only added one more. I hope that there isn't some secret kind of requirement that ALL LOCALE's must also use the same number of definitions - it doesn't seem to. [Although not a direct comparison, bg_BG defines 10 single number levels, compared to en_US's 8, and some Chinese locales also do more than 8.] Change-Id: Ibe00d54cfa4577db83eba368b92be11055b076ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144976 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-05sc : use std::mutex for CharClass initialisationArnaud VERSINI2-4/+9
Change-Id: I0427109da1bfed1d3d467455ab1ab3c68569f60b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144886 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-05Change variable name from rData to pDataofftkp1-3/+3
Change-Id: Ied27e34b35a22b1f2a7521fb58035170651b1ca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144001 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-01-05Related: tdf#152781 Stab the 0xE40A {es} vs Latin America quirkEike Rathke3-2/+6
First, the LANGUAGE_SPANISH_LATIN_AMERICA 0xE40A is not a MS system LCID, it is Spanish 0x00a with sublanguage 0x39 => user defined (in the range 0x20 to 0x3f). Meanwhile MS reserved 0x580A for {es-419}, so obsolete the legacy 0xE40A definition and replace with 0x580A when encountered. Second, due to the legacy plain {es} mapping being present, an encountered 'es' (from our bundled dictionary extension) got mapped to 0xE40A instead of 0xA and thus was added to the character language listbox (that otherwise suppresses LCIDs without sublanguage), resulting in a "Spanish {es}" entry. Besides, it's currently not clear how to actually proceed with such dictionary situation when, for example, both 'es-ES' and 'es' dictionaries are present and the 'es' dictionary apparently is meant as base and contains entries the 'es-ES' does not or 'es-ES' overrides entries. It might be it's handled half-way in linguistics, but maybe not even that, I didn't investigate. Change-Id: Id859731ba5efa65d4a6de429b7f52027aa69327c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145093 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-01-05Related: tdf#152703 Prevent possible hang when live resizing a windowPatrick Luby2-29/+50
Application::Reschedule() can potentially display a modal dialog which will cause a hang so temporarily disable live resize by clampiing the window's minimum and maximum sizes to the current frame size which in Application::Reschedule(). Also, eliminate flickering during live resizing of a window when using Skia/Metal. When in live resize, the SkiaSalGraphicsImpl class does not detect that the window size has changed until after the flush has been called so call checkSurface() to recreate the SkSurface if needed before flushing. Flushing had to be moved during [self windowDidResize:] to eliminate flicker. Flushing in [self displayIfNeeded] does not eliminate flicker so apparently [self windowDidResize:] is called earlier. Change-Id: Id3de838d2e17fee85cb583b6c4e862b571d47142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145053 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-05tdf#152710 xmloff: ignore exception in XMLChangedRegionImportContextMichael Stahl2-7/+21
The xOldCursor must be restored in all cases. Also XMLParaContext triggers an exception which ends up aborting the import. Change-Id: I8f4785e0e9bde4c8c484954a4d66f3b82d6ca28c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145094 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-05tdf#152710 sw: call and fix DeleteSection() insteadMichael Stahl3-14/+19
Turns out there's a function to delete a complete nodes array section - and it has the same problem? Why does it move indexes only from startnode + 1? Let's try to fix it to be more consistent. Change-Id: Iedacc10e29c1646c4ccc85e53a479b0351f5cfcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145078 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-05tdf#152710 sw: invalidate SwUnoCursors properly in DeleteRangeImpl()Michael Stahl2-2/+15
This crashes with: list.cxx:44: corrupt document structure, bailing out of infinite loop ndtxt.cxx:5437: void SwTextNode::TriggerNodeUpdate(const sw::LegacyModifyHint&): Assertion `dynamic_cast<SwTextFormatColl const*>(static_cast<const SwFormatChg*>(pOldValue)->pChangedFormat)' failed. Because the redline from 7 to 9 is deleted, but then some cursor ends up on node 10 which is invalid as it is an end node. [ 6] 0x60666a0 StartNode , [ 7] 0x61195e0 StartNode , [ 8] 0x61197a8 TextNode "tainment", [ 9] 0x6119670 EndNode , [ 10] 0x6066730 EndNode , The first problem is that DeleteRangeImpl() uses the point node as the target position for PaMCorrAbs(), but in this case the point node will be deleted. PaMCorrAbs() has a check to invalidate SwUnoCursors that would be moved out of their parent sections, but due to the first problem it can't check it, and the second problem is that lcl_FindUnoCursorSection() doesn't work on redline sections, as those have node type SwNormalStartNode. After fixing the invalidation, subsequent access to the SwXTextCursor throws exceptions and importing the file fails. (regression from commit 477e489e71b4a96ff10d9f2d2b802d91dec3e319) Thanks to Dave Gilbert for identifying the problematic DeleteRange() call. Change-Id: I48a373cc122073b82bc47513fdae684f45b0efb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145077 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-05Fix typosAndrea Gelmini3-15/+15
Change-Id: I49ca0e4e05420a4992acc348a3dc6e3533f4d30e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144618 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05Removed executable bits from source filesAndrea Gelmini2-0/+0
Change-Id: Ib9fbfc8d52bfddc6af65bf62af3c49767868e032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144952 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I963f340e0da9a0e7bc50bd1ee8c73f28c8edb6de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145101 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I6a15118c9e0b686c7157a162990b7776362865f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145100 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-05sw: UpdateFieldContents: fix typosMiklos Vajna1-3/+3
- The function name itself had a typo, spotted at <https://gerrit.libreoffice.org/c/core/+/145036/2#message-d8cb4de7de483866e0c86c8919cdf47f84b6037e>. - Also, if the # of provided fields and # of fields we find in the document don't match, we can give up, so no need to continue, the same condition would fail again, anyway. Change-Id: Ifbf7f60c86f469697056975752efc9d130287099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145083 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-01-05flatten some code in vclNoel Grandin4-507/+448
Change-Id: I29638408d60bfa02609ed58839829ed51d319e98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-05tdf#56973 - Copy/paste (single) sheet is checked but not enabledAndreas Heinisch3-1/+14
Enable the "copy" radio button in the move/copy sheet dialog, if there is just a single sheet in a spreadsheet document. Otherwise, users get the impression that a single sheet cannot be copied because the "copy" radio button is selected but not enabled, i.e., greyed out. Change-Id: Icf98973585491b0c8c9a74aad3900f6cc2895d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145064 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-25 21:23:00 +0000