diff options
| author | Sebastian Dröge <sebastian@centricular.com> | 2015-03-19 13:51:38 +0100 |
|---|---|---|
| committer | Sebastian Dröge <sebastian@centricular.com> | 2015-03-20 09:32:34 +0100 |
| commit | 6a6188a82f671032bf1c9ce3dd66310075cf4197 (patch) | |
| tree | 6a541ba94fd4f73b0d7db88ac62cdd5606844ccb | |
| parent | bc282da83cbc8147b7c0ed59e3bd5a6011e90eb2 (diff) | |
valve: Don't drop non-serialized queries when the valve is dropping
Otherwise we end up dropping e.g. CAPS queries, and then upstream just
negotiates to whatever format it wants to. Once the valve is not-dropping
anymore this can easily result in negotiation failing completely.
https://bugzilla.gnome.org/show_bug.cgi?id=746448
| -rw-r--r-- | plugins/elements/gstvalve.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/elements/gstvalve.c b/plugins/elements/gstvalve.c index 6a373537b..e4ef0a284 100644 --- a/plugins/elements/gstvalve.c +++ b/plugins/elements/gstvalve.c @@ -253,7 +253,7 @@ gst_valve_query (GstPad * pad, GstObject * parent, GstQuery * query) { GstValve *valve = GST_VALVE (parent); - if (g_atomic_int_get (&valve->drop)) + if (GST_QUERY_IS_SERIALIZED (query) && g_atomic_int_get (&valve->drop)) return FALSE; return gst_pad_query_default (pad, parent, query); |