From 6a6188a82f671032bf1c9ce3dd66310075cf4197 Mon Sep 17 00:00:00 2001 From: Sebastian Dröge Date: Thu, 19 Mar 2015 13:51:38 +0100 Subject: valve: Don't drop non-serialized queries when the valve is dropping Otherwise we end up dropping e.g. CAPS queries, and then upstream just negotiates to whatever format it wants to. Once the valve is not-dropping anymore this can easily result in negotiation failing completely. https://bugzilla.gnome.org/show_bug.cgi?id=746448 --- plugins/elements/gstvalve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/elements/gstvalve.c b/plugins/elements/gstvalve.c index 6a373537b..e4ef0a284 100644 --- a/plugins/elements/gstvalve.c +++ b/plugins/elements/gstvalve.c @@ -253,7 +253,7 @@ gst_valve_query (GstPad * pad, GstObject * parent, GstQuery * query) { GstValve *valve = GST_VALVE (parent); - if (g_atomic_int_get (&valve->drop)) + if (GST_QUERY_IS_SERIALIZED (query) && g_atomic_int_get (&valve->drop)) return FALSE; return gst_pad_query_default (pad, parent, query); -- cgit v1.2.3