Age | Commit message (Collapse) | Author | Files | Lines |
|
Use ovirt_get_option_group/ovirt_set_proxy_options instead as
ovirt_proxy_fetch_ca_certificate is not checking properly the
validity of https certificates.
https://bugzilla.gnome.org/show_bug.cgi?id=775412
|
|
|
|
|
|
|
|
WAIT UNTIL THIS IS PUBLICLY DOCUMENTED
|
|
|
|
There was already a --enable-tests/--disable-tests configure switch, but
Makefile.am was not making use of the conditional it sets.
|
|
This is not a GNU package and the Free Software Foundation has no copyright
over it. Also adds MSGID_BUGS_ADDRESS.
|
|
|
|
Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
According to the documentation, g_cancellable_disconnect() waits for the
signal handler to finish, and if it is called from the handler itself, it
will result in a deadlock. To avoid it, we check if the operation is
cancelled and if so, call g_signal_handler_disconnect() instead of
g_cancellable_disconnect().
https://developer.gnome.org/gio/stable/GCancellable.html#g-cancellable-disconnect
Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
Being an asynchronous operation, there is no guarantee that the object
is valid by the time of the cleanup, so we hold a reference to it to
ensure it.
Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
|
|
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=769286
|
|
|
|
Now that we have ovirt_proxy_add_header, we can use it in OvirtProxy
rather than direct modifications of the RestProxyCall object.
|
|
oVirt 4.0 introduced a slightly incompatible REST API, see
https://github.com/oVirt/ovirt-engine/tree/master/backend/manager/modules/restapi
A short term fix is to send a "Version: 3" header with each request,
which this commit does. This might stop working with oVirt 4.1 though.
Longer term fix is tracked in
https://bugzilla.gnome.org/show_bug.cgi?id=767724
|
|
commit d3683c2 "proxy: Only set 'Prefer: persistent-auth' with
jsession-id" was working as expected when using the
OvirtProxy::jsession-id and OvirtProxy::sso-token properties.
However, when not using these properties and expecting the jsessionid to
be set as a cookie during a regular HTTP session, this was not working
properly as oVirt is not sending a jsessionid cookie when Prefer:
persistent-auth is not set.
Consequently, we need to set it upon OvirtProxy creation in order not to
break this usecase. We don't add the header in RestProxyCall as was done
before as we want to be able to disable this addition after
OvirtProxy::sso-token has been set.
|
|
These new entry points are not exported in libgovirt.so, so they should
not appear in public (installed) headers.
|
|
Test the parsing of OvirtVmDisplay is working as expected
|
|
We need to have it in tarballs as this is used by our mock http server
|
|
Very few tests for now, but can easily be extended.
|
|
This is based off libsoup/examples/simple-httpd.c, but provides a simple
API that test cases can use to start/stop a mock webserver which will
send predefined responses to specific requests.
|
|
It's possible that these nodes are missing in test cases for example.
Since we don't control what the other end is going to send us, it's
better not to warn too loudly when this happens.
|
|
In some corner cases (unit tests...), we can have VM resources without
an associated display. In such cases, do not try to set the display CA
on the non-existent display.
|
|
When a collection contains 2 resources with the same name, we were
correctly releasing the memory associated with the colliding resource,
but not its name.
|
|
A ';' was used instead of ':'
|
|
When using an oauth SSO token, this header should not be set.
|
|
|
|
|
|
This is the new way of automatically authenticating during oVirt REST
communication.
https://bugzilla.redhat.com/show_bug.cgi?id=1286696
|
|
This API will be needed in order to set a custom Authorization: header
for authentication with oVirt. However this API can be internal only for
now.
|
|
|
|
OvirtProxy::api was already unref'ed a few lines before in
the same method.
This reverts commit dc19dcfbd3c0a45c7538b36b5b4ee5b77eab1623.
|
|
Tarballs are now available from gnome.org.
|
|
|
|
The current category is invalid and prevents modifications to the DOAP
file from being pushed, and I could not find a really appropriate
category in the valid categories.
|
|
This reverts commit 5c8f3c33e6ceb46d14a501dae9f03c40eb81ef49.
Being able to set a NULL CA certificate after setting a non-NULL one
would require some changes in libsoup. Since we are using a deprecated
libsoup property (ssl-ca-file), this is unlikely to go upstream at this
point, see https://bugzilla.gnome.org/show_bug.cgi?id=754825
As this also causes breakage with upstream libsoup (certificate check
failures when trying to connect to an oVirt instance), it's better to
revert this patch for now.
|
|
This is redundant with a similar log in
ovirt_rest_xml_node_get_content_va
|
|
|
|
When G_MESSAGES_DEBUG=libgovirt is set, the ticket value would be
printed to stdout. Since it's a short-lived password used to access the
VM display, it's better not to print it.
https://bugzilla.redhat.com/show_bug.cgi?id=1216118
|
|
|
|
|
|
The typo was causing crashes, see the gdb backtrace:
#0 g_type_check_instance_is_fundamentally_a (
type_instance=type_instance@entry=0x519b9e0,
fundamental_type=fundamental_type@entry=80) at ../../gobject/gtype.c:3981
#1 0x63c4a47b in g_object_unref (_object=0x519b9e0)
at ../../gobject/gobject.c:3067
#2 0x64842fb0 in ovirt_collection_refresh_from_xml (collection=0x50d4450,
root_node=<optimized out>, error=0x28fb8c)
at ../../govirt/ovirt-collection.c:276
#3 0x64843c49 in get_collection_xml_async_cb (proxy=0x3aebfd0,
call=0x50d28a0, user_data=0x29c2ce0, error=0x28fb8c)
at ../../govirt/ovirt-proxy.c:343
#4 0x64843bb2 in call_async_cb (call=0x50d28a0, error=0x0, weak_object=0x0,
user_data=0x50d8680) at ../../govirt/ovirt-proxy.c:248
#5 0x00023fa7 in ?? ()
from C:\Program Files (x86)\VirtViewer v2.0-80\bin\librest-0.7-0.dll
#6 0x051600e0 in ?? ()
Resolves: rhbz#1273977
|
|
|
|
|
|
|
|
|
|
The only purpose of our notify::ssl-ca-file handler is to cleanup the
temporary file we created when the ssl-ca-file is set externally. Now
that we have a separate ovirt_proxy_free_tmp_ca_file(), we can call that
rather than relying on ovirt_proxy_set_tmp_ca_file(proxy, NULL); to
achieve that.
|