Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixes fdo#65614
|
|
Without this, IDLE_TEST_VALGRIND doesn't work.
|
|
|
|
|
|
Don't let the TLS tests accept errors that wouldn't be accepted when
idle runs normally, instead implement minimal ServerTLSConnection in the
test which need it and add a minimal test for rejecting certificates.
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63810
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Among other effects, this makes GLIB_VERSION_MIN_REQUIRED effective.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63119
|
|
Since some time ago, Idle has used GIO's TLS stuff; we should have
dropped this back then.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
We don't want to risk some test timing out because it doesn't answer
PONGs, and having PINGs cluttering the debug log is not my cup of tea.
|
|
|
|
|
|
This fixes the issue where empathy-chat crashing means you get kicked
out of all your channels.
It's technically backwards-incompatible but empathy-chat has been using
RemoveMembers() to leave rooms for ages, and it's a pretty destructive
and annoying bug, so let's just get on with it.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=24614
|
|
|
|
Previously we'd just send out a PING into the æther every n seconds, and
pay no attention to whether we ever got an answer. So it was perfectly
possible for the connection to just sit there until the TCP timeout
kicks in, which I think is a matter of hours by default.
With this patch, if we haven't heard a PONG 3 keepalive-intervals after
sending a PING, Idle throws its toys out of the pram.
This has been tested as follows:
* Put my laptop on a wired and wireless network simultaneously.
* Connect to an IRC server. (The wired network is used.)
* Pull the network cable out. Idle is too stupid to realise the link it
was using is gone, and because we're still ostensibly online, nothing
tells it to disconnect.
* Wait keepalive-interval * 4, and watch the connection get
disconnected.
It works both with a direct connection to Freenode, and with a
connection over an SSH tunnel to irssi-proxy.
|
|
|
|
|
|
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=30741
|
|
|
|
Conflicts:
configure.ac
src/idle-muc-channel.c
|
|
I had misunderstood these two properties before, yet again. This is
better and easier. I added more tests.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
This is much better. I should have done this before. I also added some
tests to make sure bad args are rejected.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
I must admit I misunderstood what was going on with this earlier when
I removed it. I was just being an idiot. I've brought it back now and
it's even tested!
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Ignore the indentation; it's all wrong. I hate idle.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
This is really trivial, I'm happy to report.
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
The same as Gabble commit cbfa9d06.
|
|
This moves IdleRoomlistChannel over to TpBaseChannel and cleans up the
tests a little at the same time.
|
|
I hadn't really excercised the code for returning an existing roomlist channel
if we had already created one. So I added a test for it and in the process
discovered a bug, which is also fixed by this patch.
(The compiler found this bug when it was introduced while I was rebasing
Jonathon's branch, so I fixed it there and then. -Will)
|
|
Added IdleRoomlistManager and IdleRoomlistChannel classes. There is a basic
test included as well. Things seem to work ok (e.g. I can display a list of
channels in empathy), but it hasn't been extensively tested and I have made some
possibly questionable design decisions (e.g. only creating a single
RoomlistChannel rather than creating a new one every time one is requested). I
don't fully understand the implication of that choice yet, so I need to do some
more work to figure out whether that needs to be changed.
There seems to be a crash when closing down the channel that also needs to be
investigated.
|
|
This has always worked fine, but wasn't tested.
|
|
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48084
|
|
Oh yeah, the tests...
|
|
BIP doesn't start the trailing parameter with a : when it's only a
single word in various cases. For example when sending the topic. Adjust
our parser to accept trailing parameters not starting with : if it's the
final word in the string
|
|
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
|
|
This patch pulls the topic-tracking and -setting code out of the
Telepathy.Properties implementation, uses it to implement the Subject
interface, and stubs out the Telepathy.Properties implementation.
Because Subject uses DBus.Properties.PropertiesChanged, which clashes
with Telepathy.Properties.PropertiesChanged, we have to remove the
GInterface for Telepathy.Properties from the object.
The latter is not tested anywhere! So this gives us a commit that
compiles, runs and passes all the tests, without having to cut out all
the old code which we want to salvage for RoomConfig.
|
|
Unlike dataReceived, handleCommand splits the data if it has multiple
messages and parses each message.
|
|
|
|
If a message gets as far as _send_with_priority and contains \r or \n,
it's almost certainly not what the user anticipated. For instance,
before this fix, calling
RemoveMembers([self_handle], "bye\r\nJOIN #telepathy")
would cause the user to leave the channel with the message "bye", and
then accidentally join #telepathy.
Rather than trying to strip out \r and \n everywhere, this patch just
replaces them with spaces just before sending.
https://bugs.freedesktop.org/show_bug.cgi?id=34840
Reviewed-by: Debarshi Ray <rishi@gnu.org>
|
|
|
|
|
|
Idle interprets RFC 2813 very conservatively, and sends at most one
message every two seconds, rather than sending an *average* of one
message every two seconds.
I don't feel like implementing the latter right now, but I'm bored of
waiting forever for the test suite to pass. So here's a hack.
|
|
|
|
|