muc-channel: validate Password properties to simplify {,un}setting branch

This is much better. I should have done this before. I also added some
tests to make sure bad args are rejected.

Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>

1 files changed, 23 insertions, 0 deletions

diff --git a/tests/twisted/messages/room-config.py b/tests/twisted/messages/room-config.py
index d8e5bdf..e18687d 100644
--- a/tests/twisted/messages/room-config.py
+++ b/tests/twisted/messages/room-config.py
@@ -240,6 +240,29 @@ def test_password(q, bus, conn, stream):
                                      []])
                   )
 
+    # get rid of it
+    call_async(q, chan.RoomConfig1, 'UpdateConfiguration',
+               {'PasswordProtected': False})
+    q.expect('stream-MODE', data=['#test', '-k']),
+
+    # try some wacky values
+    call_async(q, chan.RoomConfig1, 'UpdateConfiguration',
+               {'PasswordProtected': True})
+    q.expect('dbus-error', method='UpdateConfiguration',
+             name=cs.INVALID_ARGUMENT)
+
+    call_async(q, chan.RoomConfig1, 'UpdateConfiguration',
+               {'PasswordProtected': True,
+                'Password': ''})
+    q.expect('dbus-error', method='UpdateConfiguration',
+             name=cs.INVALID_ARGUMENT)
+
+    call_async(q, chan.RoomConfig1, 'UpdateConfiguration',
+               {'PasswordProtected': False,
+                'Password': 'scumbagsteve'})
+    q.expect('dbus-error', method='UpdateConfiguration',
+             name=cs.INVALID_ARGUMENT)
+
 def test_modechanges(q, bus, conn, stream):
     chan = setup(q, bus, conn, stream)