| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
It is not available anymore in 1.0 and pad-added should be used.
|
|
This was previously added to check for a new enough playbin, but since we're now
using Gstreamer 1.0, the playbin version should be new enough, and we can drop
the conditionals.
Signed-off-by: Chow Loong Jin <hyperair@debian.org>
|
|
|
|
|
|
|
|
No change of behaviour in this commit.
|
|
Adding a new SchemaEntry<int> to PlayerInterface class that will store
the size of the SearchEntry widget.
Signed-off-by: Andres G. Aragoneses <knocte@gmail.com>
|
|
The method IncrementAddedTracks() was accessing the field add_track_job, which
would make Banshee crash with a NullReferenceException. By judging from the
stack trace that the user supplied, this was likely to happen only if the very
1st track being transferred through Dap had a transcoding error (otherwise the
code flow would access a method which initializes add_track_job if it is null).
By using the property AddTrackJob instead of the field add_track_job, we make
this method capable of initializing the field too in case it's reached the first
when Dap transfer happens.
|
|
An ArgumentNullException was raised when accessing the BytesUsed property
of MtpSource class, which can be easily avoided by checking for null first.
If mtp_device is null it means that its initialization has not succeded,
something which should be logged by the DeviceInitialize() method.
|
|
Update to the latest Hyena from git master, to bring in the underlying
fix for bgo#696520.
As a consequence, all values coming from a database column defined as
'INTEGER PRIMARY KEY' should now be stored in variables typed as 'long".
This is overkill for some cases, like PrimarySourceId, and brings some
slight increase in memory usage. But I think the benefits are worth it:
consistency in the codebase, no Convert.ToInt32 calls here and there,
and no strange bugs like bgo#696520.
|
|
Changed all capitalisation to British capitalisation.
Uncapitalised podcast whenever it was not inside <gui> tags.
|
|
Changed ui.page: Added <app> tags,<gui> tags, changed style.
Updated radio.page:Added <steps> tag and reflowed text.
Changed play-queue.page:Added <gui> tags to "Play Queue".
Changed style in remove-media section to a list.
Reflowed text.
Changed capitalisation to British capitalisation.
|
|
Changed ids of different pages to match with page names.
Hyphenated section ids.
Fixed minor typo in introduction.page
|
|
For some reason the HardwareManager could not get a GudevDevice
from the Volume.Drive in this case, which resulted in passing
null to UdevMetadataSource and causing a NullReferenceException,
which would make Banshee freeze.
Fix this by checking for null after calling GudevDeviceFromGioDrive.
|
|
|
|
Added screenshots of the main banshee window in
introduction.page and ui.page
Created a figures directory.
|
|
|
|
|
|
|
|
|
|
Due to UI not loading again after editing a station, the genres were
not being updated and therefore the list could contain genres that
don't exist anymore, or lack new genres being introduced.
Signed-off-by: Andres G. Aragoneses <knocte@gmail.com>
|
|
|
|
|
|
|
|
This only affects the MS.NET build because we still use Makefiles for Mono.
|
|
Turns out post-build.bat cannot be edited manually because it is a
generated file, so I'm adding some clarifications about this in the
README.txt file and on the file itself with a REM comment.
I've also auto-generated the file now, which has re-fixed the 2 issues I
fixed recently in it (but in a different way), and has added some copy
lines of more resources I wasn't aware of.
|
|
Even if the README tells you to install WiX, it could happen that you run
the javascript file from a command line shell that you had already open
before you installed WiX, in which case it would fail.
|
|
It wasn't clear if it was the wixproj (via MSBuild or VisualStudio) which
called the javascript file or the other way around.
|
|
The extension Banshee.AudioCD had been renamed (since DVD playback support
was implemented) to Banshee.OpticalDisc.
|
|
The extension Banshee.Dap.Ipod had been deprecated, and removed already,
some time ago, so this script was failing. We now use the paths of the
icons for the new extension Banshee.Dap.AppleDevice.
|
|
This way it is easier for someone to change the .bat file to point to
git's path in case it is not in their system's PATH.
|
|
|
|
BANSHEE_CHECK_GCONF sets the HAVE_DBUS_GLIB conditional, and is not
called if --disable-gnome is passed to configure. But conditionals must
always be set, so set it to false by default.
Signed-off-by: Bertrand Lorentz <bertrand.lorentz@gmail.com>
|
|
Added <app> tags around Banshee in help pages.
Changed the name of keyboardshortcuts.page to
keyboard-shortcuts.page
Updated banshee/Makefile.am
Changed <keySpacebar</key> to <key>Space</key>.
|
|
|
|
|
|
Signed-off-by: Andres G. Aragoneses <knocte@gmail.com>
|
|
|
|
|
|
|
|
Since this change[1] in DatabaseTrackInfo, PathPattern property may return
null instead of a default PathPattern. Even though RenameFile () was
already checking if the track belonged to the MusicLibrarySource, this
check for null, to return early, is faster, and safer (because in the
future someone could implement RenameFile operation in non-Music sources
and could forget to do this null check).
[1] https://git.gnome.org/browse/banshee/commit/?id=2c82ffbeaf4f4ff9f996b4dfaf1bfc84064353f5
|
|
|
|
When importing a playlist to the library, ignore any element whose URI
scheme is not file://. Local directories are still imported.
The importing process only handles the local path, so allowing remote
URLs would lead to bad things happening, like trying to import
everything under /...
Ignored elements are logged, but no feedback is provided in the UI.
|
|
|
|
GConf causes us to make indirect calls to libdbus from multiple threads,
resulting in crashes if threads are not initialized explictly. As a
workaround, we initialize dbus-glib for multithreading.
This fixes adds an optional build-time dependency on dbus-glib, and will
only be enabled if that dependency is satisfied.
Some distros have addressed this issue by patching the underlying
llibraries (gconf or gconf-sharp), so they don't have to enable that
fix. But it should not conflict with those patches, as
dbus_g_thread_init can be called multiple time, contrary to what the
API documentation says.
Signed-off-by: Bertrand Lorentz <bertrand.lorentz@gmail.com>
|
|
|
|
|
|
|
|
|
