summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Linhart <chris@demorecorder.com>2015-09-13 15:45:10 +0200
committerChristian Linhart <chris@demorecorder.com>2015-10-26 17:33:42 +0100
commitd1e79abb07b1bcde9540503ed268edded68185c6 (patch)
tree3f76c29ecbcc7e35c7d991378f17443898f5e435
parent4b780da25fffeb4c1c042f05d618e93407b2fe77 (diff)
render: make padding explicit
Add explicit align-padding for: * the request "SetPictureFilter": Added 4-byte align-pad between list "filter" and list "values" The spec does not show the padding: http://cgit.freedesktop.org/xorg/proto/renderproto/tree/renderproto.txt?id=renderproto-0.11.1#n721 But there has to be padding to make accesses to 32-bit values in list "values" aligned. The Xlib implementation at http://cgit.freedesktop.org/xorg/lib/libXrender/tree/src/Filter.c?id=libXrender-0.9.9#n160 correctly does the padding: The string "filter" is written with "Data" which does 4-byte padding at the end: http://cgit.freedesktop.org/xorg/lib/libX11/tree/include/X11/Xlibint.h?id=libX11-1.6.3#n535 http://cgit.freedesktop.org/xorg/lib/libX11/tree/src/xcb_io.c?id=libX11-1.6.3#n484 Signed-off-by: Christian Linhart <chris@demorecorder.com> Reviewed-by: Peter Harris <pharris@opentext.com>
-rw-r--r--src/render.xml1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/render.xml b/src/render.xml
index c54608e..935fdcc 100644
--- a/src/render.xml
+++ b/src/render.xml
@@ -607,6 +607,7 @@ for licensing information.
<list type="char" name="filter">
<fieldref>filter_len</fieldref>
</list>
+ <pad align="4" />
<list type="FIXED" name="values" />
</request>