From d1e79abb07b1bcde9540503ed268edded68185c6 Mon Sep 17 00:00:00 2001 From: Christian Linhart Date: Sun, 13 Sep 2015 15:45:10 +0200 Subject: render: make padding explicit Add explicit align-padding for: * the request "SetPictureFilter": Added 4-byte align-pad between list "filter" and list "values" The spec does not show the padding: http://cgit.freedesktop.org/xorg/proto/renderproto/tree/renderproto.txt?id=renderproto-0.11.1#n721 But there has to be padding to make accesses to 32-bit values in list "values" aligned. The Xlib implementation at http://cgit.freedesktop.org/xorg/lib/libXrender/tree/src/Filter.c?id=libXrender-0.9.9#n160 correctly does the padding: The string "filter" is written with "Data" which does 4-byte padding at the end: http://cgit.freedesktop.org/xorg/lib/libX11/tree/include/X11/Xlibint.h?id=libX11-1.6.3#n535 http://cgit.freedesktop.org/xorg/lib/libX11/tree/src/xcb_io.c?id=libX11-1.6.3#n484 Signed-off-by: Christian Linhart Reviewed-by: Peter Harris --- src/render.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/render.xml b/src/render.xml index c54608e..935fdcc 100644 --- a/src/render.xml +++ b/src/render.xml @@ -607,6 +607,7 @@ for licensing information. filter_len + -- cgit v1.2.3