Age | Commit message (Collapse) | Author | Files | Lines |
|
Avoid errors like:
/usr/bin/ld: xts5/src/lib/libxtest.a.p/startup.c.o:/xts5/src/lib/startup.c:168: multiple definition of `ErrdefGC'; xts5/src/lib/libxtest.a.p/ex_startup.c.o:/xts5/src/lib/ex_startup.c:140: first defined here
/usr/bin/ld: xts5/src/lib/libxtest.a.p/startup.c.o:/xts5/src/lib/startup.c:169: multiple definition of `ErrdefColormap'; xts5/src/lib/libxtest.a.p/ex_startup.c.o:/xts5/src/lib/ex_startup.c:141: first defined here
Part-of: <https://gitlab.freedesktop.org/xorg/test/xts/-/merge_requests/5>
|
|
Avoid errors like:
/usr/bin/ld: xts5/src/lib/libxtest.a.p/nextvinf.c.o:/xts5/src/lib/nextvinf.c:133: multiple definition of `Dsp'; xts5/src/lib/libxtest.a.p/ex_startup.c.o:/xts5/src/lib/ex_startup.c:135: first defined here
/usr/bin/ld: xts5/src/lib/libxtest.a.p/startup.c.o:/xts5/src/lib/startup.c:158: multiple definition of `Dsp'; xts5/src/lib/libxtest.a.p/ex_startup.c.o:/xts5/src/lib/ex_startup.c:135: first defined here
Part-of: <https://gitlab.freedesktop.org/xorg/test/xts/-/merge_requests/5>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
XInput.c:172:9: error: implicit declaration of function 'report' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
report("DISPLAY is not set. Cannot continue");
^
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
settimeout.c:154:3: error: implicit declaration of function 'delete' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
delete("Could not set signal handler in settimeout");
^
settimeout.c:154:3: note: did you mean 'undelete'?
/Library/Developer/CommandLineTools/SDKs/MacOSX13.2.sdk/usr/include/unistd.h:737:6: note: 'undelete' declared here
int undelete(const char *);
^
settimeout.c:175:3: error: implicit declaration of function 'delete' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
delete("Could not reset signal handler in cleartimeout");
^
2 errors generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
bitcount.c:192:2: error: implicit declaration of function 'debug' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
debug(1, "getpix: Pixel is %lx from %lx and %lx.", pix, m, p);
^
1 error generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
pfcount.c:128:2: error: implicit declaration of function 'trace' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
trace("passcount=%d, failcount=%d", passcount, failcount);
^
1 error generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
F
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
engineers on my team were born
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
`unifdef -D__STDC__` over the tree
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
|
|
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Currently the piglit xts integration assumes an in tree build, which
meson doesn't support by design. The better solution is to generate a
piglit xml profile as part of the xts build process, which we can point
piglit at.
|
|
This should be as complete as the autotools build system.
|
|
meson doesn't allow us to pass an environment variable, so we need
another method. I tried using a python wrapper, but that doesn't work
with a generator because there's no way to correctly describe the
dependency. Instead I've justed added a #define that we can se in
meson to get the behavior we want.
|
|
|
|
If an event from a non-grabbed client leaks through during the
GrabServer, we still need to close the display in order to UngrabServer
and allow the rest of the test suite to complete.
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
XSetFontPath/[124], when run from xserver's piglit test scripts, will
emit errors like this:
510|0|system 0, errno = 2 (ENOENT): could not open config file "/home/ajax/git/xts/xts5/tetexec.cfg"
15|0 3.3-lite 1|TCM Start
520|0 0 00014075 1 1|REPORT: Required parameter DISPLAY was not set
400|0 2 1 12:58:57|IC Start
200|0 2 12:58:57|TP Start
520|0 2 00014075 1 1|VSW5TESTSUITE PURPOSE 2
520|0 2 00014075 1 2|Assertion XSetFontPath-2.(A)
520|0 2 00014075 1 3|On a call to XSetFontPath, the directory search path for
520|0 2 00014075 1 4|font lookup is set for all clients.
520|0 2 00014075 1 5|METH: Open a second client.
520|0 2 00014075 1 6|METH: Set font path in first client.
520|0 2 00014075 1 7|METH: Get font path in the second client.
520|0 2 00014075 1 8|METH: Verify that the font is the same in each client.
520|0 2 00014075 1 9|REPORT: XT_FONTPATH_GOOD not set in config file
220|0 2 2 12:58:57|UNRESOLVED
410|0 2 1 12:58:57|IC End
Though xts looks for the default config file, it does not _build_ it
unless running 'make check' from xts itself. We don't want or need to
enforce that, so just build it by default.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
There is no reason to test all 481 (to pick the server I'm running at
the moment) visuals generated by GLX, when the visuals do not differ
from each other in any way tested by xts.
Reviewed-by: Adam Jackson <ajax@redhat.com>
|
|
Amongst examples:
XDisplayString/Test1.c:151:3: error: non-void function 'tet_main' should return
a value [-Wreturn-type]
return;
^
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
files.c:267:3: error: non-void function 'outfile' should return a value
[-Wreturn-type]
return;
^
v2: Correct declaration (Peter Hutterer)
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Regeneration is fast enough these days, we can skip this. This
eliminates about 40 minutes of wall time from a full xts run.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
|
|
XtSetSelectionTimeout.c: In function:
XtSetSelectionTimeout.c:90:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
sprintf(ebuf, "ERROR: Expected 5000 received %d", value_good);
^
XtSetSelectionTimeout.c:98:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
sprintf(ebuf, "ERROR: Expected 10000 received %d", value_good);
^
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
|
|
Scrollbar.c:282:21: error: non-void function 'FillArea' should return a value
[-Wreturn-type]
if (bottom < 0) return;
^
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
|
|
XtRemoveRawEventHandler.c:396:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Error message handler was invoked %d times");
^
XtRemoveRawEventHandler.c:401:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Warning message handler was invoked %d times");
^
XtRemoveRawEventHandler.c:478:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Error message handler was invoked %d times");
^
XtRemoveRawEventHandler.c:483:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Warning message handler was invoked %d times");
^
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
|
|
XtRemoveEventHandler.c:458:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Error message handler was invoked %d times");
^
XtRemoveEventHandler.c:463:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Warning message handler was invoked %d times");
^
XtRemoveEventHandler.c:540:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Error message handler was invoked %d times");
^
XtRemoveEventHandler.c:545:3: warning: format '%d' expects a matching 'int' argument [-Wformat=]
sprintf(ebuf, "ERROR: Warning message handler was invoked %d times");
^
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
|
|
XtGetKeysymTable.c:258:5: warning: format '%ld' expects a matching 'long int' argument [-Wformat=]
Reviewed-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
|
|
Box.c:245:7: error: non-void function 'DoLayout' should return a value
[-Wreturn-type]
return;
^
Box.c:285:6: error: non-void function 'DoLayout' should return a value
[-Wreturn-type]
return;
^
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
|
|
Reviewed-by: Adam Jackson <ajax@redhat.com>
|
|
Emacs was indenting badly in the previous change without it.
Reviewed-by: Adam Jackson <ajax@redhat.com>
|
|
One less environment variable the user needs to set to prevent
spurious failures.
v2: Actually amend in the fix to the directory that I failed to do
before sending out for review.
Reviewed-by: Adam Jackson <ajax@redhat.com> (v1)
|
|
On a system with many visuals, leaving the display connections open
until test cleanup can cause the test to fail when the server reaches
MAX_CLIENTS simultaneous connections.
Signed-off-by: Robert Morell <rmorell@nvidia.com>
Tested-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
|
|
If the server returns a bogus (short) reply to a swapped QueryFont
request, RcvRep swaps past the end of its buffer, smashing the heap.
Signed-off-by: Peter Harris <pharris@opentext.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
|
|
Found by -fsanitize=address
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
The perl mongers have retroactively marked this construct
"experimental", five and a half years after it was marked stable.
http://perldoc.perl.org/perl5180delta.html#The-smartmatch-family-of-features-are-now-experimental
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
XCloseDevice frees the device parameter, even if it references an
invalid device. Therefore, the device parameter must not be on the stack.
Since xts5/XI does not clean up the devices created by
Setup_Extension_DeviceInfo, it is safe to XCloseDevice "device".
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
XChangeFeedbackControl will SEGV if the last parameter is NULL.
Signed-off-by: Peter Harris <pharris@opentext.com>
|
|
Only XOpenDisplay pairs with XCloseDisplay. The Display pointer returned
by opendisplay is self-closing.
Signed-off-by: Peter Harris <pharris@opentext.com>
|