summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-04-04xdm 1.1.16HEADxdm-1.1.16masterAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-03-25Define _CONST_X_STRING when including Xaw & Xt headersAlan Coopersmith1-0/+1
Fixes build when building against libXaw 1.0.16 since xorg/lib/libxaw@d0fcbd97 changed the definition of XawListChange in <X11/Xaw/List.h> from _Xconst char * to String *, where String is defined as const if _CONST_X_STRING is defined. This also clears up 105 of the 162 -Wdiscarded-qualifiers warnings. Closes: #16 Fixes: bccb777 ("Fix -Wincompatible-pointer-types warning from gcc (issue #15)") Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-03-23xdm 1.1.15xdm-1.1.15Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11session.c: clear -Wredundant-decls warnings on SolarisAlan Coopersmith1-1/+1
Include standard headers for getpwnam() & crypt() instead of local prototype redefinitions. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef __osf__Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11include <shadow.h> on all platforms with HAVE_GETSPNAM set, not just SVR4Alan Coopersmith1-6/+1
Matches what we already do in greeter/verify.c Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11Remove support for SVR4 systems other than Solaris/illumosAlan Coopersmith4-84/+5
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef FRAGILE_DEV_MEMAlan Coopersmith1-8/+0
It was only defined in the old Imakefiles, and not in any autoconf config Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef UNRELIABLE_SIGNALSAlan Coopersmith1-12/+1
UNRELIABLE_SIGNALS was only defined if SYSV was defined Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef SIGNALS_RESET_WHEN_CAUGHTAlan Coopersmith2-11/+0
SIGNALS_RESET_WHEN_CAUGHT was only defined if SYSV was defined Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef SYSVAlan Coopersmith5-27/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef AF_DECnetAlan Coopersmith3-18/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef AF_CHAOSAlan Coopersmith2-12/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef QNX4Alan Coopersmith4-19/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef __UNIXOS2__Alan Coopersmith3-7/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef pegasusAlan Coopersmith1-3/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef hpuxAlan Coopersmith3-35/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef __convex__Alan Coopersmith2-8/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef PowerMAX_OSAlan Coopersmith1-3/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef sonyAlan Coopersmith1-11/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11unifdef ultrixAlan Coopersmith1-4/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-11Fix --with-systemd-daemon optionAlisson Bruno1-3/+4
2024-02-01greeter: Constify value argument to SetValue()Alan Coopersmith2-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-02-01greeter: Handle const qualification differences between Solaris & Linux PAMAlan Coopersmith1-16/+18
Solaris does not specify "const" on the first argument to PAM conversation functions, nor the third argument to pam_get_item(). Linux PAM does both. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-12-05Fix -Wincompatible-pointer-types warning from gcc (issue #15)Alan Coopersmith1-1/+1
chooser.c:280:26: warning: passing argument 2 of ‘XawListChange’ from incompatible pointer type [-Wincompatible-pointer-types] 280 | XawListChange (list, newTable, size, 0, TRUE); | ^~~~~~~~ | | | char ** In file included from chooser.c:59: /usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char **’ but argument is of type ‘char **’ 170 | _Xconst char **list, Closes: #15 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-12-02configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOLAlan Coopersmith1-3/+1
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008, so it's time to rely on it. Clears autoconf warnings: configure.ac:37: warning: The macro 'AC_LIBTOOL_DLOPEN' is obsolete. configure.ac:37: You should run autoupdate. m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from... configure.ac:37: the top level configure.ac:37: warning: AC_LIBTOOL_DLOPEN: Remove this warning and the call to _LT_SET_OPTION when you configure.ac:37: put the 'dlopen' option into LT_INIT's first parameter. ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from... m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from... configure.ac:37: the top level configure.ac:38: warning: The macro 'AC_PROG_LIBTOOL' is obsolete. configure.ac:38: You should run autoupdate. m4/libtool.m4:100: AC_PROG_LIBTOOL is expanded from... configure.ac:38: the top level Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-10-13gitlab CI: Update to latest CI templates & Debian stable releaseAlan Coopersmith1-3/+9
Current template fails to rebuild the CI container with the current Debian stable release (a new release since the last update) Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-25Remove "All rights reserved" from Oracle copyright noticesAlan Coopersmith8-8/+8
Oracle no longer includes this term in our copyright & license notices. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-02-09gitlab CI: stop requiring Signed-off-by in commitsAlan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-12-03xdm 1.1.14xdm-1.1.14Alan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-05Only link with libbsd if needed for arc4random() or setproctitle()Alan Coopersmith1-11/+26
Avoid unnecessary library dependency when using a libc with these functions included. Also only links to the binary that needs them (xdm, not chooser or greeter) Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-06Switch from libbsd to libbsd-overlayGuillem Jover4-26/+11
This is the preferred usage form for libbsd, as it makes the code more portable and requires no special includes for libbsd, by transparently injects the needed standard headers that would be used on a BSD. Signed-off-by: Guillem Jover <guillem@hadrons.org>
2022-09-11genauth: fix build with arc4random in glibc 2.36Callum Farmer1-1/+9
HAVE_ARC4RANDOM is defined under glibc 2.36 but this will attempt to include <bsd/stdlib.h> from libbsd instead of <stdlib.h> from glibc Signed-off-by: Callum Farmer <gmbr3@opensuse.org>
2022-04-30chooser: avoid free of uninitialized pointer in allocation failure cleanupAlan Coopersmith1-2/+1
Resolves issue found by Oracle Parfait static analyzer: Error: Uninitialised memory Uninitialised memory [uninitialised-mem] (CWE 456): Possible access to uninitialised memory referenced by 'new->fullname' Memory 'new->fullname' accessed at byte offset '8' at line 357 of app/xdm/chooser/chooser.c in function 'AddHostname'. Write does not overlap at line 355 new allocated at line 329 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-10Use memcpy() instead of memmove() when buffers are known not to overlapAlan Coopersmith13-42/+43
Most of these came from a mass bcopy() -> memmove() substitution in 1993 with a commit comment of "ANSIfied for R6". Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-10all_query_respond(): handle ConvertAddr failure soonerAlan Coopersmith1-2/+4
Don't try to process returned data values that may not be set Resolves Oracle Parfait issue: Error: Uninitialised memory Uninitialised memory variable [uninitialised-mem-var] (CWE 457): Possible access to uninitialised memory referenced by variable 'length' at line 238 of xdm/xdmcp.c in function 'all_query_respond'. Path in callee avoiding write at line 237 length allocated at line 231 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-10GetChooserAddr(): verify socket address fit in provided bufferAlan Coopersmith1-0/+2
Should never happen, but makes Oracle Parfait stop warning: Error: Buffer overrun Read Outside Array Bounds in STD C function [read-outside-array-bounds-call-stdc]: Read outside array bounds in call to memmove. Buffer ((int8*)&in_addr) of size 256 is read at an offset of len Array size is 256 bytes, index <= 1024 at line 130 of xdm/socket.c in function 'GetChooserAddr'. called at line 197 of xdm/choose.c in function 'FormatChooserArgument' with lenp = &addr_len. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-10configure.ac: Add option to disable XineramaMatt Turner1-2/+8
Bug: https://bugs.gentoo.org/384371 Signed-off-by: Matt Turner <mattst88@gmail.com>
2022-04-03xdm 1.1.13xdm-1.1.13Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-04Build xz tarballs instead of bzip2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-04gitlab CI: add a basic build testAlan Coopersmith1-0/+98
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-11-01doneAddrs: reset addrs to NULL after freeing listAlan Coopersmith1-0/+1
Resolves warning from Oracle Parfait static analyzer: Warning: Dangling pointer Dangling pointer [dangling-pointer]: Invalid pointer is accessible to caller via global addrs at line 664 of xdm/auth.c in function 'doneAddrs'. Invalid pointer accessible via global addrs at line 646 a accessed from addrs at line 658 in function 'doneAddrs' a freed with free at line 662 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-11-01Greeter: add parens to DRAW_STRING & TEXT_WIDTH macros for safetyAlan Coopersmith1-2/+2
Oracle Parfait static analyser points out it wasn't clear if cast or arithmetic operation in arguments at lines 410, 416, 431, & 433 was intended to be done first, so we'll make it explicit. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-10-31configure.ac: Link with libsystemd, not libsystemd-daemonMatt Turner1-3/+3
libsystemd-daemon was merged into libsystemd in 2014, for systemd-209. Fixes: https://gitlab.freedesktop.org/xorg/app/xdm/-/issues/9 Signed-off-by: Matt Turner <mattst88@gmail.com>
2020-07-21Fix spelling/wording issuesAlan Coopersmith10-14/+14
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-03-02xdm 1.1.12xdm-1.1.12Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-02-25Use sed instead of the C pre-processor to generate config filesAlan Coopersmith8-64/+46
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93359 while avoiding https://bugs.freedesktop.org/show_bug.cgi?id=107368 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-02-17fix length format in StartClient() debug messageDavid Carlier1-1/+1
changing the printf-like format as strlen returns an unsigned type Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-02-17fix memory leak in StorePid()David Carlier1-0/+1
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2019-01-01xdm uses setproctitle without proper includes for Linux libbsdChí-Thanh Christopher Nguyễn2-0/+17
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-14 18:35:36 +0000