diff options
| author | Alan Coopersmith <alan.coopersmith@oracle.com> | 2022-04-10 11:33:38 -0700 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2022-04-10 20:02:51 +0000 |
| commit | f01b28cf76d641881fa1c5bf7f9dd2487b9ced6b (patch) | |
| tree | 9a1d2c3b684720400e59c0bb9f457be9ee0b14f2 | |
| parent | 00e0b3ae11bb1d4681b0206c341f57fc46ea98b1 (diff) | |
all_query_respond(): handle ConvertAddr failure sooner
Don't try to process returned data values that may not be set
Resolves Oracle Parfait issue:
Error: Uninitialised memory
Uninitialised memory variable [uninitialised-mem-var] (CWE 457):
Possible access to uninitialised memory referenced by variable 'length'
at line 238 of xdm/xdmcp.c in function 'all_query_respond'.
Path in callee avoiding write at line 237
length allocated at line 231
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
| -rw-r--r-- | xdm/xdmcp.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xdm/xdmcp.c b/xdm/xdmcp.c index 9f2bc41..ddf2418 100644 --- a/xdm/xdmcp.c +++ b/xdm/xdmcp.c @@ -235,6 +235,10 @@ all_query_respond ( # endif family = ConvertAddr((XdmcpNetaddr) from, &length, (char **)&(addr.data)); + if (family < 0) { + Debug("all_query_respond: ConvertAddr failed: conntype=%d\n", family); + return; + } addr.length = length; /* convert int to short */ if (debugLevel > 0) { # if defined(IPv6) && defined(AF_INET6) @@ -254,8 +258,6 @@ all_query_respond ( Debug("all_query_respond: conntype=%d, addr=%s, len=%d\n", family, addrstring, addr.length); } - if (family < 0) - return; connectionType = family; if (type == INDIRECT_QUERY) |