diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2021-10-06 22:03:55 +0200 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2021-10-12 20:16:00 +0000 |
| commit | c3c72773646c84e2eca831edda7cb5621ee04f70 (patch) | |
| tree | b711b0ce91404f8b15ac9fa850385053ae596bd2 | |
| parent | 91adfb1a3f2630c141de81034b5b8e8a5cf49a8a (diff) | |
ms-basic-connect-extensions-v3: don't reimplement commands if they didn't change
If a given command didn't change in the new version update of the
service, skip creating methods to handle it, just use the ones from
the original version.
| -rw-r--r-- | data/mbim-service-ms-basic-connect-extensions-v3.json | 2 | ||||
| -rw-r--r-- | src/mbimcli/mbimcli-ms-basic-connect-extensions.c | 10 |
2 files changed, 3 insertions, 9 deletions
diff --git a/data/mbim-service-ms-basic-connect-extensions-v3.json b/data/mbim-service-ms-basic-connect-extensions-v3.json index b24f154..85b53d6 100644 --- a/data/mbim-service-ms-basic-connect-extensions-v3.json +++ b/data/mbim-service-ms-basic-connect-extensions-v3.json @@ -9,7 +9,7 @@ { "name" : "Lte Attach Info", "type" : "Command", "since" : "1.28", - "query" : [], + // query same as in v1 "response" : [ { "name" : "LteAttachState", "format" : "guint32", "public-format" : "MbimLteAttachState" }, diff --git a/src/mbimcli/mbimcli-ms-basic-connect-extensions.c b/src/mbimcli/mbimcli-ms-basic-connect-extensions.c index 9bc3518..515d71c 100644 --- a/src/mbimcli/mbimcli-ms-basic-connect-extensions.c +++ b/src/mbimcli/mbimcli-ms-basic-connect-extensions.c @@ -1364,14 +1364,8 @@ mbimcli_ms_basic_connect_extensions_run (MbimDevice *device, } if (query_lte_attach_status_flag || query_lte_attach_info_flag) { - if (mbim_device_check_ms_mbimex_version (device, 3, 0)) { - g_debug ("Asynchronously querying v3.0 LTE attach info..."); - request = mbim_message_ms_basic_connect_extensions_v3_lte_attach_info_query_new (NULL); - } - else { - g_debug ("Asynchronously querying v1.0 LTE attach info..."); - request = mbim_message_ms_basic_connect_extensions_lte_attach_info_query_new (NULL); - } + g_debug ("Asynchronously querying LTE attach info..."); + request = mbim_message_ms_basic_connect_extensions_lte_attach_info_query_new (NULL); mbim_device_command (ctx->device, request, 10, |