diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2021-10-06 21:58:54 +0200 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2021-10-12 20:16:00 +0000 |
| commit | 91adfb1a3f2630c141de81034b5b8e8a5cf49a8a (patch) | |
| tree | 1266248951509b2676d66fe87cd4fb41f01205fa | |
| parent | 45523caf4fc3b838a6ec6615e3c8e26918b1b3a4 (diff) | |
ms-basic-connect-v3: don't reimplement commands if they didn't change
If a given command didn't change in the new version update of the
service, skip creating methods to handle it, just use the ones from
the original version.
| -rw-r--r-- | data/mbim-service-ms-basic-connect-v3.json | 2 | ||||
| -rw-r--r-- | src/mbimcli/mbimcli-basic-connect.c | 7 |
2 files changed, 2 insertions, 7 deletions
diff --git a/data/mbim-service-ms-basic-connect-v3.json b/data/mbim-service-ms-basic-connect-v3.json index 1524716..8fb3417 100644 --- a/data/mbim-service-ms-basic-connect-v3.json +++ b/data/mbim-service-ms-basic-connect-v3.json @@ -10,7 +10,7 @@ { "name" : "Subscriber Ready Status", "type" : "Command", "since" : "1.28", - "query" : [], + // query same as in v1 "response" : [ { "name" : "ReadyState", "format" : "guint32", "public-format" : "MbimSubscriberReadyState" }, diff --git a/src/mbimcli/mbimcli-basic-connect.c b/src/mbimcli/mbimcli-basic-connect.c index 8a9cc20..88f8e35 100644 --- a/src/mbimcli/mbimcli-basic-connect.c +++ b/src/mbimcli/mbimcli-basic-connect.c @@ -1799,12 +1799,7 @@ mbimcli_basic_connect_run (MbimDevice *device, /* Request to get subscriber ready status? */ if (query_subscriber_ready_status_flag) { g_debug ("Asynchronously querying subscriber ready status..."); - - if (mbim_device_check_ms_mbimex_version (device, 3, 0)) - request = mbim_message_ms_basic_connect_v3_subscriber_ready_status_query_new (NULL); - else - request = (mbim_message_subscriber_ready_status_query_new (NULL)); - + request = (mbim_message_subscriber_ready_status_query_new (NULL)); mbim_device_command (ctx->device, request, 10, |