summaryrefslogtreecommitdiff
path: root/Xi
diff options
context:
space:
mode:
authorPeter Hutterer <peter.hutterer@who-t.net>2012-09-28 11:49:29 +1000
committerPeter Hutterer <peter.hutterer@who-t.net>2012-10-04 13:24:43 +1000
commit9d6b8365702e4648e793fea21ad22f7174558680 (patch)
tree3b87a66c2a65421c90a1be8c08a14697b7e6063e /Xi
parent0b02150c27e98f996e10d7489f9f67a30e4e3497 (diff)
dix: fix crash on XI 1.x grabs on disabled devices. (#54934)
If the device is disabled, the sprite window is NULL and dereferencing crashes the server. This is only triggered for XI 1.x grabs (ProcXGrabDevice) as XI2 grabs would trigger another code path, creating a sprite for the disabled device as if detaching it (which is wrong and fixed with this patch too). Grabbing a disabled device doesn't make sense as it won't send events anyway. However, the protocol specs do not prohibit it, so we need to keep it working. Luckily, oldWin is only used for focus out events, which aren't necessary given that the device is disabled. X.Org Bug 54934 <http://bugs.freedesktop.org/show_bug.cgi?id=54934> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Chase Douglas <chase.douglas@ubuntu.com>
Diffstat (limited to 'Xi')
0 files changed, 0 insertions, 0 deletions