node: improve async handlingasync

Remove the done and error callbacks. The error callback is in an
error message. The done callback is replace with spa_pending.

Make enum_params take a callback and data for the results. This allows
us to push the results one after another to the app and avoids ownership
issues of the passed data. We can then extend this to handle the async
case by doing a _wait call with a spa_pending+callback+data that will
be called when the _enum_params returns and async result.
Add a sync method.

All methods can now return SPA_RESULT_IS_ASYNC return values and you
can use spa_node_wait() to register a callback when they complete
with optional extra parameters. This makes it easier to sync and
handle the reply.

Make helper methods to simulate the sync enum_params behaviour for
sync nodes.

Let the transport generate the sequence number for pw_resource_sync()
and pw_proxy_sync(). That way we don't need to keep track of numbers
ourselves and we can match the reply to the request easily.

1 files changed, 9 insertions, 8 deletions

diff --git a/spa/tools/spa-inspect.c b/spa/tools/spa-inspect.c
index 092de015..7dc7aace 100644
--- a/spa/tools/spa-inspect.c
+++ b/spa/tools/spa-inspect.c
@@ -32,6 +32,7 @@
 #include <spa/support/log-impl.h>
 #include <spa/support/loop.h>
 #include <spa/node/node.h>
+#include <spa/node/utils.h>
 #include <spa/pod/parser.h>
 #include <spa/param/param.h>
 #include <spa/param/format.h>
@@ -63,9 +64,9 @@ inspect_node_params(struct data *data, struct spa_node *node)
 		uint32_t id;
 
 		spa_pod_builder_init(&b, buffer, sizeof(buffer));
-		if ((res = spa_node_enum_params(node,
+		if ((res = spa_node_enum_params_sync(node,
 						SPA_PARAM_List, &idx1,
-						NULL, &param, &b)) <= 0) {
+						NULL, &param, &b)) != 1) {
 			if (res != 0)
 				error(0, -res, "enum_params");
 			break;
@@ -78,9 +79,9 @@ inspect_node_params(struct data *data, struct spa_node *node)
 		printf("enumerating: %s:\n", spa_debug_type_find_name(spa_type_param, id));
 		for (idx2 = 0;;) {
 			spa_pod_builder_init(&b, buffer, sizeof(buffer));
-			if ((res = spa_node_enum_params(node,
+			if ((res = spa_node_enum_params_sync(node,
 							id, &idx2,
-							NULL, &param, &b)) <= 0) {
+							NULL, &param, &b)) != 1) {
 				if (res != 0)
 					error(0, -res, "enum_params %d", id);
 				break;
@@ -104,10 +105,10 @@ inspect_port_params(struct data *data, struct spa_node *node,
 		uint32_t id;
 
 		spa_pod_builder_init(&b, buffer, sizeof(buffer));
-		if ((res = spa_node_port_enum_params(node,
+		if ((res = spa_node_port_enum_params_sync(node,
 						     direction, port_id,
 						     SPA_PARAM_List, &idx1,
-						     NULL, &param, &b)) <= 0) {
+						     NULL, &param, &b)) != 1) {
 			if (res != 0)
 				error(0, -res, "port_enum_params");
 			break;
@@ -119,10 +120,10 @@ inspect_port_params(struct data *data, struct spa_node *node,
 		printf("enumerating: %s:\n", spa_debug_type_find_name(spa_type_param, id));
 		for (idx2 = 0;;) {
 			spa_pod_builder_init(&b, buffer, sizeof(buffer));
-			if ((res = spa_node_port_enum_params(node,
+			if ((res = spa_node_port_enum_params_sync(node,
 							     direction, port_id,
 							     id, &idx2,
-							     NULL, &param, &b)) <= 0) {
+							     NULL, &param, &b)) != 1) {
 				if (res != 0)
 					error(0, -res, "port_enum_params");
 				break;