diff options
| author | Jan Schmidt <thaytan@mad.scientist.com> | 2007-03-21 17:50:46 +0000 |
|---|---|---|
| committer | Jan Schmidt <thaytan@mad.scientist.com> | 2007-03-21 17:50:46 +0000 |
| commit | 8e36ce0940cc9bc18d30db16504f30c32158803c (patch) | |
| tree | 1bdcea1eca672105c3a0a23489040c5dffa4eb1f /libs | |
| parent | 9f3b0b8f3aa4e983db5962423ada7945b4f59a35 (diff) | |
libs/gst/base/gstbasesrc.c: Clarify FIXME comment in the face of having added unlock_stop()
Original commit message from CVS:
* libs/gst/base/gstbasesrc.c:
Clarify FIXME comment in the face of having added unlock_stop()
Diffstat (limited to 'libs')
| -rw-r--r-- | libs/gst/base/gstbasesrc.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/libs/gst/base/gstbasesrc.c b/libs/gst/base/gstbasesrc.c index f090a1467..cbb0d073f 100644 --- a/libs/gst/base/gstbasesrc.c +++ b/libs/gst/base/gstbasesrc.c @@ -851,9 +851,12 @@ gst_base_src_do_seek (GstBaseSrc * src, GstSegment * segment) * when we reach the segment.stop we have to post a segment.done * instead of EOS when doing a segment seek. */ -/* FIXME, we have the unlock gboolean here because most current implementations - * (fdsrc, -base/gst/tcp/, ...) not only unlock when there is something to - * unlock +/* FIXME (0.11), we have the unlock gboolean here because most current + * implementations (fdsrc, -base/gst/tcp/, ...) unconditionally unlock, even when + * the streaming thread isn't running, resulting in bogus unlocks later when it + * starts. This is fixed by adding unlock_stop, but we should still avoid unlocking + * unnecessarily for backwards compatibility. Ergo, the unlock variable stays + * until 0.11 */ static gboolean gst_base_src_perform_seek (GstBaseSrc * src, GstEvent * event, gboolean unlock) |