Age | Commit message (Collapse) | Author | Files | Lines |
|
... instead of relying on the segment. For the clipping at the start we assume
a proper value in the OpusHead, as generated by opusparse or opusenc.
Transmuxing in general is not guaranteed to produce the correct values, or
even have a OpusHead (e.g. when having RTP input).
https://bugzilla.gnome.org/show_bug.cgi?id=757153
|
|
|
|
|
|
oggmux keeps a cached buffer per pad, and pulls buffers from
collectpads to this cached buffer for all pads before processing
the best pad. In some cases, the move from collectpads buffer
to cached buffer is delayed till next call. However, when there
is only one pad, this can't be delayed till next call as there
will be a deadlock since collectpads has no other pad to push to.
https://bugzilla.gnome.org/show_bug.cgi?id=740565
|
|
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=740422
|
|
|
|
|
|
It might happen that the timestamp is before the segment and the
check would succeed. In this case reducing the duration makes no
sense and would lead to broken results.
|
|
TRUE is 1, but every other non-zero value is also considered true. Comparing
for equality with TRUE would only consider 1 but not the others.
|
|
Samples may be clipped at the end, and this is conveyed by a
granulepos that's smaller than it would otherwise be. Use the
segment stop time to detect this, and calculate the right
granulepos.
|
|
If gst_ogg_mux_queue_pads returns NULL it means we are at EOS, because we get a
NULL buffer and this function never sets bestpad.
https://bugzilla.gnome.org/show_bug.cgi?id=729315
|
|
They are very confusing for people, and more often than not
also just not very accurate. Seeing 'last reviewed: 2005' in
your docs is not very confidence-inspiring. Let's just remove
those comments.
|
|
They might've been inited before, in which case we leak
memory when initing them again without clearing.
|
|
It should really not happen unless the tag list it corrupt,
but the API returns a failure code so we may as well use it.
Coverity 1139595
|
|
Add an extra function to the oggstream map to inform it about
the incoming buffers. This way oggmux can keep a count on the
vp8 invisible frames and calculate the granulepos correctly.
https://bugzilla.gnome.org/show_bug.cgi?id=722682
|
|
vp8 stream header shouldn't be assumed to be provided in caps always
as this would repeat the same code in all demuxers/encoders. Instead,
make oggmux generate them if they are not supplied.
https://bugzilla.gnome.org/show_bug.cgi?id=722682
|
|
Reset all internal status when collect pads forwards a flush-stop
from the pads to be able to start the stream again.
|
|
|
|
|
|
event
Even if the srcpad is not linked at this point, it might be linked as result of
setting the caps.
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=699971
|
|
The problem experienced is that the EOS was never emitted by oggmux during a
rendering with GES. The proposed patch checks if the pad is EOS before deciding
it's the "best pad".
https://bugzilla.gnome.org/show_bug.cgi?id=699792
|
|
Use data->pad instead of pad for 'object'. Reduce indentation depth in a helper
with an early return.
|
|
Also move down the ref for the caps a bit, so tha we don't leak it in the branch that calls continue.
|
|
Also avoid unused variables if debugging is disabled.
|
|
No need to copy buffers we put into the streamheader any more
now that we don't put caps on buffers any more, so there's no
danger of a refcount cycle.
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=687520
|
|
|
|
|
|
|
|
|
|
Rename gst_collect_pads_add_pad_full() to gst_collect_pads_add_pad() and fix all
invocations.
|
|
|
|
|
|
|
|
video/non-video
Pick delta pad earlier during header parsing, and pick it based
on whether it's a video stream or not rather than some rather
byzantine signalling from theoraenc etc. which would set the delta
flag on header packets which oggmux would then pick up and determine
that this is a "delta-able" stream.
Since the new videodecoder-based theoraenc didn't do that any more,
we would only see the first delta flag on the second video packet,
which is after we've already muxed a few audio packets flagged as
key units, which trips up the unit test.
Fixes pipelines/oggmux unit test.
https://bugzilla.gnome.org/show_bug.cgi?id=679958
|
|
|
|
Don't drop all seek events. It is okay to seek before we send the headers. Non
flushing seeks are okay at any time later as well.
|
|
|
|
... rather than (old) hacked overriding.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Conflicts:
ext/theora/gsttheoraenc.c
gst-libs/gst/tag/gstexiftag.c
gst/adder/gstadder.c
gst/adder/gstadder.h
gst/playback/gstdecodebin2.c
gst/playback/gstsubtitleoverlay.c
tests/check/libs/tag.c
|
|
Pads are initialized twice: when requesting pads and when
initializing collectpads. Avoid double initialization by
checking if collectpads are still going to be initialized when
creating request pads.
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=662664
|