diff options
| author | Kristian Høgsberg <krh@localhost.localdomain> | 2011-07-19 10:01:46 -0700 |
|---|---|---|
| committer | Kristian Høgsberg <krh@localhost.localdomain> | 2011-07-19 10:01:46 -0700 |
| commit | 64732b01e4e9720eaef181c631d94a509a73dc65 (patch) | |
| tree | 1792fe0d872fd78519784ded881f5f9318df92de | |
| parent | f9b3c151459c1627ea971d6539f706e868b89ef4 (diff) | |
connection: Use static strings instead of sprintf and buffer overflow
Spotted by Samuel Rødal <samuel.rodal@nokia.com>
| -rw-r--r-- | wayland/connection.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/wayland/connection.c b/wayland/connection.c index af9a90e..467a2d0 100644 --- a/wayland/connection.c +++ b/wayland/connection.c @@ -692,20 +692,16 @@ void wl_closure_print(struct wl_closure *closure, struct wl_object *target, int send) { union wl_value *value; - char buffer[4] = "\0"; int i; struct timespec tp; unsigned int time; - if (send) - sprintf(buffer, " -> "); - clock_gettime(CLOCK_REALTIME, &tp); time = (tp.tv_sec * 1000000L) + (tp.tv_nsec / 1000); fprintf(stderr, "[%10.3f] %s%s@%d.%s(", time / 1000.0, - buffer, + send ? " -> " : "", target->interface->name, target->id, closure->message->name); |