diff options
| author | Elad Alfassa <elad@fedoraproject.org> | 2015-01-25 23:16:22 +0200 |
|---|---|---|
| committer | Bastien Nocera <hadess@hadess.net> | 2015-01-27 18:56:23 +0100 |
| commit | 9c8a956f65232bfef9f60acc0fd13ce238eeb1bc (patch) | |
| tree | 885534010b6d09f89b7c560407fa81001afc4d3b | |
| parent | 37813e376a440190d8cdc668d10e1bd3efb1bab0 (diff) | |
vimeo: Use HTTPS rather than insecure HTTP
To avoid leaking (potentially uniquely identifiable) user data over
plain text (be it search phrases, hashes of contact emails, etc etc),
use HTTPS whenever possible.
https://bugzilla.gnome.org/show_bug.cgi?id=743449
| -rw-r--r-- | src/vimeo/grl-vimeo.c | 2 | ||||
| -rw-r--r-- | src/vimeo/gvimeo.c | 2 | ||||
| -rw-r--r-- | tests/vimeo/data/network-data.ini | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/src/vimeo/grl-vimeo.c b/src/vimeo/grl-vimeo.c index 76b24e2..7a2c862 100644 --- a/src/vimeo/grl-vimeo.c +++ b/src/vimeo/grl-vimeo.c @@ -281,7 +281,7 @@ update_media (GrlMedia *media, GHashTable *video) char *external_url; grl_media_set_id (media, str); - external_url = g_strdup_printf ("http://vimeo.com/%s", str); + external_url = g_strdup_printf ("https://vimeo.com/%s", str); grl_media_set_external_url (media, external_url); g_free (external_url); } diff --git a/src/vimeo/gvimeo.c b/src/vimeo/gvimeo.c index 9762f3f..066dfb4 100644 --- a/src/vimeo/gvimeo.c +++ b/src/vimeo/gvimeo.c @@ -38,7 +38,7 @@ #define PLUGIN_USER_AGENT "Grilo Vimeo Plugin" -#define VIMEO_HOST "http://vimeo.com" +#define VIMEO_HOST "https://vimeo.com" #define VIMEO_ENDPOINT VIMEO_HOST "/api/rest/v2" #define VIMEO_VIDEO_LOAD_URL VIMEO_HOST "/moogaloop/load/clip:" #define VIMEO_VIDEO_PLAY_URL VIMEO_HOST "/moogaloop/play/clip:" diff --git a/tests/vimeo/data/network-data.ini b/tests/vimeo/data/network-data.ini index 662a387..0fffc9b 100644 --- a/tests/vimeo/data/network-data.ini +++ b/tests/vimeo/data/network-data.ini @@ -2,8 +2,8 @@ version=1 ignored-parameters=oauth_nonce;oauth_timestamp;oauth_signature_method;oauth_signature -[http://vimeo.com/api/rest/v2?full_response=yes&method=vimeo.videos.search&oauth_consumer_key=TEST_VIMEO_KEY&oauth_token=&page=1&per_page=2&query=gnome] +[https://vimeo.com/api/rest/v2?full_response=yes&method=vimeo.videos.search&oauth_consumer_key=TEST_VIMEO_KEY&oauth_token=&page=1&per_page=2&query=gnome] data=results.data -[http://vimeo.com/api/rest/v2?full_response=yes&method=vimeo.videos.search&oauth_consumer_key=TEST_VIMEO_KEY&oauth_token=&page=1&per_page=2&query=invalidfoo] +[https://vimeo.com/api/rest/v2?full_response=yes&method=vimeo.videos.search&oauth_consumer_key=TEST_VIMEO_KEY&oauth_token=&page=1&per_page=2&query=invalidfoo] data=empty.data |