diff options
| author | Vinson Lee <vlee@freedesktop.org> | 2016-09-01 07:10:22 +0000 |
|---|---|---|
| committer | Serge Martin <edb+piglit@sigluy.net> | 2016-09-10 15:23:59 +0200 |
| commit | 70ebdc07bc43180dfb0af504986e23ad8065c5bf (patch) | |
| tree | 140c9f94fe246d6ba61fdfd3fc3bd552b6485578 /tests/util/piglit-util-cl.c | |
| parent | 531b4a7c452630d10a88dabb7ea11ed9a7aacec3 (diff) | |
cl: Initialize errNo on invalid image type (v2).
Fixes sometimes-uninitialized warning.
piglit-util-cl.c:1052:13: warning: variable 'errNo' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (desc->image_type == CL_MEM_OBJECT_IMAGE3D) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
piglit-util-cl.c:1062:28: note: uninitialized use occurs here
if(!piglit_cl_check_error(errNo, CL_SUCCESS)) {
^~~~~
piglit-util-cl.c:1052:9: note: remove the 'if' if its condition is always true
} else if (desc->image_type == CL_MEM_OBJECT_IMAGE3D) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
piglit-util-cl.c:1040:14: note: initialize the variable 'errNo' to silence this warning
cl_int errNo;
^
= 0
Fixes: 910cd6c222930 ("cl: add image and sampler utility functions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Acked-by: Jan Vesely <jan.vesely@rutgers.edu>
Reviewed-by: Serge Martin <edb+piglit@sigluy.net>
Diffstat (limited to 'tests/util/piglit-util-cl.c')
| -rw-r--r-- | tests/util/piglit-util-cl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/util/piglit-util-cl.c b/tests/util/piglit-util-cl.c index dba32636f..0211c1ff6 100644 --- a/tests/util/piglit-util-cl.c +++ b/tests/util/piglit-util-cl.c @@ -1095,6 +1095,7 @@ piglit_cl_create_image(piglit_cl_context context, cl_mem_flags flags, desc->image_depth, 0, 0, NULL, &errNo); } else { + errNo = CL_INVALID_OPERATION; fprintf(stderr, "Invalid image mem object type: %s\n", piglit_cl_get_enum_name(desc->image_type)); |