summaryrefslogtreecommitdiff
path: root/framework
diff options
context:
space:
mode:
authorNeil Roberts <nroberts@igalia.com>2018-11-08 01:28:00 +0100
committerNeil Roberts <nroberts@igalia.com>2018-11-09 09:18:28 +0100
commit81c1cb497d9489e560b8c607300ab7c26e9332b9 (patch)
treea621e0e1b20a3c1ce563f1d122cdf3c8ce2189a5 /framework
parent386bf53a1f6029430143bebe5220e1cf1841f960 (diff)
framework/test: Use relative paths in the filename for VkRunnerTest
Previously the filename was the full path to the test. This would break if the filename was serialized and installed to a different location. The code is based on what is done for ASMParserTest. However I have a suspicion that this won’t work for running generated tests from an out-of-tree build. In that case the path no longer contains the path to the build directory. If this really is a problem it will need to be fixed for ASMParserTest too so it could be done in a separate patch. In the meantime there aren’t any generated VkRunner tests yet so it’s not really a problem. Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Diffstat (limited to 'framework')
-rw-r--r--framework/test/piglit_test.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/framework/test/piglit_test.py b/framework/test/piglit_test.py
index b64110bbc..166c2f792 100644
--- a/framework/test/piglit_test.py
+++ b/framework/test/piglit_test.py
@@ -244,14 +244,14 @@ class VkRunnerTest(PiglitBaseTest):
'vkrunner', 'bin', fallback='vkrunner')
super(VkRunnerTest, self).__init__(
- [vkrunner_bin, filename],
+ [vkrunner_bin],
run_concurrent=True)
self.filename = filename
@PiglitBaseTest.command.getter
def command(self):
- # This is overriden because we don't want PiglitBaseTest to
- # prepend TEST_BIN_DIR so that it will look for vkrunner in
+ # self._command is used because we don't want PiglitBaseTest
+ # to prepend TEST_BIN_DIR so that it will look for vkrunner in
# the search path.
- return self._command
+ return self._command + [os.path.join(ROOT_DIR, self.filename)]