diff options
| author | Kenneth Graunke <kenneth@whitecape.org> | 2012-03-02 17:07:57 -0800 |
|---|---|---|
| committer | Kenneth Graunke <kenneth@whitecape.org> | 2012-03-12 16:30:08 -0700 |
| commit | fefa962e6e373c67570988db264c0664cf71110d (patch) | |
| tree | 66f7dc219f8e9efbf0aa482c7968c155cbe47fc2 /framework/gleantest.py | |
| parent | 55107415f69101523f105da8db63d65a8bc3c3eb (diff) | |
Make valgrind testing a command line option rather than extra tests.
Valgrind testing is useful, but really should be done as a separate
exercise from the usual regression testing, as it takes way too long.
Rather than including it by default in all.tests and making people
exclude it with the -x valgrind option (or by using quick.tests), it
makes sense to explicitly request valgrind testing with --valgrind.
To perform valgrind testing:
$ piglit-run.py --valgrind <options> tests/quick.tests results/vg-1
The ExecTest class now handles Valgrind wrapping natively, rather than
relying on the tests/valgrind-test/valgrind-test shell script wrapper.
This provides a huge benefit: we can leverage the interpretResult()
function to make it work properly for any subclass of ExecTest. The
old shell script only worked for PlainExecTest (piglit) and GleanTest.
Another small benefit is that you can now use --valgrind with any test
profile (such as quick.tests). Also, you can use all.tests without
having to remember to specify "-x valgrind".
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Diffstat (limited to 'framework/gleantest.py')
| -rw-r--r-- | framework/gleantest.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/framework/gleantest.py b/framework/gleantest.py index 0bab36a0c..a90a10170 100644 --- a/framework/gleantest.py +++ b/framework/gleantest.py @@ -49,9 +49,9 @@ class GleanTest(ExecTest): self.name = name - def run(self): + def run(self, valgrind): self.command += GleanTest.globalParams - return ExecTest.run(self) + return ExecTest.run(self, valgrind) def interpretResult(self, out, results): if out.find('FAIL') >= 0: |