diff options
| author | Rhys Perry <pendingchaos02@gmail.com> | 2021-02-05 10:35:03 +0000 |
|---|---|---|
| committer | Marge Bot <eric+marge@anholt.net> | 2021-03-24 14:02:41 +0000 |
| commit | 561fcfb50f9c528d0df8dda33022945f0c4da8fe (patch) | |
| tree | ab81d5198d723dd1667d6053915491af125c683c /src/amd | |
| parent | 5313ad8e45b84758cb23f0ae317ab22817b07db4 (diff) | |
aco: don't optimize min(a*1.0, ...) to min(a, ...) on GFX8
fossil-db (GFX8):
Totals from 2 (0.00% of 147787) affected shaders:
VMEM: 662 -> 642 (-3.02%)
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9079>
Diffstat (limited to 'src/amd')
| -rw-r--r-- | src/amd/compiler/aco_optimizer.cpp | 27 |
1 files changed, 23 insertions, 4 deletions
diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp index 952c5f3ee4e..e89201bd3d2 100644 --- a/src/amd/compiler/aco_optimizer.cpp +++ b/src/amd/compiler/aco_optimizer.cpp @@ -889,9 +889,28 @@ bool fixed_to_exec(Operand op) return op.isFixed() && op.physReg() == exec; } -bool can_eliminate_fcanonicalize(aco_opcode op) +bool does_fp_op_flush_denorms(opt_ctx &ctx, aco_opcode op) { - return instr_info.can_use_input_modifiers[(int)op] && op != aco_opcode::v_cndmask_b32; + if (ctx.program->chip_class <= GFX8) { + switch (op) { + case aco_opcode::v_min_f32: + case aco_opcode::v_max_f32: + case aco_opcode::v_med3_f32: + case aco_opcode::v_min3_f32: + case aco_opcode::v_max3_f32: + case aco_opcode::v_min_f16: + case aco_opcode::v_max_f16: + return false; + default: + break; + } + } + return op != aco_opcode::v_cndmask_b32; +} + +bool can_eliminate_fcanonicalize(opt_ctx &ctx, aco_opcode op) +{ + return instr_info.can_use_input_modifiers[(int)op] && does_fp_op_flush_denorms(ctx, op); } void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr) @@ -943,7 +962,7 @@ void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr) /* VALU: propagate neg, abs & inline constants */ else if (instr->isVALU()) { - bool is_fp = can_eliminate_fcanonicalize(instr->opcode); + bool is_fp = can_eliminate_fcanonicalize(ctx, instr->opcode); if ((info.is_temp() || (info.is_fcanonicalize() && is_fp)) && info.temp.type() == RegType::vgpr && valu_can_accept_vgpr(instr, i)) { instr->operands[i].setTemp(info.temp); info = ctx.info[info.temp.id()]; @@ -2555,7 +2574,7 @@ void apply_sgprs(opt_ctx &ctx, aco_ptr<Instruction>& instr) sgpr_ids[!!sgpr_ids[0]] = instr->operands[i].tempId(); } ssa_info& info = ctx.info[instr->operands[i].tempId()]; - if ((info.is_temp() || (info.is_fcanonicalize() && can_eliminate_fcanonicalize(instr->opcode))) && + if ((info.is_temp() || (info.is_fcanonicalize() && can_eliminate_fcanonicalize(ctx, instr->opcode))) && info.temp.type() == RegType::sgpr) operand_mask |= 1u << i; } |