diff options
author | Al Viro <viro@ZenIV.linux.org.uk> | 2014-09-12 20:56:04 +0100 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2014-09-12 20:58:55 +0100 |
commit | cfb2f9d5c921e38b0f12bb26fed10b877664444d (patch) | |
tree | c48f758a0b66ec32d15e4ff5a42334a72889a1b5 /fs/gfs2/incore.h | |
parent | a937cca270c544c4319572b57b196b2251b07dd2 (diff) |
GFS2: fix d_splice_alias() misuses
Callers of d_splice_alias(dentry, inode) don't need iput(), neither
on success nor on failure. Either the reference to inode is stored
in a previously negative dentry, or it's dropped. In either case
inode reference the caller used to hold is consumed.
__gfs2_lookup() does iput() in case when d_splice_alias() has failed.
Double iput() if we ever hit that. And gfs2_create_inode() ends up
not only with double iput(), but with link count dropped to zero - on
an inode it has just found in directory.
Cc: stable@vger.kernel.org # v3.14+
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/incore.h')
0 files changed, 0 insertions, 0 deletions