diff options
| author | Luis de Bethencourt <luis.bg@samsung.com> | 2015-01-13 15:07:56 +0000 |
|---|---|---|
| committer | Luis de Bethencourt <luis.bg@samsung.com> | 2015-01-13 15:14:38 +0000 |
| commit | a91d521a3602f33083405467db9454d422b9da1b (patch) | |
| tree | af8dd905bceabb491db1700f71f467f67971785c /ext/libvisual/gstaudiovisualizer.c | |
| parent | 7cc048f4df3cd51b84a628021b9f8cf0a92045fe (diff) | |
visual: remove unnecessary variable
klass->setup (scope) will always return TRUE since all children of this class
do so, no need to store the return. Besides, the value is overwritten a few
lines down before it is ever used. Save the unnecessary memory and instructions.
CID #1226467
Diffstat (limited to 'ext/libvisual/gstaudiovisualizer.c')
| -rw-r--r-- | ext/libvisual/gstaudiovisualizer.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/ext/libvisual/gstaudiovisualizer.c b/ext/libvisual/gstaudiovisualizer.c index 639f1e489..f9eb5be02 100644 --- a/ext/libvisual/gstaudiovisualizer.c +++ b/ext/libvisual/gstaudiovisualizer.c @@ -726,7 +726,6 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps) { GstVideoInfo info; GstAudioVisualizerClass *klass; - gboolean res; if (!gst_video_info_from_caps (&info, caps)) goto wrong_caps; @@ -751,7 +750,7 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps) GST_MAP_READWRITE); if (klass->setup) - res = klass->setup (scope); + klass->setup (scope); GST_DEBUG_OBJECT (scope, "video: dimension %dx%d, framerate %d/%d", GST_VIDEO_INFO_WIDTH (&info), GST_VIDEO_INFO_HEIGHT (&info), @@ -762,9 +761,7 @@ gst_audio_visualizer_src_setcaps (GstAudioVisualizer * scope, GstCaps * caps) gst_pad_set_caps (scope->srcpad, caps); /* find a pool for the negotiated caps now */ - res = gst_audio_visualizer_do_bufferpool (scope, caps); - - return res; + return gst_audio_visualizer_do_bufferpool (scope, caps); /* ERRORS */ wrong_caps: |