diff options
| author | Vineeth TM <vineeth.tm@samsung.com> | 2015-07-31 13:31:56 +0900 |
|---|---|---|
| committer | Thiago Santos <thiagoss@osg.samsung.com> | 2015-08-05 14:33:35 -0300 |
| commit | 0a3fe31f26d254a9570eb01f8e61468ba3014d53 (patch) | |
| tree | dec7ad73dd91c435f1a033d2fe5932e9ec7038a9 | |
| parent | 7db376d05ed5ee16af8eda18032a4b70b8a8ad40 (diff) | |
decodebin: fix deadend_details string leak
deadend_details need not be returned when the pad is not a deadend.
Hence checking if res value is TRUE and clearing the string instead of
passing it on
https://bugzilla.gnome.org/show_bug.cgi?id=753088
| -rw-r--r-- | gst/playback/gstdecodebin2.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gst/playback/gstdecodebin2.c b/gst/playback/gstdecodebin2.c index cc36c9f38..0cf65e6dc 100644 --- a/gst/playback/gstdecodebin2.c +++ b/gst/playback/gstdecodebin2.c @@ -2545,7 +2545,8 @@ beach: gst_object_unref (mqpad); if (error_details) - *deadend_details = g_string_free (error_details, (error_details->len == 0)); + *deadend_details = g_string_free (error_details, (error_details->len == 0 + || res)); else *deadend_details = NULL; |