Age | Commit message (Collapse) | Author | Files | Lines |
|
To avoid cluttering the UI with unecessary fields, only show composer
fields when there is composer metadata or when the user sets the genre
to one of 'classical', 'lieder', 'opera', 'chamber' or 'musical'.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
utility function to test if string is NULL, NUL or just ascii space.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
We should not be able to edit tag data while extracting tracks.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
To avoid cluttering the UI with unnecessary fields the composer label
and entry are hidden by default and will only shown for classical
albums.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Use composer metadata in the track data structures to set the track
composer when updating the UI.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Add track composers to the listview and support for editing them in
on_cell_edited.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
The old macro is now GStreamer 0.10 only.
See https://bugzilla.gnome.org/show_bug.cgi?id=682968
|
|
|
|
|
|
|
|
|
|
The Unselect all/Select all menu entries have been removed as part
of the addition of the app menu an were only accessible through a
keyboard shortcut. After a discussion with the design team, readd
a button to provide this functionality.
https://bugzilla.gnome.org/show_bug.cgi?id=675245
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=675245
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=675245
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=675245
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=675245
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=675245
|
|
|
|
sound_juicer_CFLAGS definition block was duplicated in src/Makefile.am
causing warning from the autotools when running autogen.sh
|
|
|
|
|
|
Move generation of the icon cache to an (un)install hook, which
should ensure that it's done after all needed files are in place.
This should fix make distcheck which otherwise errors out with:
ERROR: files left after uninstall:
./share/icons/hicolor/icon-theme.cache
|
|
|
|
|
|
|
|
This will make sure that the optimal audio sink is chosen and no video
is played whatsoever.
|
|
|
|
|
|
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=676748
|
|
Issue found with valgrind
|
|
Update sound-juicer to use version 5 of musicbrainz. This is
mostly a straight substitution (MUSICBRAINZ4→MUSICBRAINZ5,
Mb4→Mb5, and so on).
routines:
Drop conditional support for version 3 of the API, leaving 5
only.
https://bugzilla.gnome.org/show_bug.cgi?id=676749
|
|
Libmusicbrainz 4.0.3 deprecates this in favor of
mb4_releasegroup_get_primarytype
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Previous versions no-longer work after a schema update to Musicbrainz.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Now that we have a helper to iterate over all relations, better
to use it as much as possible. It would probably be more efficient
to have a relationlist_list_foreach helper iterating over RelationList
items contained in a RelationListList, and a relationlist_foreach helper
iterating over Relation items contained in a RelationList.
This would allow fill_relations to avoid iterating over and over
on the RelationListList while it's always only interested in the
'url' RelationLists.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
libmusicbrainz 4.0.1 deprecates the mb4_xxx_get_relationlist methods in
favor of mb4_xxx_get_relationlistlist methods to enable access to all
the relationlists associated with an object. Loop over all lists instead
of just the one that was returned with mb4_xxx_get_relationlist.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Musicbrainz relations do not provide an album composer. If all the
tracks have the same or have no composer use the composer and
composer_sortname from the first track, if they have
differing composers set the album composer and composer_sortname to
"Various Composers".
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
fill_work_relations and fill_recording_relations are using the
same code to iterate over the relations contained in a
RelationListList. This commit moves the common code in a helper
function and changes these 2 functions to use it.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
In Musicbrainz composers are related to works via composer relationships
and works are in turn related to recordings via performance
relationships. Use these to fill the composer metadata. This could
easily be extended to arrangers and lyricists.
Musicbrainz allows more than one relationship list to be associated with
any given object, however libmusicbrainz 4.0.0 only supported retrieving
one of them. This lead to problems getting the composer data for some
albums. Thanks go Andy Hawkins, the libmusicbrainz maintainer for
extending the API in version 4.0.1 to support retrieving all
relationship lists for an object.
Get track duration data from Mb4Track instead of Mb4Recording as the
track data is more accurate. (During testing several albums had no
duration data in their recording objects and some had incorrect data.)
This is how we got the track duration when we used libmusicbrainz3 and
it was reliable then.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
This is required to support objects with multiple relation lists, which
are used in the composer metadata parsing.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Since we are currently adding more fields to AlbumDetails and
TrackDetails, this makes this initialization code more future-proof.
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
Editors that strip trailing whitespace litter code changes with extra
changes from striping the whitespace. Prevent this by stripping all
trailing whitespace with
sed -i 's/ *$//' {src/libjuicer}/*.[ch]
https://bugzilla.gnome.org/show_bug.cgi?id=661646
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=676000
|