bus/test: assert that the client isn't listed, when appropriatewip-orphaned-test-stuff

If it was already in the list in these situations, it would be a
reference leak.

1 files changed, 6 insertions, 1 deletions

diff --git a/bus/test.c b/bus/test.c
index 6efad6e0..d05c8fab 100644
--- a/bus/test.c
+++ b/bus/test.c
@@ -133,6 +133,9 @@ bus_setup_debug_client (DBusConnection *connection)
 {
   dbus_bool_t retval;
 
+  /* it had better not be there already */
+  _dbus_assert (_dbus_list_find_last (&clients, connection) == NULL);
+
   if (!dbus_connection_add_filter (connection,
                                    client_disconnect_filter,
                                    NULL, NULL))
@@ -179,7 +182,9 @@ bus_setup_debug_client (DBusConnection *connection)
       dbus_connection_set_timeout_functions (connection,
                                              NULL, NULL, NULL, NULL, NULL);
 
-      _dbus_list_remove_last (&clients, connection);
+      /* we failed to add it (the last thing we do) or never tried, so it
+       * had better not be there */
+      _dbus_assert (_dbus_list_find_last (&clients, connection) == NULL);
 
       if (clients == NULL)
         {