summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Schmidt <jan@centricular.com>2017-11-23 23:01:52 +1100
committerJan Schmidt <jan@centricular.com>2017-11-24 01:48:32 +1100
commitc91187c187d779ae7d6e6ec0a8ac206e7d9fde67 (patch)
tree3f4a48ffd23e703df2ad00df57c9f0bc02015dfc
parentb906601c7bed2aa50ba2d3bddf423b4af375de17 (diff)
viv-fb: Don't destroy the native FB display
It causes crashes in applications because the result of fbGetDisplay() might be in use elsewhere in the application and Vivante doesn't seem to do any refcounting
-rw-r--r--gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c b/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c
index 48815e52f..b90273e4e 100644
--- a/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c
+++ b/gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c
@@ -59,8 +59,8 @@ gst_gl_display_viv_fb_finalize (GObject * object)
{
GstGLDisplayVivFB *display_viv_fb = GST_GL_DISPLAY_VIV_FB (object);
- if (display_viv_fb->display)
- fbDestroyDisplay (display_viv_fb->display);
+ // We don't destroy the FB Display - it causes crashes in applications
+ // because Vivante doesn't seem to do any refcounting
G_OBJECT_CLASS (gst_gl_display_viv_fb_parent_class)->finalize (object);
}