diff options
| author | Ding Xiang <dingxiang@cmss.chinamobile.com> | 2023-08-30 18:11:48 +0800 |
|---|---|---|
| committer | Mickaël Salaün <mic@digikod.net> | 2023-08-30 18:53:08 +0200 |
| commit | 2a2015495142ee0a35711b5dcf7b215c31489f27 (patch) | |
| tree | ad1bc548c8e46f24549c895201f00d1bff86fbd6 /tools/testing | |
| parent | 246c713a3655c840337c4b24d3838558673c0d6b (diff) | |
selftests/landlock: Fix a resource leak
The opened file should be closed before return, otherwise resource leak
will occur.
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20230830101148.3738-1-dingxiang@cmss.chinamobile.com
Fixes: 3de64b656b3c ("selftests/landlock: Add supports_filesystem() helper")
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Diffstat (limited to 'tools/testing')
| -rw-r--r-- | tools/testing/selftests/landlock/fs_test.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c index 83d565569512..251594306d40 100644 --- a/tools/testing/selftests/landlock/fs_test.c +++ b/tools/testing/selftests/landlock/fs_test.c @@ -113,7 +113,7 @@ static bool supports_filesystem(const char *const filesystem) { char str[32]; int len; - bool res; + bool res = true; FILE *const inf = fopen("/proc/filesystems", "r"); /* @@ -125,14 +125,16 @@ static bool supports_filesystem(const char *const filesystem) /* filesystem can be null for bind mounts. */ if (!filesystem) - return true; + goto out; len = snprintf(str, sizeof(str), "nodev\t%s\n", filesystem); if (len >= sizeof(str)) /* Ignores too-long filesystem names. */ - return true; + goto out; res = fgrep(inf, str); + +out: fclose(inf); return res; } |