diff options
| author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-08 00:50:58 -0500 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2019-08-08 11:12:26 +0200 |
| commit | 1be3c1fae6c1e1f5bb982b255d2034034454527a (patch) | |
| tree | 6804594da24bb8a8aa3ffe48362da900d45e8bdb /sound/firewire/packets-buffer.c | |
| parent | c7cd7c748a3250ca33509f9235efab9c803aca09 (diff) | |
ALSA: firewire: fix a memory leak bug
In iso_packets_buffer_init(), 'b->packets' is allocated through
kmalloc_array(). Then, the aligned packet size is checked. If it is
larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
However, the allocated 'b->packets' is not deallocated on this path,
leading to a memory leak.
To fix the above issue, free 'b->packets' before returning the error code.
Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: <stable@vger.kernel.org> # v2.6.39+
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/firewire/packets-buffer.c')
| -rw-r--r-- | sound/firewire/packets-buffer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/firewire/packets-buffer.c b/sound/firewire/packets-buffer.c index 0d35359d25cd..0ecafd0c6722 100644 --- a/sound/firewire/packets-buffer.c +++ b/sound/firewire/packets-buffer.c @@ -37,7 +37,7 @@ int iso_packets_buffer_init(struct iso_packets_buffer *b, struct fw_unit *unit, packets_per_page = PAGE_SIZE / packet_size; if (WARN_ON(!packets_per_page)) { err = -EINVAL; - goto error; + goto err_packets; } pages = DIV_ROUND_UP(count, packets_per_page); |