diff options
| author | David Howells <dhowells@redhat.com> | 2018-04-06 14:17:24 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2018-04-09 21:53:59 +0100 |
| commit | dd9fbcb8e10349fbd640aaa5942455912004f284 (patch) | |
| tree | f77b3d38b5abc531f8b47aef6a27a1ab979cc657 /fs/afs/xdr_fs.h | |
| parent | 0c3a5ac28115f45ee1d56717d9a9526bc6d63b05 (diff) | |
afs: Rearrange status mapping
Rearrange the AFSFetchStatus to inode attribute mapping code in a number of
ways:
(1) Use an XDR structure rather than a series of incremented pointer
accesses when decoding an AFSFetchStatus object. This allows
out-of-order decode.
(2) Don't store the if_version value but rather just check it and abort if
it's not something we can handle.
(3) Store the owner and group in the status record as raw values rather
than converting them to kuid/kgid. Do that when they're mapped into
i_uid/i_gid.
(4) Validate the type and abort code up front and abort if they're wrong.
(5) Split the inode attribute setting out into its own function from the
XDR decode of an AFSFetchStatus object. This allows it to be called
from elsewhere too.
(6) Differentiate changes to data from changes to metadata.
(7) Use the split-out attribute mapping function from afs_iget().
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/afs/xdr_fs.h')
| -rw-r--r-- | fs/afs/xdr_fs.h | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/fs/afs/xdr_fs.h b/fs/afs/xdr_fs.h new file mode 100644 index 000000000000..24e23e40c979 --- /dev/null +++ b/fs/afs/xdr_fs.h @@ -0,0 +1,40 @@ +/* AFS fileserver XDR types + * + * Copyright (C) 2018 Red Hat, Inc. All Rights Reserved. + * Written by David Howells (dhowells@redhat.com) + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public Licence + * as published by the Free Software Foundation; either version + * 2 of the Licence, or (at your option) any later version. + */ + +#ifndef XDR_FS_H +#define XDR_FS_H + +struct afs_xdr_AFSFetchStatus { + __be32 if_version; +#define AFS_FSTATUS_VERSION 1 + __be32 type; + __be32 nlink; + __be32 size_lo; + __be32 data_version_lo; + __be32 author; + __be32 owner; + __be32 caller_access; + __be32 anon_access; + __be32 mode; + __be32 parent_vnode; + __be32 parent_unique; + __be32 seg_size; + __be32 mtime_client; + __be32 mtime_server; + __be32 group; + __be32 sync_counter; + __be32 data_version_hi; + __be32 lock_count; + __be32 size_hi; + __be32 abort_code; +} __packed; + +#endif /* XDR_FS_H */ |