diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-01-21 14:55:43 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2022-01-23 18:21:27 -0800 |
| commit | c1ec0cabc36718efc7fe8b4157d41b82d08ec1d2 (patch) | |
| tree | b5d6310739692d7f6154ac877405c3a434ff79d2 /drivers/hwmon | |
| parent | f1e75e0d6a1ae02fa4189d7aeebab623bade2a21 (diff) | |
hwmon: (adt7470) Prevent divide by zero in adt7470_fan_write()
The "val" variable is controlled by the user and comes from
hwmon_attr_store(). The FAN_RPM_TO_PERIOD() macro divides by "val"
so a zero will crash the system. Check for that and return -EINVAL.
Negatives are also invalid so return -EINVAL for those too.
Fixes: fc958a61ff6d ("hwmon: (adt7470) Convert to devm_hwmon_device_register_with_info API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/adt7470.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c index d519aca4a9d6..fb6d14d213a1 100644 --- a/drivers/hwmon/adt7470.c +++ b/drivers/hwmon/adt7470.c @@ -662,6 +662,9 @@ static int adt7470_fan_write(struct device *dev, u32 attr, int channel, long val struct adt7470_data *data = dev_get_drvdata(dev); int err; + if (val <= 0) + return -EINVAL; + val = FAN_RPM_TO_PERIOD(val); val = clamp_val(val, 1, 65534); |