diff options
| author | Brian Masney <bmasney@redhat.com> | 2020-04-01 13:49:37 -0400 |
|---|---|---|
| committer | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-04-14 16:15:55 +0200 |
| commit | 7fc504b993cee79e38c0f018bf3c38940873bebd (patch) | |
| tree | 67c07cd719296eba806905bef38aa3a982b5ac87 /drivers/gpio/gpio-xgene-sb.c | |
| parent | 8f3d9f354286745c751374f5f1fcafee6b3f3136 (diff) | |
gpio: xgene-sb: set valid IRQ type in to_irq()
xgene-sb is setup to be a hierarchical IRQ chip with the GIC as the
parent chip. xgene_gpio_sb_to_irq() currently sets the default IRQ type
to IRQ_TYPE_NONE, which the GIC loudly complains about with a WARN_ON().
Let's set the initial default to a sane value (IRQ_TYPE_EDGE_RISING)
that was determined by decoding the ACPI tables on affected hardware:
Device (_SB.GPSB)
{
Name (_HID, "APMC0D15") // _HID: Hardware ID
Name (_CID, "APMC0D15") // _CID: Compatible ID
Name (_UID, "GPIOSB") // _UID: Unique ID
...
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
...
Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, ,, )
{
0x00000048,
}
...
}
}
This can be overridden later as needed with irq_set_irq_type().
Signed-off-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'drivers/gpio/gpio-xgene-sb.c')
| -rw-r--r-- | drivers/gpio/gpio-xgene-sb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index 25d86441666e..b45bfa9baa26 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -122,7 +122,7 @@ static int xgene_gpio_sb_to_irq(struct gpio_chip *gc, u32 gpio) fwspec.fwnode = gc->parent->fwnode; fwspec.param_count = 2; fwspec.param[0] = GPIO_TO_HWIRQ(priv, gpio); - fwspec.param[1] = IRQ_TYPE_NONE; + fwspec.param[1] = IRQ_TYPE_EDGE_RISING; return irq_create_fwspec_mapping(&fwspec); } |