summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLucas Tanure <tanureal@opensource.cirrus.com>2022-01-17 16:08:29 +0000
committerTakashi Iwai <tiwai@suse.de>2022-01-18 14:07:15 +0100
commita025df02ce424fa77f6bc6aa195db21677e11274 (patch)
tree1b8c47cfc2b931ce743612f5a34ecc817a7bdf4a
parentcd8abf7d04c940c627ceb6f416b2142d3e7b36dd (diff)
ALSA: hda: cs35l41: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com> Link: https://lore.kernel.org/r/20220117160830.709403-5-tanureal@opensource.cirrus.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/cs35l41_hda.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index 82f982f574a9..c317b392c3e3 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -429,8 +429,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
if (ret == -EBUSY) {
dev_info(cs35l41->dev, "Reset line busy, assuming shared reset\n");
} else {
- if (ret != -EPROBE_DEFER)
- dev_err(cs35l41->dev, "Failed to get reset GPIO: %d\n", ret);
+ dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO: %d\n", ret);
goto err;
}
}