diff options
| author | Alexander Lobakin <alexandr.lobakin@intel.com> | 2022-07-11 20:09:30 +0200 |
|---|---|---|
| committer | Yury Norov <yury.norov@gmail.com> | 2022-07-12 08:00:50 -0700 |
| commit | 30fd8cdf53a02b54b199043fcf1857db76e8badc (patch) | |
| tree | 207d67f462494fe52b63a31330ca56063b67bdc2 | |
| parent | 428bc098635680a664779f26f24fe9197d186172 (diff) | |
lib/test_bitmap: test the tail after bitmap_to_arr64()
Currently, test_bitmap_arr64() only tests bitmap_to_arr64()'s sanity
by comparing the result of double-conversion (bm -> arr64 -> bm2)
with the input bitmap. However, this may be not enough when one side
hides bugs of the second one (e.g. tail clearing, which is being
performed by both).
Expand the tests and check the tail of the actual arr64 used as
a temporary buffer for double-converting.
Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
| -rw-r--r-- | lib/test_bitmap.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index 25967cfa4ab2..98754ff9fe68 100644 --- a/lib/test_bitmap.c +++ b/lib/test_bitmap.c @@ -604,6 +604,12 @@ static void __init test_bitmap_arr64(void) pr_err("bitmap_copy_arr64(nbits == %d:" " tail is not safely cleared: %d\n", nbits, next_bit); + if ((nbits % 64) && + (arr[(nbits - 1) / 64] & ~GENMASK_ULL((nbits - 1) % 64, 0))) + pr_err("bitmap_to_arr64(nbits == %d): tail is not safely cleared: 0x%016llx (must be 0x%016llx)\n", + nbits, arr[(nbits - 1) / 64], + GENMASK_ULL((nbits - 1) % 64, 0)); + if (nbits < EXP1_IN_BITS - 64) expect_eq_uint(arr[DIV_ROUND_UP(nbits, 64)], 0xa5a5a5a5); } |