summaryrefslogtreecommitdiff
path: root/net/can
diff options
context:
space:
mode:
authorHuang Shijie <shijie8@gmail.com>2012-08-18 13:07:41 -0400
committerDavid Woodhouse <David.Woodhouse@intel.com>2012-09-29 15:06:13 +0100
commitc51803ddba10d80d9f246066802c6e359cf1d44c (patch)
treeed373709295c8213c7b7662f6e8526e48b574ca0 /net/can
parentd0788ce4924758249c9552c91cc33024d3434419 (diff)
mtd: mtdpart: break it as soon as we parse out the partitions
We may cause a memory leak when the @types has more then one parser. Take the `default_mtd_part_types` for example. The default_mtd_part_types has two parsers now: `cmdlinepart` and `ofpart`. Assume the following case: The kernel command line sets the partitions like: #gpmi-nand:20m(boot),20m(kernel),1g(rootfs),-(user) But the devicetree file(such as arch/arm/boot/dts/imx28-evk.dts) also sets the same partitions as the kernel command line does. In the current code, the partitions parsed out by the `ofpart` will overwrite the @pparts which has already set by the `cmdlinepart` parser, and the the partitions parsed out by the `cmdlinepart` is missed. A memory leak occurs. So we should break the code as soon as we parse out the partitions, In actually, this patch makes a priority order between the parsers. If one parser has already parsed out the partitions successfully, it's no need to use another parser anymore. Signed-off-by: Huang Shijie <shijie8@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'net/can')
0 files changed, 0 insertions, 0 deletions