diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2013-12-04 09:59:09 +0000 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-12-04 12:10:50 +0100 |
| commit | 70903c3ba8fa5ad391d1519c60666a389e4be597 (patch) | |
| tree | 939d23c559cc13273e48384f37031841740135ef /drivers/gpu/drm/i915/i915_dma.c | |
| parent | 5135d64b7f0c91c69af3147e5c93eec05f80b820 (diff) | |
drm/i915: Fix ordering of unbind vs unpin pages
It is useful to assert that if the object is bound, then it must have
its pages pinned to prevent the shrinker from reaping its backing store.
This is even more useful with the introduction of real-ppgtt whereupon
we may have the object bound into several vma, with each instance
pinning the backing store. This assertion breaks down during unbind
where we unpinned the backing store before decoupling the vma binding.
This can be fixed with a trivial reording of the unbind sequence, which
reinforces the
pin pages
bind to vma
...
unbind from vma
unpin pages
concept.
v2: Bonus comment
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Tested-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_dma.c')
0 files changed, 0 insertions, 0 deletions