diff options
author | Ed Swierk <eswierk@aristanetworks.com> | 2009-08-20 19:00:25 -0700 |
---|---|---|
committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-08-27 20:46:58 -0500 |
commit | ce0bd027df9c62766a5417521d0f08f27359d43f (patch) | |
tree | d6bdfb3a034bcfef2b98d3a53bb91f01731b2ea8 /slirp/main.h | |
parent | 382f074371f7dc32a34c944c845b1698e83d8c36 (diff) |
slirp: Remove our_addr code
Three problems with our_addr:
- It's determined only once when qemu starts, but the address can change
(just like the DNS configuration can).
- It's supposed to be the IP address of a host network interface, but
there's no guarantee that gethostbyname(gethostname()) actually does
that: the host might be a laptop that has only a loopback interface up,
or the hostname might be localhost.localdomain, etc.
- It's useless at best: get_dns_addr() calls it, there's no reason to
send DNS requests to a different IP address if you're running a DNS
server on the host and resolv.conf points to 127.0.0.1.
These problems are easily solved by removing the code.
Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'slirp/main.h')
-rw-r--r-- | slirp/main.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/slirp/main.h b/slirp/main.h index 28d92d8866..9f22fe1b0a 100644 --- a/slirp/main.h +++ b/slirp/main.h @@ -30,7 +30,6 @@ extern char *slirp_tty; extern char *exec_shell; extern u_int curtime; extern fd_set *global_readfds, *global_writefds, *global_xfds; -extern struct in_addr our_addr; extern struct in_addr loopback_addr; extern struct in_addr dns_addr; extern char *username; |