summaryrefslogtreecommitdiff
path: root/hw/pci
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2013-12-18 17:15:51 +0100
committerAndreas Färber <afaerber@suse.de>2013-12-24 18:02:18 +0100
commit6780a22cc71227068925e7b70faa71d6641a9b1b (patch)
treed70f310a7c4e5194b74fc2f0ed31763e5b912d0a /hw/pci
parentf54c19cacb44d2fad14aca6be08e4aa9b8423217 (diff)
qdev: Drop misleading qbus_free() function
Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8 ("qdev: Drop misleading qdev_free() function"). The qbus_free() function removes the child from the namespace and decrements the reference count. It does not, however, guarantee to free the child since the refcount may still be held. Just call object_unparent() directly. Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'hw/pci')
-rw-r--r--hw/pci/pci_bridge.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index f72872ebcf..355c3e1b06 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -391,7 +391,7 @@ void pci_bridge_exitfn(PCIDevice *pci_dev)
pci_bridge_region_cleanup(s, s->windows);
memory_region_destroy(&s->address_space_mem);
memory_region_destroy(&s->address_space_io);
- /* qbus_free() is called automatically during device deletion */
+ /* object_unparent() is called automatically during device deletion */
}
/*