summaryrefslogtreecommitdiff
path: root/hw/grlib_irqmp.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>2011-04-14 18:11:00 +0100
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>2011-04-26 13:14:49 +0100
commitb4548fcc0314f5e118ed45b5774e9cd99f9a97d3 (patch)
treecfa89cbb83dadb4889c1d9e5cfe49aee15a581c7 /hw/grlib_irqmp.c
parent1a96dd472c37ceeefc0d488cb7722c6714d2f0b7 (diff)
trace: Remove %s in grlib trace events
Trace events cannot use %s in their format strings because trace backends vary in how they can deference pointers (if at all). Recording const char * values is not meaningful if their contents are not recorded too. Change grlib trace events that rely on strings so that they communicate similar information without using strings. A follow-up patch explains this limitation and updates docs/tracing.txt. Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'hw/grlib_irqmp.c')
-rw-r--r--hw/grlib_irqmp.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/grlib_irqmp.c b/hw/grlib_irqmp.c
index f47c491a4..b8738fc04 100644
--- a/hw/grlib_irqmp.c
+++ b/hw/grlib_irqmp.c
@@ -220,7 +220,7 @@ static uint32_t grlib_irqmp_readl(void *opaque, target_phys_addr_t addr)
return state->extended[cpu];
}
- trace_grlib_irqmp_unknown_register("read", addr);
+ trace_grlib_irqmp_readl_unknown(addr);
return 0;
}
@@ -308,7 +308,7 @@ grlib_irqmp_writel(void *opaque, target_phys_addr_t addr, uint32_t value)
return;
}
- trace_grlib_irqmp_unknown_register("write", addr);
+ trace_grlib_irqmp_writel_unknown(addr, value);
}
static CPUReadMemoryFunc * const grlib_irqmp_read[] = {