diff options
| author | Jamey Sharp <jamey@minilop.net> | 2010-05-06 21:56:10 -0700 |
|---|---|---|
| committer | Jamey Sharp <jamey@minilop.net> | 2010-05-12 18:10:01 -0700 |
| commit | 04bad1b8a118a83064316d6e4327234aee19361e (patch) | |
| tree | db53939c7cf34aa3eb3b31e6af7d32c0b31af64c /dix/window.c | |
| parent | 65cedf39054cf3a1e695e84ac228cce9e8d48097 (diff) | |
Kill ChangeGC in favor of dixChangeGC.
This doesn't change any behavior, but it isn't clear whether NullClient
is correct in all cases. As ajax says,
> For most of these changes, I think it's correct to use NullClient,
> since they are server-initiated changes and should not fail for (eg)
> xace reasons. ... At any rate, you're certainly not changing any
> semantics by leaving them all as NullClient, so this patch can't be
> more wrong than before.
The call in CreateGC is particularly questionable.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Diffstat (limited to 'dix/window.c')
| -rw-r--r-- | dix/window.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/dix/window.c b/dix/window.c index 0d0321992..313593b47 100644 --- a/dix/window.c +++ b/dix/window.c @@ -328,7 +328,7 @@ MakeRootTile(WindowPtr pWin) attributes[0] = pScreen->whitePixel; attributes[1] = pScreen->blackPixel; - (void)ChangeGC(pGC, GCForeground | GCBackground, attributes); + (void)dixChangeGC(NullClient, pGC, GCForeground | GCBackground, attributes, NULL); } ValidateGC((DrawablePtr)pWin->background.pixmap, pGC); |