Tighten coding style checking

20080721134313-53eee-6fc655da0dc9b0b97ec6ec2fcb73876bb8a2c38c.gz

1 files changed, 20 insertions, 0 deletions

diff --git a/tools/check-c-style.sh b/tools/check-c-style.sh
index 357fdb365..dd62fb7ba 100644
--- a/tools/check-c-style.sh
+++ b/tools/check-c-style.sh
@@ -24,6 +24,26 @@ then
   fail=1
 fi
 
+if grep -En '[(][[:alnum:]_]+ ?\*[)][(]?[[:alpha:]_]' "$@"; then
+  echo "^^^ Our coding style is to have a space between a cast and the "
+  echo "    thing being cast"
+  fail=1
+fi
+
+# this only spots casts
+if grep -En '[(][[:alnum:]_]+\*+[)]' "$@"; then
+  echo "^^^ Our coding style is to have a space before the * of pointer types"
+  echo "    (regex 1)"
+  fail=1
+fi
+# ... and this only spots variable declarations and function return types
+if grep -En '^ *(static |const |)* *[[:alnum:]_]+\*+([[:alnum:]_]|;|$)' \
+    "$@"; then
+  echo "^^^ Our coding style is to have a space before the * of pointer types"
+  echo "    (regex 2)"
+  fail=1
+fi
+
 if test -n "$CHECK_FOR_LONG_LINES"
 then
   if egrep -n '.{80,}' "$@"